From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexander Shiyan <eagle.alexander923@gmail.com>,
inux-arm-kernel@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v2 1/2] dt-bindings: stm32: document MYD-YA15XC-T development board
Date: Fri, 1 Sep 2023 13:40:01 +0200 [thread overview]
Message-ID: <ac74775f-ea4f-7eba-e989-136524e96c81@linaro.org> (raw)
In-Reply-To: <20230901103856.31091-1-eagle.alexander923@gmail.com>
On 01/09/2023 12:38, Alexander Shiyan wrote:
> Add new entry for MYD-YA15XC-T development board.
>
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index 4466b455bffa..1bde704bcd65 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -140,6 +140,13 @@ properties:
> - const: engicam,microgea-stm32mp1
> - const: st,stm32mp157
>
> + - description: MyirTech STM32MP15x SoM based Boards
> + items:
> + - const: myir,myd-ya15xc-t # MYIR MYD-YA15XC-T STM32MP151C
> + - const: myir,myc-ya15xc-t # MYIR MYC-YA15XC-T STM32MP15X SoM
I don't think you can have one compatible for all of them. The 153 and
157 variants differ by number of CANs, which are probably enabled in
your board DTS?
Also, I cannot find ordering of 153 and 157 variants:
https://www.myirtech.com/list.asp?id=658
so I wonder if they have actually same part numbers.
> + - enum:
> + - st,stm32mp151
This is highly unusual syntax - I think no other binding in Linux kernel
uses it. It is correct and I understand why you did it, just might
confuse others as we usually NAK it. I think less confusing would be to
have here const (with the price of duplicating this per variant).
Best regards,
Krzysztof
prev parent reply other threads:[~2023-09-01 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 10:38 [PATCH v2 1/2] dt-bindings: stm32: document MYD-YA15XC-T development board Alexander Shiyan
2023-09-01 10:38 ` [PATCH v2 2/2] ARM: dts: stm32: Add MyirTech MYD-YA15XC-T development board support Alexander Shiyan
2023-09-01 11:40 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac74775f-ea4f-7eba-e989-136524e96c81@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eagle.alexander923@gmail.com \
--cc=inux-arm-kernel@lists.infradead.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).