From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 106F4C001DC for ; Wed, 19 Jul 2023 10:11:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230219AbjGSKLi (ORCPT ); Wed, 19 Jul 2023 06:11:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjGSKLh (ORCPT ); Wed, 19 Jul 2023 06:11:37 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7B417E69; Wed, 19 Jul 2023 03:11:36 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F8432F4; Wed, 19 Jul 2023 03:12:19 -0700 (PDT) Received: from [10.57.33.122] (unknown [10.57.33.122]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 730643F67D; Wed, 19 Jul 2023 03:11:33 -0700 (PDT) Message-ID: Date: Wed, 19 Jul 2023 11:11:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH V6 6/6] coresight: etm4x: Add ACPI support in platform driver From: Suzuki K Poulose To: rafael@kernel.org, Len Brown Cc: Ganapatrao Kulkarni , Steve Clevenger , Rob Herring , Frank Rowand , Russell King , Sudeep Holla , Lorenzo Pieralisi , Mathieu Poirier , Mike Leach , Leo Yan , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman Khandual , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, gregkh@linuxfoundation.org References: <20230710062500.45147-1-anshuman.khandual@arm.com> <20230710062500.45147-7-anshuman.khandual@arm.com> <38f0c8f3-5fb3-a18a-456d-867da2998786@arm.com> In-Reply-To: <38f0c8f3-5fb3-a18a-456d-867da2998786@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Rafael, Len Ping (packets 6, lost 100%). On 10/07/2023 17:40, Suzuki K Poulose wrote: > Rafael, Len > > On 10/07/2023 07:25, Anshuman Khandual wrote: >> From: Suzuki K Poulose >> >> Drop ETM4X ACPI ID from the AMBA ACPI device list, and instead just >> move it >> inside the new ACPI devices list detected and used via platform driver. >> >> Cc: "Rafael J. Wysocki" >> Cc: Len Brown >> Cc: Mathieu Poirier >> Cc: Suzuki K Poulose >> Cc: Mike Leach >> Cc: Leo Yan >> Cc: Sudeep Holla >> Cc: Lorenzo Pieralisi >> Cc: linux-acpi@vger.kernel.org >> Cc: coresight@lists.linaro.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Reviewed-by: Sudeep Holla (for ACPI specific >> changes) >> Signed-off-by: Suzuki K Poulose >> Signed-off-by: Anshuman Khandual > > We would like to queue this via coresight tree. The acpi_amba bits have > been reviewed by Sudeep. Please could you give us an Ack, if you are > happy with the proposal ? > Kind regards Suzuki > Kind regards > Suzuki > > >> --- >>   drivers/acpi/acpi_amba.c                           |  1 - >>   drivers/hwtracing/coresight/coresight-etm4x-core.c | 10 ++++++++++ >>   2 files changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/acpi_amba.c b/drivers/acpi/acpi_amba.c >> index f5b443ab01c2..099966cbac5a 100644 >> --- a/drivers/acpi/acpi_amba.c >> +++ b/drivers/acpi/acpi_amba.c >> @@ -22,7 +22,6 @@ >>   static const struct acpi_device_id amba_id_list[] = { >>       {"ARMH0061", 0}, /* PL061 GPIO Device */ >>       {"ARMH0330", 0}, /* ARM DMA Controller DMA-330 */ >> -    {"ARMHC500", 0}, /* ARM CoreSight ETM4x */ >>       {"ARMHC501", 0}, /* ARM CoreSight ETR */ >>       {"ARMHC502", 0}, /* ARM CoreSight STM */ >>       {"ARMHC503", 0}, /* ARM CoreSight Debug */ >> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c >> b/drivers/hwtracing/coresight/coresight-etm4x-core.c >> index 43f583987250..703b6fcbb6a5 100644 >> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c >> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c >> @@ -3,6 +3,7 @@ >>    * Copyright (c) 2014, The Linux Foundation. All rights reserved. >>    */ >> +#include >>   #include >>   #include >>   #include >> @@ -2347,12 +2348,21 @@ static const struct of_device_id >> etm4_sysreg_match[] = { >>       {} >>   }; >> +#ifdef CONFIG_ACPI >> +static const struct acpi_device_id etm4x_acpi_ids[] = { >> +    {"ARMHC500", 0}, /* ARM CoreSight ETM4x */ >> +    {} >> +}; >> +MODULE_DEVICE_TABLE(acpi, etm4x_acpi_ids); >> +#endif >> + >>   static struct platform_driver etm4_platform_driver = { >>       .probe        = etm4_probe_platform_dev, >>       .remove        = etm4_remove_platform_dev, >>       .driver            = { >>           .name            = "coresight-etm4x", >>           .of_match_table        = etm4_sysreg_match, >> +        .acpi_match_table    = ACPI_PTR(etm4x_acpi_ids), >>           .suppress_bind_attrs    = true, >>           .pm            = &etm4_dev_pm_ops, >>       }, >