From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Antoine Bernard <zalnir@proton.me>
Cc: Arec Kao <arec.kao@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"~postmarketos/upstreaming@lists.sr.ht"
<~postmarketos/upstreaming@lists.sr.ht>
Subject: Re: [PATCH 1/3] media: i2c: ov13b10: Add dvdd, dovdd and device tree support
Date: Mon, 23 Mar 2026 11:34:23 +0200 [thread overview]
Message-ID: <acEJHxCEjsIvCK3P@kekkonen.localdomain> (raw)
In-Reply-To: <upbCO5Ov9EM8f4ZCXKxzuKpXo5mOZ3tEI4j0VvTEZ6QQobtULxabIWkHlGTx0-iV9_nxK10rh9zLzccuYMtN0ldUKfwSDWm5I9kflUQ4sg8=@proton.me>
Hi Antoine,
On Sat, Mar 21, 2026 at 04:57:10AM +0000, Antoine Bernard wrote:
> Thanks for reviewing the patch.
>
> This is my first time sending patches to LKML, so please do
> understand if I make some mistakes.
> --
> > Error handling needs some work here.
>
> Could you perhaps tell me in detail? The logic is same as with
> avdd, so I am not quite sure how to refactor these.
What happens if enabling the last regulator fails?
>
> > ACPI supports device probing through of_match_table, too.
>
> I thought this was needed, because embedded devices don't have
> ACPI. Is it possible to not use of_match_ptr() and instead do
> .of_match_table = ov13b10_of_match directly?
Yes, please.
--
Regards,
Sakari Ailus
prev parent reply other threads:[~2026-03-23 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 9:25 [PATCH 1/3] media: i2c: ov13b10: Add dvdd, dovdd and device tree support Antoine Bernard
2026-03-20 21:34 ` Sakari Ailus
2026-03-21 4:57 ` Antoine Bernard
2026-03-23 9:34 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acEJHxCEjsIvCK3P@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=arec.kao@intel.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=zalnir@proton.me \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox