* [PATCH v4 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains
2026-03-13 11:49 [PATCH v4 0/2] Add scmi powerdomain for sky1 Gary Yang
@ 2026-03-13 11:49 ` Gary Yang
2026-03-14 9:26 ` Krzysztof Kozlowski
2026-03-13 11:49 ` [PATCH v4 2/2] arm64: dts: cix: Add scmi powerdomain nodes for sky1 Gary Yang
2026-03-24 7:17 ` (subset) [PATCH v4 0/2] Add scmi powerdomain " Manivannan Sadhasivam
2 siblings, 1 reply; 9+ messages in thread
From: Gary Yang @ 2026-03-13 11:49 UTC (permalink / raw)
To: lpieralisi, kwilczynski, mani, robh, bhelgaas, krzk+dt, conor+dt,
peter.chen
Cc: linux-pci, devicetree, linux-kernel, linux-arm-kernel,
cix-kernel-upstream, Gary Yang
The Sky1 PCIe controller resides in a dedicated power domain managed
via SCMI. Add the power-domains property to the binding to allow
describing this dependency.
Signed-off-by: Gary Yang <gary.yang@cixtech.com>
---
Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml b/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml
index b910a42e0843..d55d165f1e94 100644
--- a/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml
+++ b/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml
@@ -38,6 +38,9 @@ properties:
ranges:
maxItems: 3
+ power-domains:
+ maxItems: 1
+
required:
- compatible
- ranges
--
2.49.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v4 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains
2026-03-13 11:49 ` [PATCH v4 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains Gary Yang
@ 2026-03-14 9:26 ` Krzysztof Kozlowski
2026-03-16 8:50 ` Peter Chen
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-14 9:26 UTC (permalink / raw)
To: Gary Yang
Cc: lpieralisi, kwilczynski, mani, robh, bhelgaas, krzk+dt, conor+dt,
peter.chen, linux-pci, devicetree, linux-kernel, linux-arm-kernel,
cix-kernel-upstream
On Fri, Mar 13, 2026 at 07:49:13PM +0800, Gary Yang wrote:
> The Sky1 PCIe controller resides in a dedicated power domain managed
> via SCMI. Add the power-domains property to the binding to allow
> describing this dependency.
>
> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> ---
> Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml | 3 +++
> 1 file changed, 3 insertions(+)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains
2026-03-14 9:26 ` Krzysztof Kozlowski
@ 2026-03-16 8:50 ` Peter Chen
2026-03-24 6:44 ` Peter Chen
2026-03-24 7:13 ` Manivannan Sadhasivam
0 siblings, 2 replies; 9+ messages in thread
From: Peter Chen @ 2026-03-16 8:50 UTC (permalink / raw)
To: Krzysztof Kozlowski, mani
Cc: Gary Yang, lpieralisi, kwilczynski, mani, robh, bhelgaas, krzk+dt,
conor+dt, linux-pci, devicetree, linux-kernel, linux-arm-kernel,
cix-kernel-upstream
On 26-03-14 10:26:11, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
>
> On Fri, Mar 13, 2026 at 07:49:13PM +0800, Gary Yang wrote:
> > The Sky1 PCIe controller resides in a dedicated power domain managed
> > via SCMI. Add the power-domains property to the binding to allow
> > describing this dependency.
> >
> > Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> > ---
> > Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
Thank Krzysztof for kindly review it.
Mani, I assume this patch will go to PCIe tree, right?
--
Best regards,
Peter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains
2026-03-16 8:50 ` Peter Chen
@ 2026-03-24 6:44 ` Peter Chen
2026-03-24 7:13 ` Manivannan Sadhasivam
1 sibling, 0 replies; 9+ messages in thread
From: Peter Chen @ 2026-03-24 6:44 UTC (permalink / raw)
To: mani, bhelgaas
Cc: Gary Yang, lpieralisi, kwilczynski, robh, krzk+dt, conor+dt,
linux-pci, devicetree, linux-kernel, linux-arm-kernel,
cix-kernel-upstream
On 26-03-16 16:50:03, Peter Chen wrote:
> On 26-03-14 10:26:11, Krzysztof Kozlowski wrote:
> > EXTERNAL EMAIL
> >
> > On Fri, Mar 13, 2026 at 07:49:13PM +0800, Gary Yang wrote:
> > > The Sky1 PCIe controller resides in a dedicated power domain managed
> > > via SCMI. Add the power-domains property to the binding to allow
> > > describing this dependency.
> > >
> > > Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> > > ---
> > > Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml | 3 +++
> > > 1 file changed, 3 insertions(+)
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> >
> Thank Krzysztof for kindly review it.
>
> Mani, I assume this patch will go to PCIe tree, right?
>
Hi Bjorn,
Will this patch go to PCIe tree or I queue it at CIX SoC tree since
there is no driver change.
--
Best regards,
Peter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains
2026-03-16 8:50 ` Peter Chen
2026-03-24 6:44 ` Peter Chen
@ 2026-03-24 7:13 ` Manivannan Sadhasivam
1 sibling, 0 replies; 9+ messages in thread
From: Manivannan Sadhasivam @ 2026-03-24 7:13 UTC (permalink / raw)
To: Peter Chen
Cc: Krzysztof Kozlowski, Gary Yang, lpieralisi, kwilczynski, robh,
bhelgaas, krzk+dt, conor+dt, linux-pci, devicetree, linux-kernel,
linux-arm-kernel, cix-kernel-upstream
On Mon, Mar 16, 2026 at 04:50:03PM +0800, Peter Chen wrote:
> On 26-03-14 10:26:11, Krzysztof Kozlowski wrote:
> > EXTERNAL EMAIL
> >
> > On Fri, Mar 13, 2026 at 07:49:13PM +0800, Gary Yang wrote:
> > > The Sky1 PCIe controller resides in a dedicated power domain managed
> > > via SCMI. Add the power-domains property to the binding to allow
> > > describing this dependency.
> > >
> > > Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> > > ---
> > > Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml | 3 +++
> > > 1 file changed, 3 insertions(+)
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> >
> Thank Krzysztof for kindly review it.
>
> Mani, I assume this patch will go to PCIe tree, right?
>
Yes, I'll take it.
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4 2/2] arm64: dts: cix: Add scmi powerdomain nodes for sky1
2026-03-13 11:49 [PATCH v4 0/2] Add scmi powerdomain for sky1 Gary Yang
2026-03-13 11:49 ` [PATCH v4 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains Gary Yang
@ 2026-03-13 11:49 ` Gary Yang
2026-03-24 11:45 ` Peter Chen
2026-03-24 7:17 ` (subset) [PATCH v4 0/2] Add scmi powerdomain " Manivannan Sadhasivam
2 siblings, 1 reply; 9+ messages in thread
From: Gary Yang @ 2026-03-13 11:49 UTC (permalink / raw)
To: lpieralisi, kwilczynski, mani, robh, bhelgaas, krzk+dt, conor+dt,
peter.chen
Cc: linux-pci, devicetree, linux-kernel, linux-arm-kernel,
cix-kernel-upstream, Gary Yang
Add a second SCMI channel using SMC transport to communicate with TF-A
for power domain management on the Sky1 SoC.
Signed-off-by: Gary Yang <gary.yang@cixtech.com>
---
arch/arm64/boot/dts/cix/sky1-power.h | 33 ++++++++++++++++++++++++++++
arch/arm64/boot/dts/cix/sky1.dtsi | 21 ++++++++++++++++++
2 files changed, 54 insertions(+)
create mode 100644 arch/arm64/boot/dts/cix/sky1-power.h
diff --git a/arch/arm64/boot/dts/cix/sky1-power.h b/arch/arm64/boot/dts/cix/sky1-power.h
new file mode 100644
index 000000000000..53f4a3af36b3
--- /dev/null
+++ b/arch/arm64/boot/dts/cix/sky1-power.h
@@ -0,0 +1,33 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Copyright 2026 Cix Technology Group Co., Ltd.
+ */
+
+#ifndef __SKY1_POWER_H__
+#define __SKY1_POWER_H__
+
+/* The Rich OS need flow the macro */
+#define SKY1_PD_AUDIO 0
+#define SKY1_PD_PCIE_CTRL0 1
+#define SKY1_PD_PCIE_DUMMY 2
+#define SKY1_PD_PCIEHUB 3
+#define SKY1_PD_MMHUB 4
+#define SKY1_PD_MMHUB_SMMU 5
+#define SKY1_PD_DPU0 6
+#define SKY1_PD_DPU1 7
+#define SKY1_PD_DPU2 8
+#define SKY1_PD_DPU3 9
+#define SKY1_PD_DPU4 10
+#define SKY1_PD_VPU_TOP 11
+#define SKY1_PD_VPU_CORE0 12
+#define SKY1_PD_VPU_CORE1 13
+#define SKY1_PD_VPU_CORE2 14
+#define SKY1_PD_VPU_CORE3 15
+#define SKY1_PD_NPU_CORE0 16
+#define SKY1_PD_NPU_CORE1 17
+#define SKY1_PD_NPU_CORE2 18
+#define SKY1_PD_NPU_TOP 19
+#define SKY1_PD_ISP0 20
+#define SKY1_PD_GPU 21
+
+#endif
diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi b/arch/arm64/boot/dts/cix/sky1.dtsi
index 64b76905cbff..495ea91a63f5 100644
--- a/arch/arm64/boot/dts/cix/sky1.dtsi
+++ b/arch/arm64/boot/dts/cix/sky1.dtsi
@@ -6,6 +6,7 @@
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/cix,sky1.h>
+#include "sky1-power.h"
/ {
interrupt-parent = <&gic>;
@@ -168,6 +169,19 @@ scmi_clk: protocol@14 {
#clock-cells = <1>;
};
};
+
+ ap_to_tfa_scmi: scmi-1 {
+ compatible = "arm,scmi-smc";
+ arm,smc-id = <0xc2000001>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ shmem = <&ap_tfa_scmi_mem>;
+
+ smc_devpd: protocol@11 {
+ reg = <0x11>;
+ #power-domain-cells = <1>;
+ };
+ };
};
pmu-a520 {
@@ -428,6 +442,7 @@ pcie_x8_rc: pcie@a010000 {
#size-cells = <2>;
bus-range = <0xc0 0xff>;
device_type = "pci";
+ power-domains = <&smc_devpd SKY1_PD_PCIE_CTRL0>;
#interrupt-cells = <1>;
interrupt-map-mask = <0 0 0 0x7>;
interrupt-map = <0 0 0 1 &gic 0 0 GIC_SPI 407 IRQ_TYPE_LEVEL_HIGH 0>,
@@ -572,6 +587,12 @@ iomuxc_s5: pinctrl@16007000 {
compatible = "cix,sky1-pinctrl-s5";
reg = <0x0 0x16007000 0x0 0x1000>;
};
+
+ ap_tfa_scmi_mem: shmem@84380000 {
+ compatible = "arm,scmi-shmem";
+ reg = <0x0 0x84380000 0x0 0x80>;
+ reg-io-width = <4>;
+ };
};
timer {
--
2.49.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v4 2/2] arm64: dts: cix: Add scmi powerdomain nodes for sky1
2026-03-13 11:49 ` [PATCH v4 2/2] arm64: dts: cix: Add scmi powerdomain nodes for sky1 Gary Yang
@ 2026-03-24 11:45 ` Peter Chen
0 siblings, 0 replies; 9+ messages in thread
From: Peter Chen @ 2026-03-24 11:45 UTC (permalink / raw)
To: Gary Yang
Cc: lpieralisi, kwilczynski, mani, robh, bhelgaas, krzk+dt, conor+dt,
linux-pci, devicetree, linux-kernel, linux-arm-kernel,
cix-kernel-upstream
On 26-03-13 19:49:14, Gary Yang wrote:
> Add a second SCMI channel using SMC transport to communicate with TF-A
> for power domain management on the Sky1 SoC.
>
> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
Applied, thanks.
Peter
> ---
> arch/arm64/boot/dts/cix/sky1-power.h | 33 ++++++++++++++++++++++++++++
> arch/arm64/boot/dts/cix/sky1.dtsi | 21 ++++++++++++++++++
> 2 files changed, 54 insertions(+)
> create mode 100644 arch/arm64/boot/dts/cix/sky1-power.h
>
> diff --git a/arch/arm64/boot/dts/cix/sky1-power.h b/arch/arm64/boot/dts/cix/sky1-power.h
> new file mode 100644
> index 000000000000..53f4a3af36b3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/cix/sky1-power.h
> @@ -0,0 +1,33 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Copyright 2026 Cix Technology Group Co., Ltd.
> + */
> +
> +#ifndef __SKY1_POWER_H__
> +#define __SKY1_POWER_H__
> +
> +/* The Rich OS need flow the macro */
> +#define SKY1_PD_AUDIO 0
> +#define SKY1_PD_PCIE_CTRL0 1
> +#define SKY1_PD_PCIE_DUMMY 2
> +#define SKY1_PD_PCIEHUB 3
> +#define SKY1_PD_MMHUB 4
> +#define SKY1_PD_MMHUB_SMMU 5
> +#define SKY1_PD_DPU0 6
> +#define SKY1_PD_DPU1 7
> +#define SKY1_PD_DPU2 8
> +#define SKY1_PD_DPU3 9
> +#define SKY1_PD_DPU4 10
> +#define SKY1_PD_VPU_TOP 11
> +#define SKY1_PD_VPU_CORE0 12
> +#define SKY1_PD_VPU_CORE1 13
> +#define SKY1_PD_VPU_CORE2 14
> +#define SKY1_PD_VPU_CORE3 15
> +#define SKY1_PD_NPU_CORE0 16
> +#define SKY1_PD_NPU_CORE1 17
> +#define SKY1_PD_NPU_CORE2 18
> +#define SKY1_PD_NPU_TOP 19
> +#define SKY1_PD_ISP0 20
> +#define SKY1_PD_GPU 21
> +
> +#endif
> diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi b/arch/arm64/boot/dts/cix/sky1.dtsi
> index 64b76905cbff..495ea91a63f5 100644
> --- a/arch/arm64/boot/dts/cix/sky1.dtsi
> +++ b/arch/arm64/boot/dts/cix/sky1.dtsi
> @@ -6,6 +6,7 @@
>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/cix,sky1.h>
> +#include "sky1-power.h"
>
> / {
> interrupt-parent = <&gic>;
> @@ -168,6 +169,19 @@ scmi_clk: protocol@14 {
> #clock-cells = <1>;
> };
> };
> +
> + ap_to_tfa_scmi: scmi-1 {
> + compatible = "arm,scmi-smc";
> + arm,smc-id = <0xc2000001>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + shmem = <&ap_tfa_scmi_mem>;
> +
> + smc_devpd: protocol@11 {
> + reg = <0x11>;
> + #power-domain-cells = <1>;
> + };
> + };
> };
>
> pmu-a520 {
> @@ -428,6 +442,7 @@ pcie_x8_rc: pcie@a010000 {
> #size-cells = <2>;
> bus-range = <0xc0 0xff>;
> device_type = "pci";
> + power-domains = <&smc_devpd SKY1_PD_PCIE_CTRL0>;
> #interrupt-cells = <1>;
> interrupt-map-mask = <0 0 0 0x7>;
> interrupt-map = <0 0 0 1 &gic 0 0 GIC_SPI 407 IRQ_TYPE_LEVEL_HIGH 0>,
> @@ -572,6 +587,12 @@ iomuxc_s5: pinctrl@16007000 {
> compatible = "cix,sky1-pinctrl-s5";
> reg = <0x0 0x16007000 0x0 0x1000>;
> };
> +
> + ap_tfa_scmi_mem: shmem@84380000 {
> + compatible = "arm,scmi-shmem";
> + reg = <0x0 0x84380000 0x0 0x80>;
> + reg-io-width = <4>;
> + };
> };
>
> timer {
> --
> 2.49.0
>
--
Best regards,
Peter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH v4 0/2] Add scmi powerdomain for sky1
2026-03-13 11:49 [PATCH v4 0/2] Add scmi powerdomain for sky1 Gary Yang
2026-03-13 11:49 ` [PATCH v4 1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains Gary Yang
2026-03-13 11:49 ` [PATCH v4 2/2] arm64: dts: cix: Add scmi powerdomain nodes for sky1 Gary Yang
@ 2026-03-24 7:17 ` Manivannan Sadhasivam
2 siblings, 0 replies; 9+ messages in thread
From: Manivannan Sadhasivam @ 2026-03-24 7:17 UTC (permalink / raw)
To: lpieralisi, kwilczynski, robh, bhelgaas, krzk+dt, conor+dt,
peter.chen, Gary Yang
Cc: linux-pci, devicetree, linux-kernel, linux-arm-kernel,
cix-kernel-upstream
On Fri, 13 Mar 2026 19:49:12 +0800, Gary Yang wrote:
> v4 changes:
> - Pass dts build check with below commands:
> make O=$OUTKNL dt_binding_check
> make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=cix,sky1-pcie-host.yaml
> make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
> scripts/checkpatch.pl 000*.patch
> - delete power-domain-names property
>
> [...]
Applied, thanks!
[1/2] dt-bindings: PCI: cix,sky1-pcie-host: Add power-domains
commit: 94c62cf0698c0edbf1f118dd80ea19d0ff5d834e
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread