From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F02741CFBA; Wed, 25 Mar 2026 22:56:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774479384; cv=none; b=A37Cam8Gp6pN/tiNkXirNDr/Um5IHYwAuM1jEVu1Vn026gm2nJZPcuAPV0oHthqgmhKW3eLq//TIVf2R4s4tjdA7W29JxguNpuFdDWI8LxfIYgp2gCs+2eAyNreZS11hdjTgr7iUBZtATj4/3LMmu/at4wEcAH/AwRB90aj4QY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774479384; c=relaxed/simple; bh=1w2d3ITGOVbfzCTyT+2G94mj8V14/URsiXuFpQHnIg8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gTffAm1HcNKeRIZBLgJH67owQXSufd7C1OQ7PinyEg4J5pnyw6hWlJJk61RUIKaL9PzAhecjL6J81BIEoNJHbQ7IcAMI57DmoyWP2GvMDoPu5D7vbHtBWxRGiPPZzcu2QnCGpRvzS7a5sT/b92yoid6u1MsPe8v5Dnz1Zw2brXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OqrLtmca; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OqrLtmca" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0435BC4CEF7; Wed, 25 Mar 2026 22:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774479383; bh=1w2d3ITGOVbfzCTyT+2G94mj8V14/URsiXuFpQHnIg8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OqrLtmcaDSoQE39WKFwhGeW18R2GPkkQMe3KBsm3kRfWH+18Jujqdh49LDGLsLqU2 VnEjH77MWdywGMtcVxZf2/NGjC0K8Imj60QXavP/NVcIj1h1BQqoryy9hkhn5TqLMi Fxr3K6WMfYguId40Wq2BhMR5h5jFP3tIApKcxxaAWJJ2/F5FkPvIyk4cCT8WVh4t9O DxzVc4wl8VJFdc5yLB22KCyMO798NZjuAQa3mP0NJ3TBJf/a0WPOj9adX9XqsOEQZ0 p4FEUCcKGdmy+DS4rIt8qSnqcJmDmYBzVAWzlvKDaY9JoSDhp1hS4W/laUvj0eu2gI DUIJw6bNkygpA== Date: Wed, 25 Mar 2026 17:56:19 -0500 From: Bjorn Andersson To: Konrad Dybcio Cc: Dmitry Baryshkov , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Enable USB OTG on functional Type-C ports Message-ID: References: <20260313-topic-x13s_otg-v1-1-cb2e4a08e25d@oss.qualcomm.com> <0dfed5a0-1c07-4e7d-bca4-8183e44c3ada@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0dfed5a0-1c07-4e7d-bca4-8183e44c3ada@oss.qualcomm.com> On Thu, Mar 19, 2026 at 03:45:24PM +0100, Konrad Dybcio wrote: > On 3/13/26 3:37 PM, Dmitry Baryshkov wrote: > > On Fri, Mar 13, 2026 at 03:08:03PM +0100, Konrad Dybcio wrote: > >> From: Konrad Dybcio > >> > >> The two non-multiport USB controllers present on the platform are > >> role-switch capable, so mark them as such. They need no additional > >> plumbing, as tested on the X13s. > >> > >> Enable OTG for all devices featuring a data-role provider in one fell > >> swoop to prevent hitting the edge case where UCSI code would time out > >> trying to get a reference to a struct usb_role_switch, which wouldn't > >> be registered if dr_mode was set to anything other than (the default) > >> OTG. > >> > >> Signed-off-by: Konrad Dybcio > >> --- > >> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 8 -------- > >> arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts | 8 -------- > >> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 8 -------- > >> arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts | 8 -------- > >> arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts | 8 -------- > >> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++++ > >> 6 files changed, 4 insertions(+), 40 deletions(-) > >> > > > > Reviewed-by: Dmitry Baryshkov > > Unfortunately it seems like that while it works, it makes the x13s crash > upon resume > > It also crashes there if we flatten the DT node and I'm hoping the solution > to that will fix both, but we have to hold it for now > Please resubmit once this has been figured out. Regards, Bjorn > Konrad