Re: [PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: Enable uPD720201 and GL3590

[Bjorn Andersson <andersson@kernel.org>]

On Wed, Mar 25, 2026 at 01:35:46AM +0200, Dmitry Baryshkov wrote:
> On Mon, Mar 23, 2026 at 09:32:39PM -0500, Bjorn Andersson wrote:
> > The QCS6490 Rb3Gen2 has a Renesas μPD720201 XHCI controller hanging off
> > the TC9563 PCIe switch, on this a Genesys Logic GL3590 USB hub provides
> > two USB Type-A ports and an ASIX AX88179 USB 3.0 Gigabit Ethernet
> > interface.
> > 
> > The Renesas chip is powered by two regulators controlled through PM7250B
> > GPIOs 1 and 4, and the power/reset pin is pulled down by PM8350C GPIO 4.
> > The Genesys chip power is always-on, but the reset pin is controlled
> > through TLMM GPIO 162.
> > 
> > Describe the Renesas chip on the PCIe bus, with supplies and reset, to
> > allow it to be brought out of reset and discovered. Then describe the
> > two peers of the USB hub, with its reset GPIO, to allow this to be
> > brought out of reset.
> > 
> > The USB Type-A connectors are not described, as they are in no regard
> > controlled by the operating system.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
> > ---
> > Dependencies has now landed, so this provides USB Type-A and Ethernet
> > support (when renesas_usb_fw.mem) is present.
> 
> Note, I initially applied the patch to the bit old -next (20260317) and
> I ended up with no PCIe host at all (bare -next would still show the
> PCIe host and the TC9563 bridge).
> 

Applied the patch to next-20260323 and tested again.

> 
> ANyway, does this actually work for you?

Yes, I booted with pcie_aspm=off I have functional ethernet and I can
plug/unplug a USB storage device and access the content on this.

> The hub is detected, but the USB bus is empty.

I've disconnected the USB stick again, so here's the output when only
ethernet is present.

/:  Bus 001.Port 001: Dev 001, Class=root_hub, Driver=xhci-pci-renesas/4p, 480M
    |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 480M
/:  Bus 002.Port 001: Dev 001, Class=root_hub, Driver=xhci-pci-renesas/4p, 5000M
    |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 5000M
        |__ Port 001: Dev 003, If 0, Class=Vendor Specific Class, Driver=ax88179_178a, 5000M

> I tried plugging in several devices (includin the
> powered USB hub) and they were completely ignored by the hub.
> 

The USB stick above was powered by the device, so that part is tested as
well. (And schematics shows VBUS is always present on the Type-A ports).

Regards,
Bjorn

> FWIW I tried both the the pcie_aspm=off and w/o it.
> 
> > Missing from the RFC/v1 description was the mentioning that unless I
> > pass "pcie_aspm=off" to the kernel, the Renesas controller fails with:
> > 
> >   xhci-pci-renesas 0001:04:00.0: Abort failed to stop command ring: -110
> 
> Interesting, it "worked" in my case, having everythign built in into the
> kernel.
> 
> > ---
> > Changes in v2:
> > - Waited for dependencies to land.
> > - Dropped "RFC".
> > - Link to v1: https://lore.kernel.org/r/20260212-rb3gen2-upd-gl3590-v1-1-18fb04bb32b0@oss.qualcomm.com
> > ---
> >  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 93 ++++++++++++++++++++++++++++
> >  1 file changed, 93 insertions(+)
> > 
> 
> -- 
> With best wishes
> Dmitry