[PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: Enable uPD720201 and GL3590

[PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: Enable uPD720201 and GL3590

[Bjorn Andersson]

The QCS6490 Rb3Gen2 has a Renesas μPD720201 XHCI controller hanging off
the TC9563 PCIe switch, on this a Genesys Logic GL3590 USB hub provides
two USB Type-A ports and an ASIX AX88179 USB 3.0 Gigabit Ethernet
interface.

The Renesas chip is powered by two regulators controlled through PM7250B
GPIOs 1 and 4, and the power/reset pin is pulled down by PM8350C GPIO 4.
The Genesys chip power is always-on, but the reset pin is controlled
through TLMM GPIO 162.

Describe the Renesas chip on the PCIe bus, with supplies and reset, to
allow it to be brought out of reset and discovered. Then describe the
two peers of the USB hub, with its reset GPIO, to allow this to be
brought out of reset.

The USB Type-A connectors are not described, as they are in no regard
controlled by the operating system.

Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
---
Dependencies has now landed, so this provides USB Type-A and Ethernet
support (when renesas_usb_fw.mem) is present.

Missing from the RFC/v1 description was the mentioning that unless I
pass "pcie_aspm=off" to the kernel, the Renesas controller fails with:

  xhci-pci-renesas 0001:04:00.0: Abort failed to stop command ring: -110
---
Changes in v2:
- Waited for dependencies to land.
- Dropped "RFC".
- Link to v1: https://lore.kernel.org/r/20260212-rb3gen2-upd-gl3590-v1-1-18fb04bb32b0@oss.qualcomm.com
---
 arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 93 ++++++++++++++++++++++++++++
 1 file changed, 93 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index cd54525e45e0f58c7c4d21b010422b55e5fbbb77..e393ccf1884afde7816739053d41ca789acfca91 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -262,6 +262,28 @@ active-config0 {
 		};
 	};
 
+	vreg_pcie0_1p05: regulator-pcie0-1p05v {
+		compatible = "regulator-fixed";
+		regulator-name = "PCIE0_1.05V";
+		gpio = <&pm7250b_gpios 4 GPIO_ACTIVE_HIGH>;
+		regulator-min-microvolt = <1050000>;
+		regulator-max-microvolt = <1050000>;
+		enable-active-high;
+		pinctrl-0 = <&upd_pwr_en2_state>;
+		pinctrl-names = "default";
+	};
+
+	vreg_pcie0_3p3: regulator-pcie0-3p3v-dual {
+		compatible = "regulator-fixed";
+		regulator-name = "PCIE0_3.3V_Dual";
+		gpio = <&pm7250b_gpios 1 GPIO_ACTIVE_HIGH>;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		enable-active-high;
+		pinctrl-0 = <&upd_pwr_en1_state>;
+		pinctrl-names = "default";
+	};
+
 	vdd_ntn_0p9: regulator-vdd-ntn-0p9 {
 		compatible = "regulator-fixed";
 		regulator-name = "VDD_NTN_0P9";
@@ -870,6 +892,41 @@ pcie@2,0 {
 			device_type = "pci";
 			ranges;
 			bus-range = <0x4 0xff>;
+
+			/* Renesas μPD720201 PCIe USB3.0 Host Controller */
+			usb-controller@0,0 {
+				compatible = "pci1912,0014";
+				reg = <0x40000 0x0 0x0 0x0 0x0>;
+
+				avdd33-supply = <&vreg_pcie0_3p3>;
+				vdd10-supply = <&vreg_pcie0_1p05>;
+				vdd33-supply = <&vreg_pcie0_3p3>;
+
+				pinctrl-0 = <&upd_hub_rst_state>;
+				pinctrl-names = "default";
+
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				/* Genesys Logic GL3590 USB Hub Controller */
+				gl3590_2_0: hub@1 {
+					compatible = "usb5e3,610";
+					reg = <1>;
+					reset-gpios = <&tlmm 162 GPIO_ACTIVE_HIGH>;
+
+					pinctrl-0 = <&usb_hub_reset_state>;
+					pinctrl-names = "default";
+
+					peer-hub = <&gl3590_3_0>;
+				};
+
+				gl3590_3_0: hub@2 {
+					compatible = "usb5e3,625";
+					reg = <2>;
+
+					peer-hub = <&gl3590_2_0>;
+				};
+			};
 		};
 
 		pcie@3,0 {
@@ -1198,6 +1255,17 @@ ntn_1p8_en: ntn-1p8-en-state {
 		power-source = <0>;
 	};
 
+	upd_hub_rst_state: upd-hub-rst-state {
+		pins = "gpio4";
+		function = "normal";
+
+		bias-disable;
+		input-disable;
+		output-enable;
+		output-high;
+		power-source = <0>;
+	};
+
 	tc9563_resx_n: tc9563-resx-state {
 		pins = "gpio1";
 		function = "normal";
@@ -1378,6 +1446,15 @@ &edp_hot_plug_det {
 };
 
 &pm7250b_gpios {
+	upd_pwr_en1_state: upd-pwr-en1-state {
+		pins = "gpio1";
+		function = "normal";
+
+		output-enable;
+		input-disable;
+		power-source = <0>;
+	};
+
 	lt9611_rst_pin: lt9611-rst-state {
 		pins = "gpio2";
 		function = "normal";
@@ -1386,6 +1463,15 @@ lt9611_rst_pin: lt9611-rst-state {
 		input-disable;
 		power-source = <0>;
 	};
+
+	upd_pwr_en2_state: upd-pwr-en2-state {
+		pins = "gpio4";
+		function = "normal";
+
+		output-enable;
+		input-disable;
+		power-source = <0>;
+	};
 };
 
 &sdc2_clk {
@@ -1431,6 +1517,13 @@ sd_cd: sd-cd-state {
 		function = "gpio";
 		bias-pull-up;
 	};
+
+	usb_hub_reset_state: usb-hub-reset-state {
+		pins = "gpio162";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+	};
 };
 
 &lpass_audiocc {

---
base-commit: 09c0f7f1bcdbc3c37a5a760cbec76bf18f278406
change-id: 20260212-rb3gen2-upd-gl3590-d110dd722e1b

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>

Re: [PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: Enable uPD720201 and GL3590

[Konrad Dybcio]

On 3/24/26 3:32 AM, Bjorn Andersson wrote:
> The QCS6490 Rb3Gen2 has a Renesas μPD720201 XHCI controller hanging off
> the TC9563 PCIe switch, on this a Genesys Logic GL3590 USB hub provides
> two USB Type-A ports and an ASIX AX88179 USB 3.0 Gigabit Ethernet
> interface.
> 
> The Renesas chip is powered by two regulators controlled through PM7250B
> GPIOs 1 and 4, and the power/reset pin is pulled down by PM8350C GPIO 4.
> The Genesys chip power is always-on, but the reset pin is controlled
> through TLMM GPIO 162.
> 
> Describe the Renesas chip on the PCIe bus, with supplies and reset, to
> allow it to be brought out of reset and discovered. Then describe the
> two peers of the USB hub, with its reset GPIO, to allow this to be
> brought out of reset.
> 
> The USB Type-A connectors are not described, as they are in no regard
> controlled by the operating system.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
> ---
> Dependencies has now landed, so this provides USB Type-A and Ethernet
> support (when renesas_usb_fw.mem) is present.
> 
> Missing from the RFC/v1 description was the mentioning that unless I
> pass "pcie_aspm=off" to the kernel, the Renesas controller fails with:
> 
>   xhci-pci-renesas 0001:04:00.0: Abort failed to stop command ring: -110

+Mani another quirky piece of hw, perhaps?
Maybe +Krishna has the datasheet. does the it talk about ASPM?

Konrad

Re: [PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: Enable uPD720201 and GL3590

[Konrad Dybcio]

On 3/24/26 3:32 AM, Bjorn Andersson wrote:
> The QCS6490 Rb3Gen2 has a Renesas μPD720201 XHCI controller hanging off
> the TC9563 PCIe switch, on this a Genesys Logic GL3590 USB hub provides
> two USB Type-A ports and an ASIX AX88179 USB 3.0 Gigabit Ethernet
> interface.
> 
> The Renesas chip is powered by two regulators controlled through PM7250B
> GPIOs 1 and 4, and the power/reset pin is pulled down by PM8350C GPIO 4.
> The Genesys chip power is always-on, but the reset pin is controlled
> through TLMM GPIO 162.
> 
> Describe the Renesas chip on the PCIe bus, with supplies and reset, to
> allow it to be brought out of reset and discovered. Then describe the
> two peers of the USB hub, with its reset GPIO, to allow this to be
> brought out of reset.
> 
> The USB Type-A connectors are not described, as they are in no regard
> controlled by the operating system.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: Enable uPD720201 and GL3590

[Krishna Kurapati]

On 3/24/2026 3:07 PM, Konrad Dybcio wrote:
> On 3/24/26 3:32 AM, Bjorn Andersson wrote:
>> The QCS6490 Rb3Gen2 has a Renesas μPD720201 XHCI controller hanging off
>> the TC9563 PCIe switch, on this a Genesys Logic GL3590 USB hub provides
>> two USB Type-A ports and an ASIX AX88179 USB 3.0 Gigabit Ethernet
>> interface.
>>
>> The Renesas chip is powered by two regulators controlled through PM7250B
>> GPIOs 1 and 4, and the power/reset pin is pulled down by PM8350C GPIO 4.
>> The Genesys chip power is always-on, but the reset pin is controlled
>> through TLMM GPIO 162.
>>
>> Describe the Renesas chip on the PCIe bus, with supplies and reset, to
>> allow it to be brought out of reset and discovered. Then describe the
>> two peers of the USB hub, with its reset GPIO, to allow this to be
>> brought out of reset.
>>
>> The USB Type-A connectors are not described, as they are in no regard
>> controlled by the operating system.
>>
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
>> ---
>> Dependencies has now landed, so this provides USB Type-A and Ethernet
>> support (when renesas_usb_fw.mem) is present.
>>
>> Missing from the RFC/v1 description was the mentioning that unless I
>> pass "pcie_aspm=off" to the kernel, the Renesas controller fails with:
>>
>>    xhci-pci-renesas 0001:04:00.0: Abort failed to stop command ring: -110
> 
> +Mani another quirky piece of hw, perhaps?
> Maybe +Krishna has the datasheet. does the it talk about ASPM?
> 

For PCIe adding, Krishna Chaitanya to thread.

Re: [PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: Enable uPD720201 and GL3590

[Dmitry Baryshkov]

On Mon, Mar 23, 2026 at 09:32:39PM -0500, Bjorn Andersson wrote:
> The QCS6490 Rb3Gen2 has a Renesas μPD720201 XHCI controller hanging off
> the TC9563 PCIe switch, on this a Genesys Logic GL3590 USB hub provides
> two USB Type-A ports and an ASIX AX88179 USB 3.0 Gigabit Ethernet
> interface.
> 
> The Renesas chip is powered by two regulators controlled through PM7250B
> GPIOs 1 and 4, and the power/reset pin is pulled down by PM8350C GPIO 4.
> The Genesys chip power is always-on, but the reset pin is controlled
> through TLMM GPIO 162.
> 
> Describe the Renesas chip on the PCIe bus, with supplies and reset, to
> allow it to be brought out of reset and discovered. Then describe the
> two peers of the USB hub, with its reset GPIO, to allow this to be
> brought out of reset.
> 
> The USB Type-A connectors are not described, as they are in no regard
> controlled by the operating system.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
> ---
> Dependencies has now landed, so this provides USB Type-A and Ethernet
> support (when renesas_usb_fw.mem) is present.

Note, I initially applied the patch to the bit old -next (20260317) and
I ended up with no PCIe host at all (bare -next would still show the
PCIe host and the TC9563 bridge).


ANyway, does this actually work for you? The hub is detected, but the
USB bus is empty. I tried plugging in several devices (includin the
powered USB hub) and they were completely ignored by the hub.

FWIW I tried both the the pcie_aspm=off and w/o it.

> Missing from the RFC/v1 description was the mentioning that unless I
> pass "pcie_aspm=off" to the kernel, the Renesas controller fails with:
> 
>   xhci-pci-renesas 0001:04:00.0: Abort failed to stop command ring: -110

Interesting, it "worked" in my case, having everythign built in into the
kernel.

> ---
> Changes in v2:
> - Waited for dependencies to land.
> - Dropped "RFC".
> - Link to v1: https://lore.kernel.org/r/20260212-rb3gen2-upd-gl3590-v1-1-18fb04bb32b0@oss.qualcomm.com
> ---
>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 93 ++++++++++++++++++++++++++++
>  1 file changed, 93 insertions(+)
> 

-- 
With best wishes
Dmitry

Re: [PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: Enable uPD720201 and GL3590

[Bjorn Andersson]

On Wed, Mar 25, 2026 at 01:35:46AM +0200, Dmitry Baryshkov wrote:
> On Mon, Mar 23, 2026 at 09:32:39PM -0500, Bjorn Andersson wrote:
> > The QCS6490 Rb3Gen2 has a Renesas μPD720201 XHCI controller hanging off
> > the TC9563 PCIe switch, on this a Genesys Logic GL3590 USB hub provides
> > two USB Type-A ports and an ASIX AX88179 USB 3.0 Gigabit Ethernet
> > interface.
> > 
> > The Renesas chip is powered by two regulators controlled through PM7250B
> > GPIOs 1 and 4, and the power/reset pin is pulled down by PM8350C GPIO 4.
> > The Genesys chip power is always-on, but the reset pin is controlled
> > through TLMM GPIO 162.
> > 
> > Describe the Renesas chip on the PCIe bus, with supplies and reset, to
> > allow it to be brought out of reset and discovered. Then describe the
> > two peers of the USB hub, with its reset GPIO, to allow this to be
> > brought out of reset.
> > 
> > The USB Type-A connectors are not described, as they are in no regard
> > controlled by the operating system.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
> > ---
> > Dependencies has now landed, so this provides USB Type-A and Ethernet
> > support (when renesas_usb_fw.mem) is present.
> 
> Note, I initially applied the patch to the bit old -next (20260317) and
> I ended up with no PCIe host at all (bare -next would still show the
> PCIe host and the TC9563 bridge).
> 

Applied the patch to next-20260323 and tested again.

> 
> ANyway, does this actually work for you?

Yes, I booted with pcie_aspm=off I have functional ethernet and I can
plug/unplug a USB storage device and access the content on this.

> The hub is detected, but the USB bus is empty.

I've disconnected the USB stick again, so here's the output when only
ethernet is present.

/:  Bus 001.Port 001: Dev 001, Class=root_hub, Driver=xhci-pci-renesas/4p, 480M
    |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 480M
/:  Bus 002.Port 001: Dev 001, Class=root_hub, Driver=xhci-pci-renesas/4p, 5000M
    |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 5000M
        |__ Port 001: Dev 003, If 0, Class=Vendor Specific Class, Driver=ax88179_178a, 5000M

> I tried plugging in several devices (includin the
> powered USB hub) and they were completely ignored by the hub.
> 

The USB stick above was powered by the device, so that part is tested as
well. (And schematics shows VBUS is always present on the Type-A ports).

Regards,
Bjorn

> FWIW I tried both the the pcie_aspm=off and w/o it.
> 
> > Missing from the RFC/v1 description was the mentioning that unless I
> > pass "pcie_aspm=off" to the kernel, the Renesas controller fails with:
> > 
> >   xhci-pci-renesas 0001:04:00.0: Abort failed to stop command ring: -110
> 
> Interesting, it "worked" in my case, having everythign built in into the
> kernel.
> 
> > ---
> > Changes in v2:
> > - Waited for dependencies to land.
> > - Dropped "RFC".
> > - Link to v1: https://lore.kernel.org/r/20260212-rb3gen2-upd-gl3590-v1-1-18fb04bb32b0@oss.qualcomm.com
> > ---
> >  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 93 ++++++++++++++++++++++++++++
> >  1 file changed, 93 insertions(+)
> > 
> 
> -- 
> With best wishes
> Dmitry

Re: [PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: Enable uPD720201 and GL3590

[Dmitry Baryshkov]

On Wed, Mar 25, 2026 at 09:40:58PM -0500, Bjorn Andersson wrote:
> On Wed, Mar 25, 2026 at 01:35:46AM +0200, Dmitry Baryshkov wrote:
> > On Mon, Mar 23, 2026 at 09:32:39PM -0500, Bjorn Andersson wrote:
> > > The QCS6490 Rb3Gen2 has a Renesas μPD720201 XHCI controller hanging off
> > > the TC9563 PCIe switch, on this a Genesys Logic GL3590 USB hub provides
> > > two USB Type-A ports and an ASIX AX88179 USB 3.0 Gigabit Ethernet
> > > interface.
> > > 
> > > The Renesas chip is powered by two regulators controlled through PM7250B
> > > GPIOs 1 and 4, and the power/reset pin is pulled down by PM8350C GPIO 4.
> > > The Genesys chip power is always-on, but the reset pin is controlled
> > > through TLMM GPIO 162.
> > > 
> > > Describe the Renesas chip on the PCIe bus, with supplies and reset, to
> > > allow it to be brought out of reset and discovered. Then describe the
> > > two peers of the USB hub, with its reset GPIO, to allow this to be
> > > brought out of reset.
> > > 
> > > The USB Type-A connectors are not described, as they are in no regard
> > > controlled by the operating system.
> > > 
> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
> > > ---
> > > Dependencies has now landed, so this provides USB Type-A and Ethernet
> > > support (when renesas_usb_fw.mem) is present.
> > 
> > Note, I initially applied the patch to the bit old -next (20260317) and
> > I ended up with no PCIe host at all (bare -next would still show the
> > PCIe host and the TC9563 bridge).
> > 
> 
> Applied the patch to next-20260323 and tested again.
> 
> > 
> > ANyway, does this actually work for you?
> 
> Yes, I booted with pcie_aspm=off I have functional ethernet and I can
> plug/unplug a USB storage device and access the content on this.
> 
> > The hub is detected, but the USB bus is empty.
> 
> I've disconnected the USB stick again, so here's the output when only
> ethernet is present.
> 
> /:  Bus 001.Port 001: Dev 001, Class=root_hub, Driver=xhci-pci-renesas/4p, 480M
>     |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 480M
> /:  Bus 002.Port 001: Dev 001, Class=root_hub, Driver=xhci-pci-renesas/4p, 5000M
>     |__ Port 001: Dev 002, If 0, Class=Hub, Driver=hub/4p, 5000M
>         |__ Port 001: Dev 003, If 0, Class=Vendor Specific Class, Driver=ax88179_178a, 5000M
> 
> > I tried plugging in several devices (includin the
> > powered USB hub) and they were completely ignored by the hub.
> > 
> 
> The USB stick above was powered by the device, so that part is tested as
> well. (And schematics shows VBUS is always present on the Type-A ports).
> 

This makes me wander, what is wrong with the device of mine. I will run
more checks later. Let's not stall the patch though. In the end, I also
can see the hub registered and working with the driver.


-- 
With best wishes
Dmitry