Re: [PATCH] arm64: dts: qcom: purwa: deduplicate thermal sensors with Hamoa

[Bjorn Andersson <andersson@kernel.org>]

On Wed, Mar 25, 2026 at 01:13:28AM +0200, Dmitry Baryshkov wrote:
> On Tue, Mar 24, 2026 at 10:25:30AM +0100, Konrad Dybcio wrote:
> > On 3/23/26 5:49 PM, Dmitry Baryshkov wrote:
> > > On Mon, Mar 23, 2026 at 04:21:00PM +0100, Konrad Dybcio wrote:
> > >> On 3/20/26 3:33 AM, Dmitry Baryshkov wrote:
> > >>> Hamoa and Purwa have pretty close thermal zones definitions. The major
> > >>> difference is that several zones are absent (because of the lack of the
> > >>> CPU cluster) and several zones use tsens2 instead of tsens3.
> > >>>
> > >>> Instead of completely duplicating thermal zones for Purwa, reuse themal
> > >>> zones from Hamoa, patching them where required.
> > >>>
> > >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > >>> ---
> > >>
> > >> Slightly reluctantly:
> > > 
> > > Why? I'd really interested here.
> > 
> > I suppose my reluctance comes from the decreased readability, but then
> > I suppose the silicon is not going to change if we get it right once, so
> > it's not a real concern..
> 
> I see. My usual concern is opposite: to make sure that we don't need to
> fix another DT if we fix something.
> 

Which means that if you make a change to that "something" you now have
the burden to validate the additional users.

Regards,
Bjorn

> -- 
> With best wishes
> Dmitry