From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org,
Marek Vasut <marek.vasut@mailbox.org>,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: soc: renesas: Document MFIS IP core
Date: Fri, 27 Mar 2026 12:42:08 +0100 [thread overview]
Message-ID: <acZtECu-1kuIuNrx@shikoro> (raw)
In-Reply-To: <20260326-magnetic-cautious-earthworm-aee7ec@quoll>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
Hi Krzysztof,
> > + interrupts:
>
> Missing constraints.
Will add.
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + system-controller@189e0000 {
> > + compatible = "renesas,r8a78000-mfis";
>
> Since I expect next version, one more detail I forgot to ask last time:
>
> Use 4 spaces for example indentation.
Will do.
> > +#define MFIS_CHANNEL_TX (0 << 0)
> > +#define MFIS_CHANNEL_RX (1 << 0)
>
> No improvements and no answers to comments. Same review, drop, not a
> binding. If disagree, respond to v1 comments.
I think I did. I explained above in "changes since v1" that I decided to
keep it because of the existing users in upstream that Geert mentioned.
Also, you have been added to CC to get the driver this time because you
were missing that in v1. So, what exactly is missing?
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-03-27 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 11:07 [PATCH v2 0/3] soc: renesas: add MFIS driver Wolfram Sang
2026-03-25 11:07 ` [PATCH v2 1/3] dt-bindings: soc: renesas: Document MFIS IP core Wolfram Sang
2026-03-26 9:03 ` Krzysztof Kozlowski
2026-03-27 11:42 ` Wolfram Sang [this message]
2026-03-25 11:07 ` [PATCH v2 2/3] soc: renesas: Add Renesas R-Car MFIS driver Wolfram Sang
2026-03-28 0:16 ` Marek Vasut
2026-03-25 11:07 ` [PATCH v2 3/3] soc: renesas: add X5H PRR support Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acZtECu-1kuIuNrx@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut@mailbox.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox