devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Tim Harvey <tharvey@gateworks.com>,
	kernel@dh-electronics.com
Subject: Re: [PATCH] dt-bindings: regulator: lltc,ltc3676: convert to YAML
Date: Thu, 17 Oct 2024 09:01:52 +0200	[thread overview]
Message-ID: <aca453f0-6cf7-4fab-8b0d-ce455affb62b@kernel.org> (raw)
In-Reply-To: <2055a272-8391-4990-bc13-329247e09197@denx.de>

On 17/10/2024 00:48, Marek Vasut wrote:
> 
> I wanted to ask though, there are these patternProperties here which 
> cover sw1..4 and ldo2 and ldo4, and then there is dedicated special case 
> for ldo1 (because this LDO node must always contain regulator-always-on 
> property) and ldo3 (because this LDO node must NOT contain 
> lltc,fb-voltage-divider property). Is there any way to place all the 
> sw1..4 and ldo1..4 into patternProperties, and then selectively DISABLE 
> lltc,fb-voltage-divider requirement for LDO3 and ENABLE 
> regulator-always-on for LDO1 ? I was looking at allOf:if: , but couldn't 
> find anything.

Maybe this would work:
    patternPropeties:
      "^(sw[1-4]|ldo[1-4])$":
         ......
         ......
         allOf:
           - if:
             $nodename:
               const: ldo3
             then:
               ...

but I am not sure if this would be readable and beneficial. Current code
is OK.

Best regards,
Krzysztof


  reply	other threads:[~2024-10-17  7:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 22:42 [PATCH] dt-bindings: regulator: lltc,ltc3676: convert to YAML Marek Vasut
2024-10-16  7:24 ` Krzysztof Kozlowski
2024-10-16 22:48   ` Marek Vasut
2024-10-17  7:01     ` Krzysztof Kozlowski [this message]
2024-10-17 20:50       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aca453f0-6cf7-4fab-8b0d-ce455affb62b@kernel.org \
    --to=krzk@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@dh-electronics.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=marex@denx.de \
    --cc=robh@kernel.org \
    --cc=tharvey@gateworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).