[PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3>

[PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3>

[Uwe Kleine-König]

With the goal to unify all PWM bindings to use #pwm-cells = <3> update
the renesas,rz-mtu3 binding accordingly. Keep <2> documented as a
deprecated value at least until the in-tree device trees are fixed
accordingly.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
 .../devicetree/bindings/timer/renesas,rz-mtu3.yaml         | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml b/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
index 3931054b42fb..3ad10c5b66ba 100644
--- a/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
+++ b/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
@@ -221,7 +221,10 @@ properties:
     maxItems: 1
 
   "#pwm-cells":
-    const: 2
+    oneOf:
+      - const: 2
+        deprecated: true
+      - const: 3
 
 required:
   - compatible
@@ -299,5 +302,5 @@ examples:
       clocks = <&cpg CPG_MOD R9A07G044_MTU_X_MCK_MTU3>;
       power-domains = <&cpg>;
       resets = <&cpg R9A07G044_MTU_X_PRESET_MTU3>;
-      #pwm-cells = <2>;
+      #pwm-cells = <3>;
     };

base-commit: 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
-- 
2.47.2

RE: [PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3>

[Biju Das]

Hi Uwe,

Thanks for the patch.

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Sent: 27 May 2025 21:58
> Subject: [PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3>
> 
> With the goal to unify all PWM bindings to use #pwm-cells = <3> update the renesas,rz-mtu3 binding
> accordingly. Keep <2> documented as a deprecated value at least until the in-tree device trees are
> fixed accordingly.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju

> ---
>  .../devicetree/bindings/timer/renesas,rz-mtu3.yaml         | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
> b/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
> index 3931054b42fb..3ad10c5b66ba 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
> @@ -221,7 +221,10 @@ properties:
>      maxItems: 1
> 
>    "#pwm-cells":
> -    const: 2
> +    oneOf:
> +      - const: 2
> +        deprecated: true
> +      - const: 3
> 
>  required:
>    - compatible
> @@ -299,5 +302,5 @@ examples:
>        clocks = <&cpg CPG_MOD R9A07G044_MTU_X_MCK_MTU3>;
>        power-domains = <&cpg>;
>        resets = <&cpg R9A07G044_MTU_X_PRESET_MTU3>;
> -      #pwm-cells = <2>;
> +      #pwm-cells = <3>;
>      };
> 
> base-commit: 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
> --
> 2.47.2

Re: [PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3>

[Rob Herring (Arm)]

On Tue, 27 May 2025 22:58:22 +0200, Uwe Kleine-König wrote:
> With the goal to unify all PWM bindings to use #pwm-cells = <3> update
> the renesas,rz-mtu3 binding accordingly. Keep <2> documented as a
> deprecated value at least until the in-tree device trees are fixed
> accordingly.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
>  .../devicetree/bindings/timer/renesas,rz-mtu3.yaml         | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3>

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

Hello Daniel,

On Tue, May 27, 2025 at 10:58:22PM +0200, Uwe Kleine-König wrote:
> With the goal to unify all PWM bindings to use #pwm-cells = <3> update
> the renesas,rz-mtu3 binding accordingly. Keep <2> documented as a
> deprecated value at least until the in-tree device trees are fixed
> accordingly.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

I would expect that with the positive feedback by Biju Das and Rob
Herring it's on you to pick up this patch. Or would you prefer that I
take it via PWM?

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3>

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Hello Daniel,

On Mon, Jun 16, 2025 at 03:08:41PM +0200, Uwe Kleine-König wrote:
> On Tue, May 27, 2025 at 10:58:22PM +0200, Uwe Kleine-König wrote:
> > With the goal to unify all PWM bindings to use #pwm-cells = <3> update
> > the renesas,rz-mtu3 binding accordingly. Keep <2> documented as a
> > deprecated value at least until the in-tree device trees are fixed
> > accordingly.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> 
> I would expect that with the positive feedback by Biju Das and Rob
> Herring it's on you to pick up this patch. Or would you prefer that I
> take it via PWM?

I understood your silence as "Please pick that patch up via your PWM
tree" and did that now.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3>

[Daniel Lezcano]

On 31/07/2025 11:41, Uwe Kleine-König wrote:
> Hello Daniel,
> 
> On Mon, Jun 16, 2025 at 03:08:41PM +0200, Uwe Kleine-König wrote:
>> On Tue, May 27, 2025 at 10:58:22PM +0200, Uwe Kleine-König wrote:
>>> With the goal to unify all PWM bindings to use #pwm-cells = <3> update
>>> the renesas,rz-mtu3 binding accordingly. Keep <2> documented as a
>>> deprecated value at least until the in-tree device trees are fixed
>>> accordingly.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
>>
>> I would expect that with the positive feedback by Biju Das and Rob
>> Herring it's on you to pick up this patch. Or would you prefer that I
>> take it via PWM?
> 
> I understood your silence as "Please pick that patch up via your PWM
> tree" and did that now.

Yep, sorry missed it.

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

RE: [PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3>

[Cosmin-Gabriel Tanislav]

> From: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Sent: Tuesday, May 27, 2025 11:58 PM
> 
> With the goal to unify all PWM bindings to use #pwm-cells = <3> update
> the renesas,rz-mtu3 binding accordingly. Keep <2> documented as a
> deprecated value at least until the in-tree device trees are fixed
> accordingly.
> 

Hello Uwe, Rob, Krzysztof.

Sorry for replying to an old patch, but the context is relevant to my
question.

I'm working on adding MTU3 support for a new platform, Renesas RZ/T2H.

From this patch, it is clear that new platforms should use
#pwm-cells = <3>; as <2> is deprecated.

What I would like to clarify is whether existing platforms are also
expected to be migrated from #pwm-cells = <2> to #pwm-cells = <3>.

My understanding is that changing the provider to #pwm-cells = <3> would
break existing consumers that still specify only two cells in their PWM
specifiers, since those references would then fail the checks inside
of_phandle_iterator_next().

There are no existing consumers in-tree, but there might be out-of-tree
ones that depend on #pwm-cells = <2>;.

If we're okay with the ABI breakage I can proceed with the changes for
existing platforms too.

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
>  .../devicetree/bindings/timer/renesas,rz-mtu3.yaml         | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
> b/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
> index 3931054b42fb..3ad10c5b66ba 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
> @@ -221,7 +221,10 @@ properties:
>      maxItems: 1
> 
>    "#pwm-cells":
> -    const: 2
> +    oneOf:
> +      - const: 2
> +        deprecated: true
> +      - const: 3
> 
>  required:
>    - compatible
> @@ -299,5 +302,5 @@ examples:
>        clocks = <&cpg CPG_MOD R9A07G044_MTU_X_MCK_MTU3>;
>        power-domains = <&cpg>;
>        resets = <&cpg R9A07G044_MTU_X_PRESET_MTU3>;
> -      #pwm-cells = <2>;
> +      #pwm-cells = <3>;
>      };
> 
> base-commit: 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
> --
> 2.47.2
> 

Re: [PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3>

[u.kleine-koenig]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

Hello,

On Wed, Mar 25, 2026 at 01:24:40PM +0000, Cosmin-Gabriel Tanislav wrote:
> Sorry for replying to an old patch, but the context is relevant to my
> question.
> 
> I'm working on adding MTU3 support for a new platform, Renesas RZ/T2H.
> 
> From this patch, it is clear that new platforms should use
> #pwm-cells = <3>; as <2> is deprecated.
> 
> What I would like to clarify is whether existing platforms are also
> expected to be migrated from #pwm-cells = <2> to #pwm-cells = <3>.
> 
> My understanding is that changing the provider to #pwm-cells = <3> would
> break existing consumers that still specify only two cells in their PWM
> specifiers, since those references would then fail the checks inside
> of_phandle_iterator_next().

The conversion doesn't break dtbs, because in a single dtb consumer and
PWM device are consistent. So from my POV updating is fine.

> There are no existing consumers in-tree, but there might be out-of-tree
> ones that depend on #pwm-cells = <2>;.

That might happen for out-of-tree dts files that include the SoC's
.dtsi. IMHO it's ok to break these.

> If we're okay with the ABI breakage I can proceed with the changes for
> existing platforms too.

The reason that made me stop continuing the conversion myself is the
somewhat stuck discussion at
https://patchwork.ozlabs.org/project/linux-pwm/patch/crk42dsypmbyqk7avldghjq32vslmalfmmouwxzgtdci4agfhz@rkbmxj5z22fx/
.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]