From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="Sfw7Xb7l" Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E4B0126 for ; Sat, 9 Dec 2023 16:08:38 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1702166916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F4h651fYGXTf5wTx9MX0AlOhkuDhIxXL3dZrzDHtCKI=; b=Sfw7Xb7l2DgJE7PMC2rvLxmD+08/g83VFwuT3PlUQ9A3X79y46B6cCrByIwQd4D+ibEMO1 38ejZZ4tnfdkCV2bjj+Lb9f4moU/c0qz8Ml6krP+Y8DlcxQhEb4YLvdEzTbMqHFtH+b++r RkLN6BtF4M8c7opNcDqBRQyDFS/VLVdckH2nJ1fEXrF6KZ+vD8f3HIO0yOKMDMfmZgLpwy gM52Ui3MOJde1qtVQsc7DKg8x9QR9o4i5Meo+qsEtcHiPjimdR6SjE0OrKL+5+S6eOWxc6 qoC4AfSGvLZIwlKQPc74199zBNsScpUis74eR7DCeN+v47CX/kWXFzz+yPqwWA== Date: Sun, 10 Dec 2023 01:08:36 +0100 From: Dragan Simic To: Shantur Rathore Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v1] dts: rockpro64: Remove usb regulator-always-on In-Reply-To: References: <20231209232109.348999-1-i@shantur.com> <20231209233536.350876-1-i@shantur.com> <43339adb6f98a0b4e59db78f932df0d4@manjaro.org> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org On 2023-12-10 01:03, Shantur Rathore wrote: > On Sat, Dec 9, 2023 at 11:43 PM Dragan Simic > wrote: >> On 2023-12-10 00:35, Shantur Rathore wrote: >> > USB port regulators should be controlled by PHYs >> > so we remove always-on property and let PHYs manage the >> > regulator. >> > >> > Typec port has misconfugred phy-supply and now that we are >> > removing regulator-always-on, we need to fix the phy-supply >> > so the PHYs are able to turn power to type-c port. >> > >> > Signed-off-by: Shantur Rathore >> > --- >> > + devicetree >> > >> > After this patch the ports were confirmed to power up and down >> > in u-boot when doing usb start and usb stop. >> > At boot the regulators were off, the devices connected weren't >> > powered up, on usb start the PHYs are able to power on the ports >> > and on usb stop they were powered down. >> > >> > At the boot, the ports were powered down which was again powered >> > up by Linux kernel when booting up. >> > >> > >> > arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 4 +--- >> > 1 file changed, 1 insertion(+), 3 deletions(-) >> > >> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi >> > b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi >> > index bca2b50e0a..bd2824aa48 100644 >> > --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi >> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi >> > @@ -192,7 +192,6 @@ vcc5v0_host: vcc5v0-host-regulator { >> > pinctrl-names = "default"; >> > pinctrl-0 = <&vcc5v0_host_en>; >> > regulator-name = "vcc5v0_host"; >> > - regulator-always-on; >> > vin-supply = <&vcc5v0_usb>; >> > }; >> > >> > @@ -203,7 +202,6 @@ vcc5v0_typec: vcc5v0-typec-regulator { >> > pinctrl-names = "default"; >> > pinctrl-0 = <&vcc5v0_typec_en>; >> > regulator-name = "vcc5v0_typec"; >> > - regulator-always-on; >> > vin-supply = <&vcc5v0_usb>; >> > }; >> > >> > @@ -863,7 +861,7 @@ u2phy0_otg: otg-port { >> > }; >> > >> > u2phy0_host: host-port { >> > - phy-supply = <&vcc5v0_host>; >> > + phy-supply = <&vcc5v0_typec>; >> > status = "okay"; >> > }; >> > }; >> >> Quite frankly, something doesn't feel right there. Would you mind, >> please, to place this patch on hold until next week or so, at which >> point I should have enough time to go through the RockPro64 schematic >> thoroughly once again, and test the patch in detail? > > Sure, no worries. Great, thanks. > Would you mind letting me know which part doesn't feel right to you? Sure, it was about the last change in the patch.