From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C333C4332F for ; Fri, 16 Dec 2022 19:49:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231324AbiLPTtN (ORCPT ); Fri, 16 Dec 2022 14:49:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbiLPTtL (ORCPT ); Fri, 16 Dec 2022 14:49:11 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE1DC26494 for ; Fri, 16 Dec 2022 11:49:09 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id b9so3251220ljr.5 for ; Fri, 16 Dec 2022 11:49:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6z9OvKI51ihySsgu93liVf6+X1We62nP+OEGmpfLqbY=; b=fqe6OZr4BK1cJGFNLwq7ZfnbVfw7pE1NnMU/JaCOq6aNEAhaKopG1a5VaBHBUAaZKQ TLf4y1u9f6yQjYM18vKbj15CKtWeuLFbKm4+FJoypzbQweGHY+Q3OvJdqxhwUEcNwn8X I3sCSqMekAImG75HER1U8aFaO1+KFS08Ilr4TKwq79ef6ZcSTIJzfXWYhCGYGHHEMF57 p+SZ078o5fL56L6Pue6cgyeu2R0tnIPOlHYNbGn65YaT5rEzdVAKFPloKbveTBdjQeNK 5BRRoiJB11+DwiUjFZK1t9nIHyV6TqLmgm/6cf5xjqn4mHYeIvH8Kw74KdH23Ws8ay71 +6fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6z9OvKI51ihySsgu93liVf6+X1We62nP+OEGmpfLqbY=; b=RoaoEd5HbzTnxN3celvVir5N1CdEyTxcW8hqNF4UBdhxzX/ocDwcCBZLI62lS+4N9D +zVICx9b8E42nmKsZFMewtA/nN9FEEat5WOMe/aM9l0ut5W5dW4sL2j4/nC6RNxO55qn QyObpKZQ70r+nRg920P9YT52d/V68qkkdBg7b/h7HAh21dhsFvPfovU6l47S27TIN7Ll 4Hec1yf5nv9VutLSraTsTX2sEc+8fsbFDN1vFNU1trNEukF42QR0NPe5IAhm6db8UpW7 4ynQIAnRRhGeinmDccr2cC8vTpXp6SADwTtiJuXBNromEgorbsRUhwyj4Qbn8Y5vi6BT 18Jw== X-Gm-Message-State: ANoB5pmUfnIEdlL24lrqnqCc8sUGnyr9fVo5K10dT33JdMW+imHxWEXa xt3Vz20mj2fpixqqPrClzS7PFw== X-Google-Smtp-Source: AA0mqf43nHEgnTKkJx8PkGAY9Wz0D+UjxFUfVyEoYTgUfRFTw+weO1PR9gXva6El7Qb+jnUwh8hm5A== X-Received: by 2002:a05:651c:1144:b0:277:1888:cfb3 with SMTP id h4-20020a05651c114400b002771888cfb3mr8207285ljo.16.1671220148357; Fri, 16 Dec 2022 11:49:08 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id p5-20020a2eb985000000b0027a00aab48fsm220337ljp.66.2022.12.16.11.49.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 11:49:07 -0800 (PST) Message-ID: Date: Fri, 16 Dec 2022 21:49:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v14 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property Content-Language: en-GB To: Kuogee Hsieh , dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, dianders@chromium.org, vkoul@kernel.org, daniel@ffwll.ch, agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, airlied@gmail.com Cc: quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1671217893-17496-1-git-send-email-quic_khsieh@quicinc.com> <1671217893-17496-3-git-send-email-quic_khsieh@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <1671217893-17496-3-git-send-email-quic_khsieh@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/12/2022 21:11, Kuogee Hsieh wrote: > To increase the flexibility of supporting different DP main link configuration > at different platform, add both data-lanes and link-frequencies property > into endpoint so that different platform can specify its own main link > combination of both data lanes and max supported link rate. > > Changes in v7: > -- split yaml out of dtsi patch > -- link-frequencies from link rate to symbol rate > -- deprecation of old data-lanes property > > Changes in v8: > -- correct Bjorn mail address to kernel.org > > Changes in v10: > -- add menu item to data-lanes and link-frequecnis > > Changes in v11: > -- add endpoint property at port@1 > > Changes in v12: > -- use enum for item at data-lanes and link-frequencies > > Changes in v13: > -- revised changes at port@0 > -- use correct ref schemas for both port@0 and port@1 > -- mark both port@0 and port@1 are required > -- add line between data-lanes and link-frequencies properties > > Changes in v14: > -- add "unevaluatedProperties: false: to endpoint at port@1 > -- remove unnecessary quote to $ref > -- re store "$ref: /schemas/graph.yaml#/properties/port" to port@0 > > Signed-off-by: Kuogee Hsieh > --- > .../bindings/display/msm/dp-controller.yaml | 26 ++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index f2515af..1f008ca 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -81,6 +81,7 @@ properties: > > data-lanes: > $ref: /schemas/types.yaml#/definitions/uint32-array > + deprecated: true > minItems: 1 > maxItems: 4 > items: > @@ -99,11 +100,30 @@ properties: > properties: > port@0: > $ref: /schemas/graph.yaml#/properties/port > - description: Input endpoint of the controller Why? > > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/$defs/port-base > description: Output endpoint of the controller > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 4 > + items: > + enum: [ 0, 1, 2, 3 ] > + > + link-frequencies: > + minItems: 1 > + maxItems: 4 > + items: > + enum: [ 1620000000, 2700000000, 5400000000, 8100000000 ] > + > + required: > + - port@0 > + - port@1 > > required: > - compatible > @@ -193,6 +213,8 @@ examples: > reg = <1>; > endpoint { > remote-endpoint = <&typec>; > + data-lanes = <0 1>; > + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>; Is the alignment correct in the patch above? It might be my client not displaying the patch correctly, but it doesn't look correct. > }; > }; > }; -- With best wishes Dmitry