From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Francesco Dolcini <francesco.dolcini@toradex.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Marco Felsch <m.felsch@pengutronix.de>,
Anson Huang <Anson.Huang@nxp.com>
Cc: Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 0/9] imx: thermal: Allow trip point configuration from DT
Date: Fri, 17 Jun 2022 17:45:26 -0700 [thread overview]
Message-ID: <acbf8ed3-0b8c-a0b2-88ef-7b13ad0908d5@linaro.org> (raw)
In-Reply-To: <20220617070847.186876-1-francesco.dolcini@toradex.com>
On 17/06/2022 00:08, Francesco Dolcini wrote:
> This series allows to specify the imx thermal drivers trip point from the device tree,
> without this change the threshold are hard-coded and this might not be correct given the
> thermal design of the final system.
>
> This change is backward compatible with the existing device tree, and even
> with this change in by default the thresholds are the same as before.
>
> Toradex board are also updated to use a system-specific thresholds.
>
> Discussion on the current design is here:
> https://lore.kernel.org/all/4ba1d7d2-3e8c-ba60-37fd-9598f415c076@linaro.org/
>
> One side note, after this change the dtbs checker starts complaining with this message
>
> ```
> linux/arch/arm/boot/dts/imx6dl-alti6p.dtb: tempmon: '#thermal-sensor-cells' does not match any of the regexes: '^(automotive|commercial|extended-commercial|industrial)-thermal$', 'pinctrl-[0-9]+'
> From schema: linux/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
> ```
>
> to my understanding this is just a side effect,
If it starts complaining, it does not look like a side effect but error
needing to be fixed/addressed.
> '#thermal-sensor-cells' is not changed in
> any way by this series. I can fix that, I wonder if I should remove the property from the
> imx dtsi files or add it to the binding yaml definition, not sure about it.
> Anybody can advise?
Depends. Is the device a thermal-sensor provider?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-18 0:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 7:08 [PATCH v1 0/9] imx: thermal: Allow trip point configuration from DT Francesco Dolcini
2022-06-17 7:08 ` [PATCH v2 1/9] dt-bindings: thermal: Define trips node in $defs Francesco Dolcini
2022-06-18 1:02 ` Krzysztof Kozlowski
2022-06-20 15:48 ` Francesco Dolcini
2022-06-20 16:44 ` Krzysztof Kozlowski
2022-06-20 17:43 ` Francesco Dolcini
2022-06-20 18:05 ` Krzysztof Kozlowski
2022-06-20 18:19 ` Francesco Dolcini
2022-06-20 16:45 ` Krzysztof Kozlowski
2022-06-20 17:46 ` Francesco Dolcini
2022-06-17 7:08 ` [PATCH v2 2/9] thermal: thermal: Export OF trip helper function Francesco Dolcini
2022-06-17 7:08 ` [PATCH v2 3/9] dt-bindings: thermal: imx: Add trips point Francesco Dolcini
2022-06-17 7:08 ` [PATCH v2 4/9] imx: thermal: Configure trip point from DT Francesco Dolcini
2022-06-17 7:08 ` [PATCH v2 5/9] ARM: dts: imx[67]: Add trips points Francesco Dolcini
2022-06-17 7:08 ` [PATCH v2 6/9] ARM: dts: imx6qdl-apalis: Set CPU critical trip point Francesco Dolcini
2022-06-17 7:08 ` [PATCH v2 7/9] ARM: dts: imx7-colibri: " Francesco Dolcini
2022-06-17 7:08 ` [PATCH v2 8/9] ARM: dts: imx6ull-colibri: " Francesco Dolcini
2022-06-17 7:08 ` [PATCH v2 9/9] ARM: dts: imx6qdl-colibri: " Francesco Dolcini
2022-06-18 0:45 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-15 9:47 [PATCH v1 0/9] imx: thermal: Allow trip point configuration from DT Francesco Dolcini
2022-06-15 10:42 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acbf8ed3-0b8c-a0b2-88ef-7b13ad0908d5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Anson.Huang@nxp.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).