From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF72C43334 for ; Sat, 18 Jun 2022 00:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383489AbiFRApb (ORCPT ); Fri, 17 Jun 2022 20:45:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234931AbiFRApb (ORCPT ); Fri, 17 Jun 2022 20:45:31 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E95B633BA for ; Fri, 17 Jun 2022 17:45:30 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id 184so5324780pga.12 for ; Fri, 17 Jun 2022 17:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=4UBTCxi8NJwu+bWr0wJOqTsx4bcIPj3/b5hz4TC0hQY=; b=eyJ6ww4XQJY6GkTvPtAS8EmgxidGB0tDgomc5hdevWn1R+oGEvtskMEDqeTnlWqIp6 CdDsoZFGFBOlufromgEEF/gGuhNUqyw3Q/SzoGeLHkw56rC29zUWqSoHAcKt5MUH/ls1 4VkGt4/kVd+TblxGi4cXck63elJZO4XQwq9h3znyNVdZ8bOncRfYZ2Pe5KeBX2l0yCLu QyKdV54XyFEdF+XgtA+sX2e9YpfDbym1N9nVKLqw7dAYQk8Hxyw9ysJeEbeofRuI+rNv /JBFdnwenTZC0E5UQwJQR0KyHVjHCWdF3x95DPp+C/te4IEvJqQ83sqSdiecWmcek716 CN6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4UBTCxi8NJwu+bWr0wJOqTsx4bcIPj3/b5hz4TC0hQY=; b=roYdeV5USDymHi8y5I5zGSaizM9Lz1vc7VRwO6qauhVa7bweJw49Q6l0zDfA0KUqkH GQ9xINIcvUSkUVHnuXv6o0vDDnfTVeksHBPTA0jyhEizhjmwyOk3h03slE59dDIGFX3P 8KQ7Kyppso1IfZt2hIr5m4AreY1++Xty3UkLBVFl6kE39Mm1/Bdwaz2HN8dm3biN2EyQ AAW74rkqFcvQALS3mjItZrPuIHTWfLOcJ+0CBh9s8cvi6O2JTXqyJs4TO3u1k1xxlpmK VD/nHC0yv5T6qjbVxeTMi6MeKa+BLlocxcO0e8muXgkA+ZTThP/BCrm4zoQy2Vyw9/nV krTw== X-Gm-Message-State: AJIora8LGabwF62tGgqPjx4TBRKkW+2MkdYMUy2ckp3/T1EF9BzTZb74 QkVbp+aF4osJu8zo7D6WNeu8jg== X-Google-Smtp-Source: AGRyM1vPx7U/RB9e0wVTMwzZu9KuNOtp08j+FdGRa9g4rHhb/XAEnR0mYoannyMnwN4UEuV+Ua7ttg== X-Received: by 2002:a05:6a00:1a8f:b0:51c:2f82:cdba with SMTP id e15-20020a056a001a8f00b0051c2f82cdbamr12876825pfv.85.1655513129981; Fri, 17 Jun 2022 17:45:29 -0700 (PDT) Received: from [172.31.235.92] ([216.9.110.6]) by smtp.gmail.com with ESMTPSA id p4-20020a170902780400b0016760c06b76sm4080548pll.194.2022.06.17.17.45.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jun 2022 17:45:29 -0700 (PDT) Message-ID: Date: Fri, 17 Jun 2022 17:45:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v1 0/9] imx: thermal: Allow trip point configuration from DT Content-Language: en-US To: Francesco Dolcini , Daniel Lezcano , Rob Herring , "Rafael J. Wysocki" , Krzysztof Kozlowski , Shawn Guo , Marco Felsch , Anson Huang Cc: Amit Kucheria , Zhang Rui , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Pengutronix Kernel Team , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org References: <20220617070847.186876-1-francesco.dolcini@toradex.com> From: Krzysztof Kozlowski In-Reply-To: <20220617070847.186876-1-francesco.dolcini@toradex.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/06/2022 00:08, Francesco Dolcini wrote: > This series allows to specify the imx thermal drivers trip point from the device tree, > without this change the threshold are hard-coded and this might not be correct given the > thermal design of the final system. > > This change is backward compatible with the existing device tree, and even > with this change in by default the thresholds are the same as before. > > Toradex board are also updated to use a system-specific thresholds. > > Discussion on the current design is here: > https://lore.kernel.org/all/4ba1d7d2-3e8c-ba60-37fd-9598f415c076@linaro.org/ > > One side note, after this change the dtbs checker starts complaining with this message > > ``` > linux/arch/arm/boot/dts/imx6dl-alti6p.dtb: tempmon: '#thermal-sensor-cells' does not match any of the regexes: '^(automotive|commercial|extended-commercial|industrial)-thermal$', 'pinctrl-[0-9]+' > From schema: linux/Documentation/devicetree/bindings/thermal/imx-thermal.yaml > ``` > > to my understanding this is just a side effect, If it starts complaining, it does not look like a side effect but error needing to be fixed/addressed. > '#thermal-sensor-cells' is not changed in > any way by this series. I can fix that, I wonder if I should remove the property from the > imx dtsi files or add it to the binding yaml definition, not sure about it. > Anybody can advise? Depends. Is the device a thermal-sensor provider? Best regards, Krzysztof