Re: [PATCH v3 2/2] soc: mediatek: svs: add support for mt8188

["Chun-Jen Tseng (曾俊仁)" <Chun-Jen.Tseng@mediatek.com>]

On Tue, 2023-09-19 at 12:52 +0200, AngeloGioacchino Del Regno wrote:
> Il 19/09/23 03:44, Mark Tseng ha scritto:
> > MT8188 svs gpu uses 2-line high bank and low bank to optimize the
> > voltage of opp table for higher and lower frequency respectively.
> > 
> > Signed-off-by: Mark Tseng <chun-jen.tseng@mediatek.com>
> > ---
> >   drivers/soc/mediatek/mtk-svs.c | 184
> > ++++++++++++++++++++++++++++++++-
> >   1 file changed, 180 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/soc/mediatek/mtk-svs.c
> > b/drivers/soc/mediatek/mtk-svs.c
> > index 3a2f97cd5272..f31e3bedff50 100644
> > --- a/drivers/soc/mediatek/mtk-svs.c
> > +++ b/drivers/soc/mediatek/mtk-svs.c
> > @@ -407,6 +407,7 @@ struct svs_platform_data {
> >    * @dcbdet: svs efuse data
> >    * @dcmdet: svs efuse data
> >    * @turn_pt: 2-line turn point tells which opp_volt calculated by
> > high/low bank
> > + * @vbin_turn_pt: voltage bin turn point helps know which
> > svsb_volt should be overridden
> >    * @type: bank type to represent it is 2-line (high/low) bank or
> > 1-line bank
> >    *
> >    * Svs bank will generate suitalbe voltages by below general math
> > equation
> > @@ -469,6 +470,7 @@ struct svs_bank {
> >   	u32 dcbdet;
> >   	u32 dcmdet;
> >   	u32 turn_pt;
> > +	u32 vbin_turn_pt;
> >   	u32 type;
> >   };
> >   
> > @@ -751,11 +753,12 @@ static int svs_status_debug_show(struct
> > seq_file *m, void *v)
> >   
> >   	ret = thermal_zone_get_temp(svsb->tzd, &tzone_temp);
> >   	if (ret)
> > -		seq_printf(m, "%s: temperature ignore, turn_pt = %u\n",
> > -			   svsb->name, svsb->turn_pt);
> > +		seq_printf(m, "%s: temperature ignore, vbin_turn_pt =
> > %u, turn_pt = %u\n",
> > +			   svsb->name, svsb->vbin_turn_pt, svsb-
> > >turn_pt);
> >   	else
> > -		seq_printf(m, "%s: temperature = %d, turn_pt = %u\n",
> > -			   svsb->name, tzone_temp, svsb->turn_pt);
> > +		seq_printf(m, "%s: temperature = %d, vbin_turn_pt = %u,
> > turn_pt = %u\n",
> > +			   svsb->name, tzone_temp, svsb->vbin_turn_pt,
> > +			   svsb->turn_pt);
> >   
> >   	for (i = 0; i < svsb->opp_count; i++) {
> >   		opp = dev_pm_opp_find_freq_exact(svsb->opp_dev,
> > @@ -952,6 +955,29 @@ static void svs_get_bank_volts_v3(struct
> > svs_platform *svsp)
> >   	for (i = opp_start; i < opp_stop; i++)
> >   		if (svsb->volt_flags & SVSB_REMOVE_DVTFIXED_VOLT)
> >   			svsb->volt[i] -= svsb->dvt_fixed;
> > +
> > +	/* For voltage bin support */
> 
> I already asked you to please send the voltage bin support as a
> separated commit
> because this is for *all SoCs* and not only for 8188.
> 
> Again, please separate the voltage bin support from the MT8188
> support.
> 
Hi Angelo,

I have already checked "voltage bins turn point" with DE, it is support
for *all SoCs* , not only for MT8188.


> soc: mediatek: svs: Add support for voltage bins
> soc: mediatek: svs: Add support for MT8188 SoC
> 
> Regards,
> Angelo
>