From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Wang Chen <unicornxw@gmail.com>,
linux-riscv@lists.infradead.org, conor@kernel.org,
aou@eecs.berkeley.edu, krzysztof.kozlowski+dt@linaro.org,
palmer@dabbelt.com, paul.walmsley@sifive.com, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jszhang@kernel.org, guoren@kernel.org, chao.wei@sophgo.com,
xiaoguang.xing@sophgo.com, Wang Chen <wangchen20@iscas.ac.cn>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>
Subject: Re: [PATCH 11/12] riscv: dts: sophgo: Add sophgo,sg2024-uart compatibles
Date: Fri, 15 Sep 2023 09:32:08 +0200 [thread overview]
Message-ID: <acd83ee9-951d-928c-eb9f-e3295ae7ad55@linaro.org> (raw)
In-Reply-To: <20230915072624.118388-1-wangchen20@iscas.ac.cn>
On 15/09/2023 09:26, Wang Chen wrote:
> Add compatible for uart.
>
> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> Signed-off-by: Wang Chen <wangchen20@iscas.ac.cn>
> ---
> arch/riscv/boot/dts/sophgo/sg2042.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> index 5c4b82f13207..87f7667bbe63 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> @@ -492,7 +492,7 @@ &cpu63_intc 0xffffffff &cpu63_intc 9
> };
>
> uart0: serial@7040000000 {
> - compatible = "snps,dw-apb-uart";
> + compatible = "sophgo,sg2042-uart", "snps,dw-apb-uart";
No, you just added this file. Do not add buggy code which is fixed in
next patch.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-09-15 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 7:26 [PATCH 11/12] riscv: dts: sophgo: Add sophgo,sg2024-uart compatibles Wang Chen
2023-09-15 7:32 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acd83ee9-951d-928c-eb9f-e3295ae7ad55@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=unicornxw@gmail.com \
--cc=wangchen20@iscas.ac.cn \
--cc=xiaoguang.xing@sophgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).