Re: [PATCH v7 0/7] PCI: qcom: Fix higher MSI vectors handling

[Stanimir Varbanov <svarbanov@mm-sol.com>]

Thanks Dmitry!

On 5/5/22 16:54, Dmitry Baryshkov wrote:
> I have replied with my Tested-by to the patch at [2], which has landed
> in the linux-next as the commit 20f1bfb8dd62 ("PCI: qcom:
> Add support for handling MSIs from 8 endpoints"). However lately I
> noticed that during the tests I still had 'pcie_pme=nomsi', so the
> device was not forced to use higher MSI vectors.
> 
> After removing this option I noticed that hight MSI vectors are not
> delivered on tested platforms. After additional research I stumbled upon
> a patch in msm-4.14 ([1]), which describes that each group of MSI
> vectors is mapped to the separate interrupt. Implement corresponding
> mapping.
> 
> Since we can not expect that other platforms will use multi-IRQ scheme
> for MSI mapping (e.g. iMX and Tegra map all 256 MSI interrupts to single
> IRQ), it's support is implemented directly in pcie-qcom rather than in
> the core driver.
> 
> The first patch in the series is a revert of  [2] (landed in pci-next).
> Either both patches should be applied or both should be dropped.
> 
> Patchseries dependecies: [3] (for the schema change).
> 
> Changes since v6:
>  - Fix indentation of the arguments as requested by Stanimir

<cut>

> 
> Dmitry Baryshkov (7):
>   PCI: qcom: Revert "PCI: qcom: Add support for handling MSIs from 8
>     endpoints"
>   PCI: dwc: Correct msi_irq condition in dw_pcie_free_msi()
>   PCI: dwc: Add msi_host_deinit callback
>   PCI: dwc: Export several functions useful for MSI implentations
>   PCI: qcom: Handle MSIs routed to multiple GIC interrupts
>   dt-bindings: PCI: qcom: Support additional MSI interrupts
>   arm64: dts: qcom: sm8250: provide additional MSI interrupts

For PCI qcom driver:

Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>

> 
>  .../devicetree/bindings/pci/qcom,pcie.yaml    |  45 +++++-
>  arch/arm64/boot/dts/qcom/sm8250.dtsi          |  11 +-
>  .../pci/controller/dwc/pcie-designware-host.c |  72 +++++----
>  drivers/pci/controller/dwc/pcie-designware.h  |  12 ++
>  drivers/pci/controller/dwc/pcie-qcom.c        | 138 +++++++++++++++++-
>  5 files changed, 246 insertions(+), 32 deletions(-)
> 

-- 
regards,
Stan