* [PATCH 1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers
@ 2024-06-27 12:20 Krzysztof Kozlowski
2024-06-27 12:20 ` [PATCH 2/3] arm64: dts: qcom: sm8550-mtp: " Krzysztof Kozlowski
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-27 12:20 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Add appropriate mappings of Soundwire ports of WSA8845 speaker. This
solves second (south) speaker sound distortions when playing audio.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Bindings:
https://lore.kernel.org/all/20240626-port-map-v1-3-bd8987d2b332@linaro.org/
Can be applied independently, if bindings are fine.
---
arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
index e0dc03a97771..2e12219006c9 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
@@ -1106,6 +1106,7 @@ north_spkr: speaker@0,0 {
#sound-dai-cells = <0>;
sound-name-prefix = "SpkrLeft";
+ qcom,port-mapping = <1 2 3 7 10 13>;
};
/* WSA8845, Speaker South */
@@ -1123,6 +1124,7 @@ south_spkr: speaker@0,1 {
#sound-dai-cells = <0>;
sound-name-prefix = "SpkrRight";
+ qcom,port-mapping = <4 5 6 7 11 13>;
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] arm64: dts: qcom: sm8550-mtp: add port mapping to speakers
2024-06-27 12:20 [PATCH 1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers Krzysztof Kozlowski
@ 2024-06-27 12:20 ` Krzysztof Kozlowski
2024-06-27 12:33 ` neil.armstrong
2024-06-27 12:20 ` [PATCH 3/3] arm64: dts: qcom: sm8550-qrd: " Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-27 12:20 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Add appropriate mappings of Soundwire ports of WSA8845 speaker. This
solves second (right) speaker sound distortions when playing audio.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Bindings:
https://lore.kernel.org/all/20240626-port-map-v1-3-bd8987d2b332@linaro.org/
Can be applied independently, if bindings are fine.
---
arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
index 26dfca0c3e05..ab447fc252f7 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
@@ -842,6 +842,7 @@ left_spkr: speaker@0,0 {
sound-name-prefix = "SpkrLeft";
vdd-1p8-supply = <&vreg_l15b_1p8>;
vdd-io-supply = <&vreg_l3g_1p2>;
+ qcom,port-mapping = <1 2 3 7 10 13>;
};
/* WSA8845 */
@@ -855,6 +856,7 @@ right_spkr: speaker@0,1 {
sound-name-prefix = "SpkrRight";
vdd-1p8-supply = <&vreg_l15b_1p8>;
vdd-io-supply = <&vreg_l3g_1p2>;
+ qcom,port-mapping = <4 5 6 7 11 13>;
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: sm8550-qrd: add port mapping to speakers
2024-06-27 12:20 [PATCH 1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers Krzysztof Kozlowski
2024-06-27 12:20 ` [PATCH 2/3] arm64: dts: qcom: sm8550-mtp: " Krzysztof Kozlowski
@ 2024-06-27 12:20 ` Krzysztof Kozlowski
2024-06-27 12:32 ` neil.armstrong
2024-06-27 12:33 ` [PATCH 1/3] arm64: dts: qcom: sm8550-hdk: " neil.armstrong
2024-07-03 3:37 ` (subset) " Bjorn Andersson
3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-27 12:20 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Add appropriate mappings of Soundwire ports of WSA8845 speaker. This
solves second (south) speaker sound distortions when playing audio.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Bindings:
https://lore.kernel.org/all/20240626-port-map-v1-3-bd8987d2b332@linaro.org/
Can be applied independently, if bindings are fine.
---
arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
index d27820fb5fc0..de40cb623c8c 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
@@ -935,6 +935,7 @@ north_spkr: speaker@0,0 {
sound-name-prefix = "SpkrLeft";
vdd-1p8-supply = <&vreg_l15b_1p8>;
vdd-io-supply = <&vreg_l3g_1p2>;
+ qcom,port-mapping = <1 2 3 7 10 13>;
};
/* WSA8845, Speaker South */
@@ -948,6 +949,7 @@ south_spkr: speaker@0,1 {
sound-name-prefix = "SpkrRight";
vdd-1p8-supply = <&vreg_l15b_1p8>;
vdd-io-supply = <&vreg_l3g_1p2>;
+ qcom,port-mapping = <4 5 6 7 11 13>;
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: sm8550-qrd: add port mapping to speakers
2024-06-27 12:20 ` [PATCH 3/3] arm64: dts: qcom: sm8550-qrd: " Krzysztof Kozlowski
@ 2024-06-27 12:32 ` neil.armstrong
0 siblings, 0 replies; 7+ messages in thread
From: neil.armstrong @ 2024-06-27 12:32 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 27/06/2024 14:20, Krzysztof Kozlowski wrote:
> Add appropriate mappings of Soundwire ports of WSA8845 speaker. This
> solves second (south) speaker sound distortions when playing audio.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Bindings:
> https://lore.kernel.org/all/20240626-port-map-v1-3-bd8987d2b332@linaro.org/
>
> Can be applied independently, if bindings are fine.
> ---
> arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> index d27820fb5fc0..de40cb623c8c 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> @@ -935,6 +935,7 @@ north_spkr: speaker@0,0 {
> sound-name-prefix = "SpkrLeft";
> vdd-1p8-supply = <&vreg_l15b_1p8>;
> vdd-io-supply = <&vreg_l3g_1p2>;
> + qcom,port-mapping = <1 2 3 7 10 13>;
> };
>
> /* WSA8845, Speaker South */
> @@ -948,6 +949,7 @@ south_spkr: speaker@0,1 {
> sound-name-prefix = "SpkrRight";
> vdd-1p8-supply = <&vreg_l15b_1p8>;
> vdd-io-supply = <&vreg_l3g_1p2>;
> + qcom,port-mapping = <4 5 6 7 11 13>;
> };
> };
>
At some point I got the exact same change, but I guess I was missing the WSA macro register
shift so this did nothing...
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: sm8550-mtp: add port mapping to speakers
2024-06-27 12:20 ` [PATCH 2/3] arm64: dts: qcom: sm8550-mtp: " Krzysztof Kozlowski
@ 2024-06-27 12:33 ` neil.armstrong
0 siblings, 0 replies; 7+ messages in thread
From: neil.armstrong @ 2024-06-27 12:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 27/06/2024 14:20, Krzysztof Kozlowski wrote:
> Add appropriate mappings of Soundwire ports of WSA8845 speaker. This
> solves second (right) speaker sound distortions when playing audio.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Bindings:
> https://lore.kernel.org/all/20240626-port-map-v1-3-bd8987d2b332@linaro.org/
>
> Can be applied independently, if bindings are fine.
> ---
> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> index 26dfca0c3e05..ab447fc252f7 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> @@ -842,6 +842,7 @@ left_spkr: speaker@0,0 {
> sound-name-prefix = "SpkrLeft";
> vdd-1p8-supply = <&vreg_l15b_1p8>;
> vdd-io-supply = <&vreg_l3g_1p2>;
> + qcom,port-mapping = <1 2 3 7 10 13>;
> };
>
> /* WSA8845 */
> @@ -855,6 +856,7 @@ right_spkr: speaker@0,1 {
> sound-name-prefix = "SpkrRight";
> vdd-1p8-supply = <&vreg_l15b_1p8>;
> vdd-io-supply = <&vreg_l3g_1p2>;
> + qcom,port-mapping = <4 5 6 7 11 13>;
> };
> };
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers
2024-06-27 12:20 [PATCH 1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers Krzysztof Kozlowski
2024-06-27 12:20 ` [PATCH 2/3] arm64: dts: qcom: sm8550-mtp: " Krzysztof Kozlowski
2024-06-27 12:20 ` [PATCH 3/3] arm64: dts: qcom: sm8550-qrd: " Krzysztof Kozlowski
@ 2024-06-27 12:33 ` neil.armstrong
2024-07-03 3:37 ` (subset) " Bjorn Andersson
3 siblings, 0 replies; 7+ messages in thread
From: neil.armstrong @ 2024-06-27 12:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 27/06/2024 14:20, Krzysztof Kozlowski wrote:
> Add appropriate mappings of Soundwire ports of WSA8845 speaker. This
> solves second (south) speaker sound distortions when playing audio.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Bindings:
> https://lore.kernel.org/all/20240626-port-map-v1-3-bd8987d2b332@linaro.org/
>
> Can be applied independently, if bindings are fine.
> ---
> arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> index e0dc03a97771..2e12219006c9 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> @@ -1106,6 +1106,7 @@ north_spkr: speaker@0,0 {
>
> #sound-dai-cells = <0>;
> sound-name-prefix = "SpkrLeft";
> + qcom,port-mapping = <1 2 3 7 10 13>;
> };
>
> /* WSA8845, Speaker South */
> @@ -1123,6 +1124,7 @@ south_spkr: speaker@0,1 {
>
> #sound-dai-cells = <0>;
> sound-name-prefix = "SpkrRight";
> + qcom,port-mapping = <4 5 6 7 11 13>;
> };
> };
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: (subset) [PATCH 1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers
2024-06-27 12:20 [PATCH 1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers Krzysztof Kozlowski
` (2 preceding siblings ...)
2024-06-27 12:33 ` [PATCH 1/3] arm64: dts: qcom: sm8550-hdk: " neil.armstrong
@ 2024-07-03 3:37 ` Bjorn Andersson
3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2024-07-03 3:37 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
On Thu, 27 Jun 2024 14:20:13 +0200, Krzysztof Kozlowski wrote:
> Add appropriate mappings of Soundwire ports of WSA8845 speaker. This
> solves second (south) speaker sound distortions when playing audio.
>
>
Applied, thanks!
[1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers
commit: 21663c69b3f75ae52d9f1f6b844aa2bb314a6a3f
[2/3] arm64: dts: qcom: sm8550-mtp: add port mapping to speakers
commit: 5ba3ba4d4439709c68b96aef3b0e71c63fd9d665
[3/3] arm64: dts: qcom: sm8550-qrd: add port mapping to speakers
commit: 6bf99fdb4c93b165e77b879606f2e9c2571399da
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-07-03 3:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-27 12:20 [PATCH 1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers Krzysztof Kozlowski
2024-06-27 12:20 ` [PATCH 2/3] arm64: dts: qcom: sm8550-mtp: " Krzysztof Kozlowski
2024-06-27 12:33 ` neil.armstrong
2024-06-27 12:20 ` [PATCH 3/3] arm64: dts: qcom: sm8550-qrd: " Krzysztof Kozlowski
2024-06-27 12:32 ` neil.armstrong
2024-06-27 12:33 ` [PATCH 1/3] arm64: dts: qcom: sm8550-hdk: " neil.armstrong
2024-07-03 3:37 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).