From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C1D03033CB for ; Wed, 7 Oct 2026 06:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791353571; cv=none; b=pn4PVmaYeOMNr4cQqobL7+Gld+geFAgwEtKZb6QmkolniE5JirIiivt6IXAQnlqbQkNRg4icQASaE+sf5tFtXYd0MGXfpPiXQQzNri2+yIs2BQBT1j3O48c4dq+p5ao1eYeBZ3Q+tQ7FfYmQ3VwItP6NbYLR/lJJ8BxutJi4nnc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791353571; c=relaxed/simple; bh=HDfxlLW6jyBpQpQPXFWOlUGmrqt4DNQzoTXk0MiiH90=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qb/2925gVG+TVuvvn/OH7tCQjPLiEDoYgxteKLhV/l9/jeb1tKhCzztQIbi4HP0WLDp5Fj9kt4RgeUyHDgn0y2X3XCH0keQZane8xIUPSNCBRr0ntsY1TPTqnHrbkaSST9ymKcQk+nxfrMxAaa31O8ZeJqJDTbGGzjvSfvp18eY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JgmJTDGT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iOEbvnLT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JgmJTDGT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iOEbvnLT" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6975OAIH1567533 for ; Wed, 7 Oct 2026 06:12:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mEeWG7KO8nVXNOa5twFybh1jJy97lZB8PRaYGWiQRVk=; b=JgmJTDGTaC2kRj93 0Fbp8P9UhNeqSgVkFr6Us1tYGfuHS2rtwiXBc96Jrj4EPeQyxhdndYJvViOTvkmd 1ZsUb4rGIgfvFQEL6FpLZNXqtCSwHl3nry30P+wAWdDqeuw0aytv4MVn++obdiCV Brf3OPFbTfVHF0R8aebxh5+IbnUr8k7qChCJvyoJk+5SQzgKgTPTXFMBMIuEMByh RsLi8acLT+iruEA+xutpqIpge0nEe7JApFUQRpt2/TQZEom8KV88Qv+28AxEOPkk OzbDNDQyaNFvxILKGxJmAqC9L0DguVL4LED9lzzURaoIpJO0d7LEEBRJHrRZBqpB u2RqkA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h5fw8r4nw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 07 Oct 2026 06:12:48 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2df5a65671eso22237815ad.1 for ; Tue, 06 Oct 2026 23:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791353568; x=1791958368; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mEeWG7KO8nVXNOa5twFybh1jJy97lZB8PRaYGWiQRVk=; b=iOEbvnLTwVD4LYkhw9lk0JoSbhLyCV1XxiP2NRnT6ZBdcNTPPHQmwHmwaDkeF4ob8o 3Mc7YOjMATvH6D0DdHj2LULzqrCXgbT4MupFR2wwE9ZtIJapIlJZAUf8RABdLLImaM62 j48Rfsws//tdpHVE9thzR3wf1AMzm4Lvc29qVaOrJjDqe2xyg06mC8UJqHkuDUZfvydS inmPONcXpizbVqmy/Fz5rG/rmWfhCE7HU5/OmhB5L1p06Il24ALIqDc20MfpMPC+mwFj 2FYyMizjlp/2ZE6pjh4l1/L8XRaV+3GQevdPIuAS5D7EynZ4TYCEZh9vrncu4hr6RAqp yWlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791353568; x=1791958368; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mEeWG7KO8nVXNOa5twFybh1jJy97lZB8PRaYGWiQRVk=; b=Yi62X6oyXRvc+3Fv7gDOwnYqUtfPVyhVBG1uI/WuMFjTMz5Nh/8yemyX1VYBoVoDmP ZrSUy73CR3QaBw1z7k6bd1qmqtjRxGRyTNN22Th70a8oUNr4HZ0/JfDm7ND7hEzucTaK /haQx1qDvRYSm6fyOKirUJcLiAVOwRHW2tuEZEpqQkTQ3xXFrgirFH55euKkzAUVi03y A2iWHteJk3YKx7xj1j1XOHYpZ9crmFbLs+eYHvSLC6VG5u5gUCAedoijQapZzN16oHfd KHFNAXDw5y/sBioHmZwtKgaXGaIHh5SQvlH/GC4DP+4b7FINafsuqmz5ClizXwQNFFer Aq1w== X-Forwarded-Encrypted: i=1; AKwUvByh6Me1G99uV9edlPeI1AixYQaKJoek+daMOiQHfpAnowM+5iV5e7ICnYGlAL/4kvj3NGbk0M4vTf2E@vger.kernel.org X-Gm-Message-State: AFq9FYL7ZqxbjXbdD+a9ZXTN5OjW7ZijzJMK6Cn83LISlHatMAI82uvV x2F5DMTUNX/1yLPYktvB0Tb1Ip/wNFPGzhx7areJ47v1pTXKW4gKrU+lMi7dQHHWom1KuewUpRu cbou9bCQfghJy1irARoh5va2kI0dn1kHk6CMxSbiEM9EJc4yYsDjtQkubf5HUDRR4 X-Gm-Gg: AYBFou1pk9t+xlvcM0WLk5dJ5AOosDI9Yon4FkKLBQ66H6VUPrPocoj4IPV0f4A9OGW HK2cSW/tNIrmdvkk00y5ntM3U2dBwxAj16ZDxbro0IhgOoPRx/64k/mVHQNuesrbBi1H5eOAcsU LKk+TkYGr4iIOhc37ErICSDFVkxCIFiVl5QqLwdcqQ/W3fU+G/ZKKG2jJ3gimMZNu6gIeNZo+bg upjn+V6o1TlvhNwUIuJM1/2i558mX1aZsSK8bq3/I0A1BJlkc9YeWeo1f140UIbCaE/nsj/lzHQ nBdUkPVo28HKm88JsdiuObx8+moTeHyfNKPhTziwVit/MPDM4mi8EpkHafbM5Wl5nxyIESF7lcp r90/glUdmp+mExUYXOtRxdAGVShjv X-Received: by 2002:a17:902:d54f:b0:2e6:1715:e4a6 with SMTP id d9443c01a7336-2e61715e821mr2275655ad.38.1791353567816; Tue, 06 Oct 2026 23:12:47 -0700 (PDT) X-Received: by 2002:a17:902:d54f:b0:2e6:1715:e4a6 with SMTP id d9443c01a7336-2e61715e821mr2275455ad.38.1791353567290; Tue, 06 Oct 2026 23:12:47 -0700 (PDT) Received: from [10.204.78.119] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e6046fe0e8sm5326635ad.25.2026.10.06.23.12.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Oct 2026 23:12:46 -0700 (PDT) Message-ID: Date: Wed, 7 Oct 2026 11:42:37 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/17] phy: qcom: edp: Add Nord-specific register offsets To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kuogee Hsieh , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Ritesh Kumar , Mahadevan P References: <20260911-nord-drv-dt-v1-0-e25c073cf1b6@oss.qualcomm.com> <20260911-nord-drv-dt-v1-7-e25c073cf1b6@oss.qualcomm.com> Content-Language: en-GB From: Nabige Aala In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA3MDAyNCBTYWx0ZWRfXy8aVXf48XQzc 9EYLSp4mSTVzh+3JxO2IayQD4p7IfMoA+bzTCBf6urjo2+Qbn07cwfyX7p0gMbMRG2WnjQCfRdW Ot9IyZMHI/0AtXxcJY8gr3F+oXugR78= X-Proofpoint-ORIG-GUID: xgYQCf3-Z4LWHK6u2IJoLh-Ql8D6tsVM X-Proofpoint-GUID: xgYQCf3-Z4LWHK6u2IJoLh-Ql8D6tsVM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA3MDAyNCBTYWx0ZWRfX7iOvCN4WsCLl LHbbQEC+qqJ+tPIu/stHkpdbUxOLhRkPtSJQkBa4b8OcUWcKVcnx4D0JCSgi4O3sHFa5ZGx3Pv3 2te83NzvQXzBEEOC8/iKbeov0W6G0eyBmiPiuD3pMWNbsfYjVIXxjyK1nat4livYlSYo6wrAoJH 0XTBwLZ0BP59owbo5gWbMOK6bjNJ6VVKnbVDzRNYQy+sJiQZwwJ9E4TeOSkW3g0rL/p16BN2cf/ dpudPLofn/HJXn8eBEY2aLX7W21kUXiscvjxJG3j+QMte3p+CIgI384CKXGge8o9NtTV/gu3E36 mgoPamFT0r4o7cecDuFoKdTGuSDGj/+Gb9ZJOxB4dl6oQS+0QoCbsKp00qHXpbjsYYDTFpgP3XS idSXB+/WwwY4UQhTSUome2jOYm7Wgym8lrX91WJ95xYrhBnIRuwmE0VOmZAvWad5VKW3aM0loWu ePm7EDgIe9eIXC8mIzQ== X-Authority-Analysis: v=2.4 cv=Af0kjHXG c=1 sm=1 tr=0 ts=6ac5e2e0 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=ws4HDfdl8TRdMr_wlFsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-07_02,2026-10-06_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2610070024 On 9/14/2026 5:28 AM, Dmitry Baryshkov wrote: > On Fri, Sep 11, 2026 at 09:06:38PM +0530, Nabige Aala wrote: >> From: Ritesh Kumar >> >> Nord relocates several DP PHY and QSERDES v8 COM registers relative >> to existing SoCs. Add Nord-specific defines for the relocated and >> new-only registers in phy-qcom-qmp-qserdes-dp-com-v8.h and >> phy-qcom-edp.c so Nord sequences can reference them by name. > If the registers are reallocated it usually means that there are other > registers being inserted (or deleted). Are those the only registers > being changed? Yes, only few register offset is changed that is taken care in this change. >> Signed-off-by: Ritesh Kumar >> Signed-off-by: Nabige Aala >> --- >> drivers/phy/qualcomm/phy-qcom-edp.c | 10 ++++++++++ >> drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h | 3 +++ >> 2 files changed, 13 insertions(+) >> >> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c >> index a3c893f72908..bf8a17336c7e 100644 >> --- a/drivers/phy/qualcomm/phy-qcom-edp.c >> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c >> @@ -41,9 +41,19 @@ >> >> #define DP_PHY_VCO_DIV 0x0074 >> #define DP_PHY_TX0_TX1_LANE_CTL 0x007c >> +/* Nord uses a different register layout; non-Nord value is 0x00a0 */ >> #define DP_PHY_TX2_TX3_LANE_CTL 0x00a0 >> +#define DP_PHY_TX2_TX3_LANE_CTL_NORD 0x00c0 >> >> +/* Nord uses a different register layout; non-Nord value is 0x00e0 */ >> #define DP_PHY_STATUS 0x00e0 >> +#define DP_PHY_STATUS_NORD 0x0110 >> +#define DP_PHY_LDO_CFG 0x00f0 > Why does it not have a _NORD suffix? Ack, I will add  _NORD suffix in the next revision. Thanks > >> + >> +/* Nord-specific TX lane registers */ >> +#define DP_PHY_TX_LN0_DRV_LVL_NORD 0x00e4 >> +#define DP_PHY_TX_LN1_DRV_LVL_NORD 0x00e8 >> +#define TXn_TX_BAND_NORD 0x0024 >> >> /* LANE_TXn registers */ >> #define TXn_CLKBUF_ENABLE 0x0000 >> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h >> index 93edabb830af..008b17222a8d 100644 >> --- a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h >> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h >> @@ -48,5 +48,8 @@ >> #define DP_QSERDES_V8_COM_CLK_FWD_CONFIG_1 0x2f4 >> #define DP_QSERDES_V8_COM_CMN_STATUS 0x314 >> #define DP_QSERDES_V8_COM_C_READY_STATUS 0x33c >> +#define DP_QSERDES_V8_COM_SVS_MODE_CLK_SEL_NORD 0x17c >> +#define DP_QSERDES_V8_COM_CMN_STATUS_NORD 0x1d0 >> +#define DP_QSERDES_V8_COM_C_READY_STATUS_NORD 0x1f8 >> >> #endif >> >> -- >> 2.34.1 >>