* [PATCH v2] arm64: dts: qcom: agatti: enable FastRPC on the ADSP
@ 2026-01-13 16:41 Dmitry Baryshkov
2026-01-14 9:33 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2026-01-13 16:41 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On Agatti platform the ADSP provides FastRPC support. Add corresponding
device node, in order to be able to utilize the DSP offload from the
Linux side.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Changes in v2:
- Add more FastRPC context banks (6, 7)
- Link to v1: https://lore.kernel.org/r/20260113-agatti-fastrpc-v1-1-e210903ffcb1@oss.qualcomm.com
---
arch/arm64/boot/dts/qcom/agatti.dtsi | 41 ++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
index 7815ece261ea..217d465df846 100644
--- a/arch/arm64/boot/dts/qcom/agatti.dtsi
+++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
@@ -2287,6 +2287,47 @@ q6routing: routing {
};
};
};
+
+ fastrpc {
+ compatible = "qcom,fastrpc";
+ qcom,glink-channels = "fastrpcglink-apps-dsp";
+ label = "adsp";
+
+ qcom,non-secure-domain;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ compute-cb@3 {
+ compatible = "qcom,fastrpc-compute-cb";
+ reg = <3>;
+ iommus = <&apps_smmu 0x1c3 0x0>;
+ };
+
+ compute-cb@4 {
+ compatible = "qcom,fastrpc-compute-cb";
+ reg = <4>;
+ iommus = <&apps_smmu 0x1c4 0x0>;
+ };
+
+ compute-cb@5 {
+ compatible = "qcom,fastrpc-compute-cb";
+ reg = <5>;
+ iommus = <&apps_smmu 0x1c5 0x0>;
+ };
+
+ compute-cb@6 {
+ compatible = "qcom,fastrpc-compute-cb";
+ reg = <6>;
+ iommus = <&apps_smmu 0x1c6 0x0>;
+ };
+
+ compute-cb@7 {
+ compatible = "qcom,fastrpc-compute-cb";
+ reg = <7>;
+ iommus = <&apps_smmu 0x1c7 0x0>;
+ };
+ };
};
};
---
base-commit: 0f853ca2a798ead9d24d39cad99b0966815c582a
change-id: 20260113-agatti-fastrpc-e3fe4bea2b42
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: agatti: enable FastRPC on the ADSP
2026-01-13 16:41 [PATCH v2] arm64: dts: qcom: agatti: enable FastRPC on the ADSP Dmitry Baryshkov
@ 2026-01-14 9:33 ` Konrad Dybcio
2026-01-21 19:56 ` Bjorn Andersson
2026-03-30 4:54 ` Sumit Garg
2 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2026-01-14 9:33 UTC (permalink / raw)
To: Dmitry Baryshkov, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 1/13/26 5:41 PM, Dmitry Baryshkov wrote:
> On Agatti platform the ADSP provides FastRPC support. Add corresponding
> device node, in order to be able to utilize the DSP offload from the
> Linux side.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> Changes in v2:
> - Add more FastRPC context banks (6, 7)
> - Link to v1: https://lore.kernel.org/r/20260113-agatti-fastrpc-v1-1-e210903ffcb1@oss.qualcomm.com
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: agatti: enable FastRPC on the ADSP
2026-01-13 16:41 [PATCH v2] arm64: dts: qcom: agatti: enable FastRPC on the ADSP Dmitry Baryshkov
2026-01-14 9:33 ` Konrad Dybcio
@ 2026-01-21 19:56 ` Bjorn Andersson
2026-03-30 4:54 ` Sumit Garg
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2026-01-21 19:56 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Dmitry Baryshkov
Cc: linux-arm-msm, devicetree, linux-kernel
On Tue, 13 Jan 2026 18:41:59 +0200, Dmitry Baryshkov wrote:
> On Agatti platform the ADSP provides FastRPC support. Add corresponding
> device node, in order to be able to utilize the DSP offload from the
> Linux side.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: agatti: enable FastRPC on the ADSP
commit: 851d5ae6003b6517fb641675c33d4b529765fe14
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: agatti: enable FastRPC on the ADSP
2026-01-13 16:41 [PATCH v2] arm64: dts: qcom: agatti: enable FastRPC on the ADSP Dmitry Baryshkov
2026-01-14 9:33 ` Konrad Dybcio
2026-01-21 19:56 ` Bjorn Andersson
@ 2026-03-30 4:54 ` Sumit Garg
2026-03-30 10:37 ` Konrad Dybcio
2 siblings, 1 reply; 5+ messages in thread
From: Sumit Garg @ 2026-03-30 4:54 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Tue, Jan 13, 2026 at 06:41:59PM +0200, Dmitry Baryshkov wrote:
> On Agatti platform the ADSP provides FastRPC support. Add corresponding
> device node, in order to be able to utilize the DSP offload from the
> Linux side.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> Changes in v2:
> - Add more FastRPC context banks (6, 7)
> - Link to v1: https://lore.kernel.org/r/20260113-agatti-fastrpc-v1-1-e210903ffcb1@oss.qualcomm.com
> ---
> arch/arm64/boot/dts/qcom/agatti.dtsi | 41 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
This patch causes a critical boot regression on RB1 as per the CI test
report here [1]. I see this change already landed in this merge window.
So, either this commit has to be reverted for v7.0 release or an
appropriate fix is required.
[1] https://github.com/qualcomm-linux/kernel/issues/359
-Sumit
> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
> index 7815ece261ea..217d465df846 100644
> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi
> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
> @@ -2287,6 +2287,47 @@ q6routing: routing {
> };
> };
> };
> +
> + fastrpc {
> + compatible = "qcom,fastrpc";
> + qcom,glink-channels = "fastrpcglink-apps-dsp";
> + label = "adsp";
> +
> + qcom,non-secure-domain;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + compute-cb@3 {
> + compatible = "qcom,fastrpc-compute-cb";
> + reg = <3>;
> + iommus = <&apps_smmu 0x1c3 0x0>;
> + };
> +
> + compute-cb@4 {
> + compatible = "qcom,fastrpc-compute-cb";
> + reg = <4>;
> + iommus = <&apps_smmu 0x1c4 0x0>;
> + };
> +
> + compute-cb@5 {
> + compatible = "qcom,fastrpc-compute-cb";
> + reg = <5>;
> + iommus = <&apps_smmu 0x1c5 0x0>;
> + };
> +
> + compute-cb@6 {
> + compatible = "qcom,fastrpc-compute-cb";
> + reg = <6>;
> + iommus = <&apps_smmu 0x1c6 0x0>;
> + };
> +
> + compute-cb@7 {
> + compatible = "qcom,fastrpc-compute-cb";
> + reg = <7>;
> + iommus = <&apps_smmu 0x1c7 0x0>;
> + };
> + };
> };
> };
>
>
> ---
> base-commit: 0f853ca2a798ead9d24d39cad99b0966815c582a
> change-id: 20260113-agatti-fastrpc-e3fe4bea2b42
>
> Best regards,
> --
> With best wishes
> Dmitry
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: agatti: enable FastRPC on the ADSP
2026-03-30 4:54 ` Sumit Garg
@ 2026-03-30 10:37 ` Konrad Dybcio
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2026-03-30 10:37 UTC (permalink / raw)
To: Sumit Garg, Dmitry Baryshkov, Ekansh Gupta
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On 3/30/26 6:54 AM, Sumit Garg wrote:
> On Tue, Jan 13, 2026 at 06:41:59PM +0200, Dmitry Baryshkov wrote:
>> On Agatti platform the ADSP provides FastRPC support. Add corresponding
>> device node, in order to be able to utilize the DSP offload from the
>> Linux side.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> ---
>> Changes in v2:
>> - Add more FastRPC context banks (6, 7)
>> - Link to v1: https://lore.kernel.org/r/20260113-agatti-fastrpc-v1-1-e210903ffcb1@oss.qualcomm.com
>> ---
>> arch/arm64/boot/dts/qcom/agatti.dtsi | 41 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 41 insertions(+)
>>
>
> This patch causes a critical boot regression on RB1 as per the CI test
> report here [1]. I see this change already landed in this merge window.
> So, either this commit has to be reverted for v7.0 release or an
> appropriate fix is required.
>
> [1] https://github.com/qualcomm-linux/kernel/issues/359
Why has that issue been opened 2 weeks ago with no action since?
FWIW, copying the broader log from the LAVA job:
[[0;32m OK [0m] Reached target [0;1;39mBasic System[0m.
Starting [0;1;39maDSP RPC daemon[0m...
Starting [0;1;39maudiopd aDSP RPC daemon[0m...
Starting [0;1;39mAndroid Debug Bridge[0m...
Starting [0;1;39mAvahi mDNS/DNS-SD Stack[0m...
Starting [0;1;39mBluetooth service[0m...
Starting [0;1;39mD-Bus System Message Bus[0m...
[ 17.318840] qcom,fastrpc-cb ab00000.remoteproc:glink-edge:fastrpc:compute-cb@4: mem mmap error, fd 11, vaddr ffffae380000, size 262144
[ 17.327877] qcom_q6v5_pas ab00000.remoteproc: fatal error received: SFR Init: wdog or kernel error suspected.
[ 17.343248] remoteproc remoteproc1: crash detected in adsp: type fatal error
[ 17.350567] qcom_q6v5_pas ab00000.remoteproc: Handover signaled, but it already happened
[ 17.358869] remoteproc remoteproc1: handling crash #1 in adsp
[ 17.364730] remoteproc remoteproc1: recovering adsp
Format: Log Type - Time(microsec) - Message - Optional Info
Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic
<ded>
It seems like this only ends up being a problem once the userland
daemon starting poking at the channel - +Ekansh, have you seen this
before?
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-30 10:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-13 16:41 [PATCH v2] arm64: dts: qcom: agatti: enable FastRPC on the ADSP Dmitry Baryshkov
2026-01-14 9:33 ` Konrad Dybcio
2026-01-21 19:56 ` Bjorn Andersson
2026-03-30 4:54 ` Sumit Garg
2026-03-30 10:37 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox