* [PATCH v4 0/2] Add edp reference clock for lemans
@ 2026-01-28 11:48 Ritesh Kumar
2026-01-28 11:48 ` [PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY Ritesh Kumar
2026-01-28 11:48 ` [PATCH v4 2/2] arm64: dts: qcom: lemans: Add eDP ref clock for eDP PHYs Ritesh Kumar
0 siblings, 2 replies; 9+ messages in thread
From: Ritesh Kumar @ 2026-01-28 11:48 UTC (permalink / raw)
To: robin.clark, lumag, abhinav.kumar, sean, marijn.suijten,
maarten.lankhorst, mripard, tzimmermann, airlied, simona, robh,
krzk+dt, conor+dt, quic_mahap, andersson, konradybcio, mani,
James.Bottomley, martin.petersen, vkoul, kishon,
cros-qcom-dts-watchers
Cc: Ritesh Kumar, linux-phy, linux-arm-msm, dri-devel, freedreno,
devicetree, linux-kernel, linux-scsi, quic_vproddut
On lemans chipset, edp reference clock is being voted by ufs mem phy
(ufs_mem_phy: phy@1d87000). But after commit 77d2fa54a945
("scsi: ufs: qcom : Refactor phy_power_on/off calls") edp reference
clock is getting turned off, leading to below phy poweron failure on
lemans edp phy.
[ 19.830220] phy phy-aec2a00.phy.10: phy poweron failed --> -110
[ 19.842112] mdss_0_disp_cc_mdss_dptx0_link_clk status stuck at 'off'
[ 19.842131] WARNING: CPU: 2 PID: 371 at drivers/clk/qcom/clk-branch.c:87 clk_branch_toggle+0x174/0x18c
[ 19.984356] Hardware name: Qualcomm QCS9100 Ride (DT)
[ 19.989548] pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 19.996697] pc : clk_branch_toggle+0x174/0x18c
[ 20.001267] lr : clk_branch_toggle+0x174/0x18c
[ 20.005833] sp : ffff8000863ebbc0
[ 20.009251] x29: ffff8000863ebbd0 x28: 0000000000000000 x27: 0000000000000000
[ 20.016579] x26: 0000000000000000 x25: 0000000000000000 x24: 0000000000000001
[ 20.023915] x23: ffff0000c53de980 x22: 0000000000000001 x21: ffffb4b57fd8d710
[ 20.031245] x20: ffffb4b5bb238b88 x19: 0000000000000000 x18: ffffffffffff7198
[ 20.038584] x17: 0000000000000014 x16: ffffb4b5bb1e2330 x15: 0000000000000048
[ 20.045926] x14: 0000000000000000 x13: ffffb4b5bd386a48 x12: 0000000000000dfb
[ 20.053263] x11: 00000000000004a9 x10: ffffb4b5bd3e5a20 x9 : ffffb4b5bd386a48
[ 20.060600] x8 : 00000000ffffefff x7 : ffffb4b5bd3dea48 x6 : 00000000000004a9
[ 20.067934] x5 : ffff000eb7d38408 x4 : 40000000fffff4a9 x3 : ffff4b58fb2b7000
[ 20.075269] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff000ec4fc3480
[ 20.082601] Call trace:
[ 20.085127] clk_branch_toggle+0x174/0x18c (P)
[ 20.089705] clk_branch2_enable+0x1c/0x28
[ 20.093829] clk_core_enable+0x6c/0xac
[ 20.097687] clk_enable+0x2c/0x4c
[ 20.101104] clk_bulk_enable+0x4c/0xd8
[ 20.104964] msm_dp_ctrl_enable_mainlink_clocks+0x184/0x24c [msm]
[ 20.111294] msm_dp_ctrl_on_link+0xb0/0x400 [msm]
[ 20.116178] msm_dp_display_process_hpd_high+0x110/0x190 [msm]
[ 20.122209] msm_dp_hpd_plug_handle.isra.0+0xac/0x1c4 [msm]
[ 20.127983] hpd_event_thread+0x320/0x5cc [msm]
[ 20.132680] kthread+0x12c/0x204
[ 20.136011] ret_from_fork+0x10/0x20
[ 20.139699] ---[ end trace 0000000000000000 ]---
[ 20.144489] Failed to enable clk 'ctrl_link': -16
[ 20.149340] [drm:msm_dp_ctrl_enable_mainlink_clocks [msm]] *ERROR* Unable to start link clocks. ret=-16
This series adds support for voting the clock from lemans edp phy driver.
---
Change in v4:
- The dependent series is merged. Rebased to latest linux-next. Removed dependency in cover letter.
- Update commit message of dt-bindings patch. [Krzysztof]
- Update commit message of devicetree patch to give more detail. [Abel Vesa]
- Link to v3: https://lore.kernel.org/all/20251104114327.27842-1-riteshk@qti.qualcomm.com/
Change in v3:
- Rebase to latest linux-next and latest version 5 of dependency.
- Squash both DT binding patches together. [Dmitry, Rob]
- Add dt-binding change in sorted order. [Dmitry]
- Update commit message of bindings patch to give more detail of the problem. [Bjorn]
- Update commit message of devicetree patch and add Fixes tag. [Dmitry]
- Link to v2: https://lore.kernel.org/all/20251013104806.6599-1-quic_riteshk@quicinc.com/
Change in v2:
- Rebase on top of dependent series. [Krzysztof]
- Remove duplicate patches and make changes limited to lemans.
- Link to v1: https://lore.kernel.org/all/20251009071127.26026-1-quic_riteshk@quicinc.com/
---
Ritesh Kumar (2):
dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY
arm64: dts: qcom: lemans: Add eDP ref clock for eDP PHYs
.../bindings/display/msm/qcom,sa8775p-mdss.yaml | 6 ++++--
.../devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
arch/arm64/boot/dts/qcom/lemans.dtsi | 12 ++++++++----
3 files changed, 13 insertions(+), 6 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY
2026-01-28 11:48 [PATCH v4 0/2] Add edp reference clock for lemans Ritesh Kumar
@ 2026-01-28 11:48 ` Ritesh Kumar
2026-01-29 16:53 ` Rob Herring (Arm)
2026-03-04 18:57 ` Bjorn Andersson
2026-01-28 11:48 ` [PATCH v4 2/2] arm64: dts: qcom: lemans: Add eDP ref clock for eDP PHYs Ritesh Kumar
1 sibling, 2 replies; 9+ messages in thread
From: Ritesh Kumar @ 2026-01-28 11:48 UTC (permalink / raw)
To: robin.clark, lumag, abhinav.kumar, sean, marijn.suijten,
maarten.lankhorst, mripard, tzimmermann, airlied, simona, robh,
krzk+dt, conor+dt, quic_mahap, andersson, konradybcio, mani,
James.Bottomley, martin.petersen, vkoul, kishon,
cros-qcom-dts-watchers
Cc: Ritesh Kumar, linux-phy, linux-arm-msm, dri-devel, freedreno,
devicetree, linux-kernel, linux-scsi, quic_vproddut
The initial sa8775p eDP PHY binding contribution missed adding support for
voting on the eDP reference clock. This went unnoticed because the UFS PHY
driver happened to enable the same clock.
After commit 77d2fa54a945 ("scsi: ufs: qcom : Refactor phy_power_on/off
calls"), the eDP reference clock is no longer kept enabled, which results
in the following PHY power-on failure:
phy phy-aec2a00.phy.10: phy poweron failed --> -110
To fix this, explicit voting for the eDP reference clock is required.
This patch adds the eDP reference clock for sa8775p eDP PHY and updates
the corresponding example node.
Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
---
.../devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 6 ++++--
Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
index e2730a2f25cf..6c827cf9692b 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
@@ -200,9 +200,11 @@ examples:
<0x0aec2000 0x1c8>;
clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
- <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>;
+ <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&gcc GCC_EDP_REF_CLKREF_EN>;
clock-names = "aux",
- "cfg_ahb";
+ "cfg_ahb",
+ "ref";
#clock-cells = <1>;
#phy-cells = <0>;
diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
index 4a1daae3d8d4..0bf8bf4f66ac 100644
--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
@@ -74,6 +74,7 @@ allOf:
compatible:
enum:
- qcom,glymur-dp-phy
+ - qcom,sa8775p-edp-phy
- qcom,x1e80100-dp-phy
then:
properties:
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v4 2/2] arm64: dts: qcom: lemans: Add eDP ref clock for eDP PHYs
2026-01-28 11:48 [PATCH v4 0/2] Add edp reference clock for lemans Ritesh Kumar
2026-01-28 11:48 ` [PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY Ritesh Kumar
@ 2026-01-28 11:48 ` Ritesh Kumar
2026-01-28 12:41 ` Konrad Dybcio
1 sibling, 1 reply; 9+ messages in thread
From: Ritesh Kumar @ 2026-01-28 11:48 UTC (permalink / raw)
To: robin.clark, lumag, abhinav.kumar, sean, marijn.suijten,
maarten.lankhorst, mripard, tzimmermann, airlied, simona, robh,
krzk+dt, conor+dt, quic_mahap, andersson, konradybcio, mani,
James.Bottomley, martin.petersen, vkoul, kishon,
cros-qcom-dts-watchers
Cc: Ritesh Kumar, linux-phy, linux-arm-msm, dri-devel, freedreno,
devicetree, linux-kernel, linux-scsi, quic_vproddut
The eDP PHY nodes on lemans were missing the reference clock voting.
This initially went unnoticed because the clock was implicitly enabled
by the UFS PHY driver, and the eDP PHY happened to rely on that.
After commit 77d2fa54a945 ("scsi: ufs: qcom : Refactor phy_power_on/off
calls"), the UFS driver no longer keeps the reference clock enabled.
As a result, the eDP PHY fails to power on.
To fix this, add eDP reference clock for eDP PHYs on lemans chipset
ensuring reference clock is enabled.
Fixes: e1e3e5673f8d7 ("arm64: dts: qcom: sa8775p: add DisplayPort device nodes")
Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
---
arch/arm64/boot/dts/qcom/lemans.dtsi | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
index 808827b83553..1da8e7fb6775 100644
--- a/arch/arm64/boot/dts/qcom/lemans.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
@@ -5301,9 +5301,11 @@ mdss0_dp0_phy: phy@aec2a00 {
<0x0 0x0aec2000 0x0 0x1c8>;
clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
- <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>;
+ <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&gcc GCC_EDP_REF_CLKREF_EN>;
clock-names = "aux",
- "cfg_ahb";
+ "cfg_ahb",
+ "ref";
#clock-cells = <1>;
#phy-cells = <0>;
@@ -5320,9 +5322,11 @@ mdss0_dp1_phy: phy@aec5a00 {
<0x0 0x0aec5000 0x0 0x1c8>;
clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_AUX_CLK>,
- <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>;
+ <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&gcc GCC_EDP_REF_CLKREF_EN>;
clock-names = "aux",
- "cfg_ahb";
+ "cfg_ahb",
+ "ref";
#clock-cells = <1>;
#phy-cells = <0>;
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: qcom: lemans: Add eDP ref clock for eDP PHYs
2026-01-28 11:48 ` [PATCH v4 2/2] arm64: dts: qcom: lemans: Add eDP ref clock for eDP PHYs Ritesh Kumar
@ 2026-01-28 12:41 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2026-01-28 12:41 UTC (permalink / raw)
To: Ritesh Kumar, robin.clark, lumag, abhinav.kumar, sean,
marijn.suijten, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, robh, krzk+dt, conor+dt, quic_mahap, andersson,
konradybcio, mani, James.Bottomley, martin.petersen, vkoul,
kishon, cros-qcom-dts-watchers
Cc: linux-phy, linux-arm-msm, dri-devel, freedreno, devicetree,
linux-kernel, linux-scsi, quic_vproddut
On 1/28/26 12:48 PM, Ritesh Kumar wrote:
> The eDP PHY nodes on lemans were missing the reference clock voting.
> This initially went unnoticed because the clock was implicitly enabled
> by the UFS PHY driver, and the eDP PHY happened to rely on that.
>
> After commit 77d2fa54a945 ("scsi: ufs: qcom : Refactor phy_power_on/off
> calls"), the UFS driver no longer keeps the reference clock enabled.
> As a result, the eDP PHY fails to power on.
>
> To fix this, add eDP reference clock for eDP PHYs on lemans chipset
> ensuring reference clock is enabled.
>
> Fixes: e1e3e5673f8d7 ("arm64: dts: qcom: sa8775p: add DisplayPort device nodes")
> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY
2026-01-28 11:48 ` [PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY Ritesh Kumar
@ 2026-01-29 16:53 ` Rob Herring (Arm)
2026-03-04 18:57 ` Bjorn Andersson
1 sibling, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2026-01-29 16:53 UTC (permalink / raw)
To: Ritesh Kumar
Cc: quic_mahap, robin.clark, mripard, krzk+dt, dri-devel,
martin.petersen, tzimmermann, lumag, simona, linux-kernel,
maarten.lankhorst, sean, kishon, James.Bottomley, marijn.suijten,
devicetree, andersson, cros-qcom-dts-watchers, linux-scsi, vkoul,
mani, linux-arm-msm, linux-phy, quic_vproddut, abhinav.kumar,
conor+dt, konradybcio, freedreno, airlied
On Wed, 28 Jan 2026 17:18:49 +0530, Ritesh Kumar wrote:
> The initial sa8775p eDP PHY binding contribution missed adding support for
> voting on the eDP reference clock. This went unnoticed because the UFS PHY
> driver happened to enable the same clock.
>
> After commit 77d2fa54a945 ("scsi: ufs: qcom : Refactor phy_power_on/off
> calls"), the eDP reference clock is no longer kept enabled, which results
> in the following PHY power-on failure:
>
> phy phy-aec2a00.phy.10: phy poweron failed --> -110
>
> To fix this, explicit voting for the eDP reference clock is required.
> This patch adds the eDP reference clock for sa8775p eDP PHY and updates
> the corresponding example node.
>
> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
> ---
> .../devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 6 ++++--
> Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY
2026-01-28 11:48 ` [PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY Ritesh Kumar
2026-01-29 16:53 ` Rob Herring (Arm)
@ 2026-03-04 18:57 ` Bjorn Andersson
2026-03-11 13:07 ` Ritesh Kumar
1 sibling, 1 reply; 9+ messages in thread
From: Bjorn Andersson @ 2026-03-04 18:57 UTC (permalink / raw)
To: Ritesh Kumar
Cc: robin.clark, lumag, abhinav.kumar, sean, marijn.suijten,
maarten.lankhorst, mripard, tzimmermann, airlied, simona, robh,
krzk+dt, conor+dt, quic_mahap, konradybcio, mani, James.Bottomley,
martin.petersen, vkoul, kishon, cros-qcom-dts-watchers, linux-phy,
linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
linux-scsi, quic_vproddut
On Wed, Jan 28, 2026 at 05:18:49PM +0530, Ritesh Kumar wrote:
> The initial sa8775p eDP PHY binding contribution missed adding support for
> voting on the eDP reference clock. This went unnoticed because the UFS PHY
> driver happened to enable the same clock.
>
> After commit 77d2fa54a945 ("scsi: ufs: qcom : Refactor phy_power_on/off
> calls"), the eDP reference clock is no longer kept enabled, which results
> in the following PHY power-on failure:
>
> phy phy-aec2a00.phy.10: phy poweron failed --> -110
>
> To fix this, explicit voting for the eDP reference clock is required.
> This patch adds the eDP reference clock for sa8775p eDP PHY and updates
> the corresponding example node.
>
> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
Is there any reason why you didn't follow up on this patch Ritesh?
Looks like it's ready to be merged.
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
> ---
> .../devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 6 ++++--
> Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> index e2730a2f25cf..6c827cf9692b 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> @@ -200,9 +200,11 @@ examples:
> <0x0aec2000 0x1c8>;
>
> clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
> - <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>;
> + <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
> + <&gcc GCC_EDP_REF_CLKREF_EN>;
> clock-names = "aux",
> - "cfg_ahb";
> + "cfg_ahb",
> + "ref";
>
> #clock-cells = <1>;
> #phy-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> index 4a1daae3d8d4..0bf8bf4f66ac 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> @@ -74,6 +74,7 @@ allOf:
> compatible:
> enum:
> - qcom,glymur-dp-phy
> + - qcom,sa8775p-edp-phy
> - qcom,x1e80100-dp-phy
> then:
> properties:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY
2026-03-04 18:57 ` Bjorn Andersson
@ 2026-03-11 13:07 ` Ritesh Kumar
2026-03-30 14:28 ` Bjorn Andersson
0 siblings, 1 reply; 9+ messages in thread
From: Ritesh Kumar @ 2026-03-11 13:07 UTC (permalink / raw)
To: Bjorn Andersson
Cc: robin.clark, lumag, abhinav.kumar, sean, marijn.suijten,
maarten.lankhorst, mripard, tzimmermann, airlied, simona, robh,
krzk+dt, conor+dt, quic_mahap, konradybcio, mani, James.Bottomley,
martin.petersen, vkoul, kishon, cros-qcom-dts-watchers, linux-phy,
linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
linux-scsi, quic_vproddut
On 3/5/2026 12:27 AM, Bjorn Andersson wrote:
> On Wed, Jan 28, 2026 at 05:18:49PM +0530, Ritesh Kumar wrote:
> > The initial sa8775p eDP PHY binding contribution missed adding support for
> > voting on the eDP reference clock. This went unnoticed because the UFS PHY
> > driver happened to enable the same clock.
> >
> > After commit 77d2fa54a945 ("scsi: ufs: qcom : Refactor phy_power_on/off
> > calls"), the eDP reference clock is no longer kept enabled, which results
> > in the following PHY power-on failure:
> >
> > phy phy-aec2a00.phy.10: phy poweron failed --> -110
> >
> > To fix this, explicit voting for the eDP reference clock is required.
> > This patch adds the eDP reference clock for sa8775p eDP PHY and updates
> > the corresponding example node.
> >
> > Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
>
> Is there any reason why you didn't follow up on this patch Ritesh?
> Looks like it's ready to be merged.
I was waiting for patch to merge as there is no pending comments.
> Reviewed-by: Bjorn Andersson <andersson@kernel.org>
>
> Regards,
> Bjorn
>
> > ---
> > .../devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 6 ++++--
> > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
> > 2 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > index e2730a2f25cf..6c827cf9692b 100644
> > --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > @@ -200,9 +200,11 @@ examples:
> > <0x0aec2000 0x1c8>;
> >
> > clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
> > - <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>;
> > + <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
> > + <&gcc GCC_EDP_REF_CLKREF_EN>;
> > clock-names = "aux",
> > - "cfg_ahb";
> > + "cfg_ahb",
> > + "ref";
> >
> > #clock-cells = <1>;
> > #phy-cells = <0>;
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > index 4a1daae3d8d4..0bf8bf4f66ac 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > @@ -74,6 +74,7 @@ allOf:
> > compatible:
> > enum:
> > - qcom,glymur-dp-phy
> > + - qcom,sa8775p-edp-phy
> > - qcom,x1e80100-dp-phy
> > then:
> > properties:
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY
2026-03-11 13:07 ` Ritesh Kumar
@ 2026-03-30 14:28 ` Bjorn Andersson
2026-03-30 18:42 ` Dmitry Baryshkov
0 siblings, 1 reply; 9+ messages in thread
From: Bjorn Andersson @ 2026-03-30 14:28 UTC (permalink / raw)
To: Ritesh Kumar
Cc: robin.clark, lumag, abhinav.kumar, sean, marijn.suijten,
maarten.lankhorst, mripard, tzimmermann, airlied, simona, robh,
krzk+dt, conor+dt, quic_mahap, konradybcio, mani, James.Bottomley,
martin.petersen, vkoul, kishon, cros-qcom-dts-watchers, linux-phy,
linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
linux-scsi, quic_vproddut
On Wed, Mar 11, 2026 at 06:37:31PM +0530, Ritesh Kumar wrote:
>
> On 3/5/2026 12:27 AM, Bjorn Andersson wrote:
> > On Wed, Jan 28, 2026 at 05:18:49PM +0530, Ritesh Kumar wrote:
> > > The initial sa8775p eDP PHY binding contribution missed adding support for
> > > voting on the eDP reference clock. This went unnoticed because the UFS PHY
> > > driver happened to enable the same clock.
> > > > After commit 77d2fa54a945 ("scsi: ufs: qcom : Refactor
> > phy_power_on/off
> > > calls"), the eDP reference clock is no longer kept enabled, which results
> > > in the following PHY power-on failure:
> > > > phy phy-aec2a00.phy.10: phy poweron failed --> -110
> > > > To fix this, explicit voting for the eDP reference clock is
> > required.
> > > This patch adds the eDP reference clock for sa8775p eDP PHY and updates
> > > the corresponding example node.
> > > > Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
> >
> > Is there any reason why you didn't follow up on this patch Ritesh?
> > Looks like it's ready to be merged.
>
> I was waiting for patch to merge as there is no pending comments.
>
It's been two months now, if you want your patches to be merged please
show that - ask the maintainer for a status update, ask a colleague to
send a reviewed-by...
Perhaps the maintainer lost track of your change?
Perhaps it's not clear that the change "need" an Ack from e.g. Dmitry
and then it should be merged by Vinod? Because you're changing two
different subsystems but leave it up to the maintainers to figure out
how to deal with this...
Either way, show that you want this to be merged, don't just wait until
the situation resolves itself.
Regards,
Bjorn
> > Reviewed-by: Bjorn Andersson <andersson@kernel.org>
> >
> > Regards,
> > Bjorn
> >
> > > ---
> > > .../devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 6 ++++--
> > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
> > > 2 files changed, 5 insertions(+), 2 deletions(-)
> > > > diff --git
> > a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > > index e2730a2f25cf..6c827cf9692b 100644
> > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > > @@ -200,9 +200,11 @@ examples:
> > > <0x0aec2000 0x1c8>;
> > > > clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
> > > - <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>;
> > > + <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
> > > + <&gcc GCC_EDP_REF_CLKREF_EN>;
> > > clock-names = "aux",
> > > - "cfg_ahb";
> > > + "cfg_ahb",
> > > + "ref";
> > > > #clock-cells = <1>;
> > > #phy-cells = <0>;
> > > diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > > index 4a1daae3d8d4..0bf8bf4f66ac 100644
> > > --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > > @@ -74,6 +74,7 @@ allOf:
> > > compatible:
> > > enum:
> > > - qcom,glymur-dp-phy
> > > + - qcom,sa8775p-edp-phy
> > > - qcom,x1e80100-dp-phy
> > > then:
> > > properties:
> > > -- > 2.34.1
> > >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY
2026-03-30 14:28 ` Bjorn Andersson
@ 2026-03-30 18:42 ` Dmitry Baryshkov
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2026-03-30 18:42 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Ritesh Kumar, robin.clark, lumag, abhinav.kumar, sean,
marijn.suijten, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, robh, krzk+dt, conor+dt, quic_mahap, konradybcio, mani,
James.Bottomley, martin.petersen, vkoul, kishon,
cros-qcom-dts-watchers, linux-phy, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel, linux-scsi, quic_vproddut
On Mon, Mar 30, 2026 at 09:28:40AM -0500, Bjorn Andersson wrote:
> On Wed, Mar 11, 2026 at 06:37:31PM +0530, Ritesh Kumar wrote:
> >
> > On 3/5/2026 12:27 AM, Bjorn Andersson wrote:
> > > On Wed, Jan 28, 2026 at 05:18:49PM +0530, Ritesh Kumar wrote:
> > > > The initial sa8775p eDP PHY binding contribution missed adding support for
> > > > voting on the eDP reference clock. This went unnoticed because the UFS PHY
> > > > driver happened to enable the same clock.
> > > > > After commit 77d2fa54a945 ("scsi: ufs: qcom : Refactor
> > > phy_power_on/off
> > > > calls"), the eDP reference clock is no longer kept enabled, which results
> > > > in the following PHY power-on failure:
> > > > > phy phy-aec2a00.phy.10: phy poweron failed --> -110
> > > > > To fix this, explicit voting for the eDP reference clock is
> > > required.
> > > > This patch adds the eDP reference clock for sa8775p eDP PHY and updates
> > > > the corresponding example node.
> > > > > Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
> > >
> > > Is there any reason why you didn't follow up on this patch Ritesh?
> > > Looks like it's ready to be merged.
> >
> > I was waiting for patch to merge as there is no pending comments.
> >
>
> It's been two months now, if you want your patches to be merged please
> show that - ask the maintainer for a status update, ask a colleague to
> send a reviewed-by...
>
> Perhaps the maintainer lost track of your change?
>
> Perhaps it's not clear that the change "need" an Ack from e.g. Dmitry
> and then it should be merged by Vinod? Because you're changing two
> different subsystems but leave it up to the maintainers to figure out
> how to deal with this...
>
>
> Either way, show that you want this to be merged, don't just wait until
> the situation resolves itself.
For merging through linux-phy:
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Vinod, please pick it up through your tree.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-03-30 18:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-28 11:48 [PATCH v4 0/2] Add edp reference clock for lemans Ritesh Kumar
2026-01-28 11:48 ` [PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY Ritesh Kumar
2026-01-29 16:53 ` Rob Herring (Arm)
2026-03-04 18:57 ` Bjorn Andersson
2026-03-11 13:07 ` Ritesh Kumar
2026-03-30 14:28 ` Bjorn Andersson
2026-03-30 18:42 ` Dmitry Baryshkov
2026-01-28 11:48 ` [PATCH v4 2/2] arm64: dts: qcom: lemans: Add eDP ref clock for eDP PHYs Ritesh Kumar
2026-01-28 12:41 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox