Re: [PATCH v2 11/11] ASoC: msm8916-wcd-analog: add quirk for cajon 2.0

[Richard Acayan <mailingradian@gmail.com>]

On Thu, Mar 05, 2026 at 11:07:33AM +0100, Stephan Gerhold wrote:
> On Wed, Mar 04, 2026 at 02:58:15PM -0500, Richard Acayan wrote:
> > The codec version CAJON_2_0 on the Snapdragon 670 requires touching the
> > HPH test registers. Add the quirk so this driver can also support
> > SDM670.
> > 
> > Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> > ---
> >  sound/soc/codecs/msm8916-wcd-analog.c | 63 ++++++++++++++++++++++++++-
> >  1 file changed, 61 insertions(+), 2 deletions(-)
> > 
> 
> I think you need some more changes in this driver to support CAJON_2_0
> properly. Specifically, the initial register settings are different from
> what is currently in the driver (wcd_reg_defaults_2_0). There was a
> patch for this [1] (later [2]), but it doesn't look like it was
> merged/finished up.

(+CC: Adam, Vlad)

It looks like the codec part is mostly complete except for some trivial
changes (empty line after compatibles in dt-bindings, constant to use
BIT(n) macro). I can take the codec patches if it's okay with the other
submitters:

- [PATCH v3 2/8] ASoC: dt-bindings: pm8916-wcd-analog-codec: Document pm8950/pm8953 Adam Skladowski
- [PATCH v3 3/8] ASoC: msm8916-wcd-analog: add pm8950 codec Adam Skladowski
- [PATCH v3 4/8] ASoC: msm8916-wcd-analog: add pm8953 codec Adam Skladowski
- [PATCH v3 8/8] ASoC: msm8916-wcd-analog: add lineout output Adam Skladowski

Maybe all the WCD codec patches should be split off to a new series,
otherwise this series would expand to 15 patches.

> [2]: https://lore.kernel.org/linux-arm-msm/20240731-msm8953-msm8976-asoc-v3-4-163f23c3a28d@gmail.com/