From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C0092989B7; Tue, 31 Mar 2026 08:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774947536; cv=none; b=kyJzDJalOpN1RRL+9ic+I+RiQ8LtXpPvAo9lfkwf07T+GDwqYdMY19Bn2OWDOBP6ItwZ3VADZkx6p32zcTh21ijgrBA2vfqibqslAtNz8Pt6rhArfVTaP+GHWlhmrNSmKAHVTSu76esOSOugwUHUDOJPLgAVzUQzTRnXfDkR344= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774947536; c=relaxed/simple; bh=FUPUgjK8/+PvpwggJPyEhrpAfXGX6f/ynqW5/FOp1v4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h8bI6y6UI1HW4jUf2Z7uvq1T40ZdwExcU2mwk+wO0tqfbDQJ1IbItXE6/tyVZBnweuYaFl1Rnj0D624k7uBPv0vbPQTaoP3xhfNnGYBeM5R6uUmj3pqNerKQSJbXBXkltU8RlsLDqp0wgiZwKcZl54kNsB3slRsZ5LysVySnsSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XfiMuoyV; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XfiMuoyV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774947534; x=1806483534; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FUPUgjK8/+PvpwggJPyEhrpAfXGX6f/ynqW5/FOp1v4=; b=XfiMuoyV4Qjg5rojr5boMK1ojcFkCYD0ylX3/dybqy0MOZTTPYpUc0ux HsIt7zYDUe3x4QMQ1H1hAW4rwOcQBNlM/TVxwg5qZbUlNAvd7P+3utiXA w/ZcFvBjdFUjJhGOxXrep2WrIqvvmAp7fF8lpS6Bzd3dME0utlVU+X5nh t2SXKmjiHdSgKpTqLzR+WfClkohl38iBCYMokTwzGQeVPPQCgRIcQXiSo 0jqTvsbazba8XN6MEOts/HJJqk9ugxsWrqo861ytcGNO5h7F/G+NFZ0DP pO27chUZG8lbtMDt66lC1rxMoZTTDrPiGYkXif66Kjfu0SPctmDVMegDG A==; X-CSE-ConnectionGUID: 83d4g1I1RuK6cPT7MKcd7w== X-CSE-MsgGUID: Am2LcPXNTT+r8y26gSOl3Q== X-IronPort-AV: E=McAfee;i="6800,10657,11744"; a="93536866" X-IronPort-AV: E=Sophos;i="6.23,151,1770624000"; d="scan'208";a="93536866" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2026 01:58:53 -0700 X-CSE-ConnectionGUID: DuuIgLTxRZyRcp5clt1jOA== X-CSE-MsgGUID: yoig1j+TR9SmrTbrMrvCTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,151,1770624000"; d="scan'208";a="231120906" Received: from rvuia-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.209]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2026 01:58:48 -0700 Date: Tue, 31 Mar 2026 11:58:46 +0300 From: Andy Shevchenko To: "Sabau, Radu bogdan" Cc: Andy Shevchenko , Lars-Peter Clausen , "Hennerich, Michael" , Jonathan Cameron , David Lechner , "Sa, Nuno" , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Philipp Zabel , Jonathan Corbet , Shuah Khan , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v5 2/4] iio: adc: ad4691: add initial driver for AD4691 family Message-ID: References: <20260327-ad4692-multichannel-sar-adc-driver-v5-0-11f789de47b8@analog.com> <20260327-ad4692-multichannel-sar-adc-driver-v5-2-11f789de47b8@analog.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Mar 31, 2026 at 08:36:42AM +0000, Sabau, Radu bogdan wrote: > > -----Original Message----- > > From: Andy Shevchenko > > Sent: Monday, March 30, 2026 8:24 PM ... > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > > > > Hmm... Is it used? Or perhaps you need only > > > > dev_printk.h > > > > device/devres.h > > > > ? > > > > > I have checked this out and it seems device.h doesn't actually need > > > to be included anyway since spi.h directly includes device.h, and since > > > this is a SPI driver that's never going away, it's covered. Will drop it! > > > > No, this is the wrong justification. IWYU principle is about exact > > match between what is used and included in a file (module). spi.h is > > not dev_*() provider and may not be considered for that. > > > > You are right, my justification was incorrect. Under IWYU, relying on > spi.h's transitive pull of device.h is not valid. However, I think device.h > is still needed in this case since struct device is used directly in the code > both as local variables and in the regmap callbacks. Really? I can't see that. (Hint: use of the data type and use of its pointer is a huge difference.) > Also dev_err_probe() is called directly and lives in device.h. No, as I started with my replies. The proper header that provides it is dev_printk.h. > What's your take on this? -- With Best Regards, Andy Shevchenko