public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: remoteproc: qcom: Drop types for firmware-name
@ 2026-03-09 12:33 Shawn Guo
  2026-03-09 15:35 ` Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Shawn Guo @ 2026-03-09 12:33 UTC (permalink / raw)
  To: Bjorn Andersson, Rob Herring
  Cc: Mathieu Poirier, Krzysztof Kozlowski, Conor Dooley,
	Stephan Gerhold, Sibi Sankar, Bartosz Golaszewski,
	Manivannan Sadhasivam, linux-arm-msm, linux-remoteproc,
	devicetree, linux-kernel, Shawn Guo

The type of firmware-name is already defined by core schemas.  Drop it
from individual bindings that have either a redundant definition or
an override as string type.  For the later cases, constrain the number
of expected firmware names to 1.

Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
Changes in v2:
- Add constraint of maxItems 1 for string type removal (Thanks to Krzysztof!)
- Link to v1: https://lore.kernel.org/all/20260306140306.1328719-1-shengchao.guo@oss.qualcomm.com/

 .../devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml    | 1 -
 .../devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml    | 1 -
 .../devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml        | 1 -
 .../devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml     | 1 -
 .../devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml     | 1 -
 .../devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml       | 2 +-
 .../devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml          | 2 +-
 .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml         | 1 -
 8 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
index c179b560572b..1e7c165f925e 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
@@ -137,7 +137,6 @@ properties:
       - description: MPSS reserved region
 
   firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string-array
     items:
       - description: Name of MBA firmware
       - description: Name of modem firmware
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
index 4d2055f283ac..1b65813cc8ad 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
@@ -126,7 +126,6 @@ properties:
       - description: Metadata reserved region
 
   firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string-array
     items:
       - description: Name of MBA firmware
       - description: Name of modem firmware
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
index 188a25194000..bcd2bcf96e24 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
@@ -51,7 +51,6 @@ properties:
     description: Reference to the AOSS side-channel message RAM.
 
   firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string-array
     items:
       - description: Firmware name of the Hexagon core
 
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
index b1402bef0ebe..7c9accac92d0 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
@@ -98,7 +98,6 @@ properties:
       - description: metadata reserved region
 
   firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string-array
     items:
       - description: Name of MBA firmware
       - description: Name of modem firmware
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml
index 005cb21732af..f349c303fa07 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml
@@ -98,7 +98,6 @@ properties:
       - description: metadata reserved region
 
   firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string-array
     items:
       - description: Name of MBA firmware
       - description: Name of modem firmware
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
index 5dbda3a55047..8227527c1d77 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
@@ -42,7 +42,7 @@ properties:
     description: Reference to the reserved-memory for the Hexagon core
 
   firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
     description: Firmware name for the Hexagon core
 
 required:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml
index 5d463272165f..8c4abde74915 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml
@@ -56,7 +56,7 @@ properties:
   smd-edge: false
 
   firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
     description: Firmware name for the Hexagon core
 
 required:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
index 11b056d6a480..27b8c127d74f 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
@@ -52,7 +52,6 @@ properties:
   smd-edge: false
 
   firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string-array
     items:
       - description: Firmware name of the Hexagon core
       - description: Firmware name of the Hexagon Devicetree
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: remoteproc: qcom: Drop types for firmware-name
  2026-03-09 12:33 [PATCH v2] dt-bindings: remoteproc: qcom: Drop types for firmware-name Shawn Guo
@ 2026-03-09 15:35 ` Krzysztof Kozlowski
  2026-03-31 11:16 ` Shawn Guo
  2026-04-06 15:10 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-09 15:35 UTC (permalink / raw)
  To: Shawn Guo, Bjorn Andersson, Rob Herring
  Cc: Mathieu Poirier, Krzysztof Kozlowski, Conor Dooley,
	Stephan Gerhold, Sibi Sankar, Bartosz Golaszewski,
	Manivannan Sadhasivam, linux-arm-msm, linux-remoteproc,
	devicetree, linux-kernel

On 09/03/2026 13:33, Shawn Guo wrote:
> The type of firmware-name is already defined by core schemas.  Drop it
> from individual bindings that have either a redundant definition or
> an override as string type.  For the later cases, constrain the number
> of expected firmware names to 1.
> 
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: remoteproc: qcom: Drop types for firmware-name
  2026-03-09 12:33 [PATCH v2] dt-bindings: remoteproc: qcom: Drop types for firmware-name Shawn Guo
  2026-03-09 15:35 ` Krzysztof Kozlowski
@ 2026-03-31 11:16 ` Shawn Guo
  2026-04-06 15:10 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2026-03-31 11:16 UTC (permalink / raw)
  To: Bjorn Andersson, Rob Herring
  Cc: Mathieu Poirier, Krzysztof Kozlowski, Conor Dooley,
	Stephan Gerhold, Sibi Sankar, Bartosz Golaszewski,
	Manivannan Sadhasivam, linux-arm-msm, linux-remoteproc,
	devicetree, linux-kernel

On Mon, Mar 09, 2026 at 08:33:57PM +0800, Shawn Guo wrote:
> The type of firmware-name is already defined by core schemas.  Drop it
> from individual bindings that have either a redundant definition or
> an override as string type.  For the later cases, constrain the number
> of expected firmware names to 1.
> 
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> ---
> Changes in v2:
> - Add constraint of maxItems 1 for string type removal (Thanks to Krzysztof!)
> - Link to v1: https://lore.kernel.org/all/20260306140306.1328719-1-shengchao.guo@oss.qualcomm.com/

Hi Bjorn,

Did you get a chance to look at it, or is there anything I should do
on my end?

Shawn

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: remoteproc: qcom: Drop types for firmware-name
  2026-03-09 12:33 [PATCH v2] dt-bindings: remoteproc: qcom: Drop types for firmware-name Shawn Guo
  2026-03-09 15:35 ` Krzysztof Kozlowski
  2026-03-31 11:16 ` Shawn Guo
@ 2026-04-06 15:10 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2026-04-06 15:10 UTC (permalink / raw)
  To: Rob Herring, Shawn Guo
  Cc: Mathieu Poirier, Krzysztof Kozlowski, Conor Dooley,
	Stephan Gerhold, Sibi Sankar, Bartosz Golaszewski,
	Manivannan Sadhasivam, linux-arm-msm, linux-remoteproc,
	devicetree, linux-kernel


On Mon, 09 Mar 2026 20:33:57 +0800, Shawn Guo wrote:
> The type of firmware-name is already defined by core schemas.  Drop it
> from individual bindings that have either a redundant definition or
> an override as string type.  For the later cases, constrain the number
> of expected firmware names to 1.
> 
> 

Applied, thanks!

[1/1] dt-bindings: remoteproc: qcom: Drop types for firmware-name
      commit: 74eb6cd91aef968ee792575f10b438ae2f2a2bb2

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-04-06 15:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-09 12:33 [PATCH v2] dt-bindings: remoteproc: qcom: Drop types for firmware-name Shawn Guo
2026-03-09 15:35 ` Krzysztof Kozlowski
2026-03-31 11:16 ` Shawn Guo
2026-04-06 15:10 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox