From: Bjorn Andersson <andersson@kernel.org>
To: Vivek Aknurwar <vivek.aknurwar@oss.qualcomm.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
Taniya Das <taniya.das@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Tipton <mike.tipton@oss.qualcomm.com>
Subject: Re: [PATCH 7/7] clk: qcom: Add support for global clock controller on Hawi
Date: Tue, 31 Mar 2026 16:11:22 -0500 [thread overview]
Message-ID: <acw4FDsIbgAUTHXo@baldur> (raw)
In-Reply-To: <20260330-clk-hawi-v1-7-c2a663e1d35b@oss.qualcomm.com>
On Mon, Mar 30, 2026 at 05:35:02PM -0700, Vivek Aknurwar wrote:
> +++ b/drivers/clk/qcom/gcc-hawi.c
[..]
> +static const struct qcom_cc_desc gcc_hawi_desc = {
> + .config = &gcc_hawi_regmap_config,
> + .clks = gcc_hawi_clocks,
> + .num_clks = ARRAY_SIZE(gcc_hawi_clocks),
> + .resets = gcc_hawi_resets,
> + .num_resets = ARRAY_SIZE(gcc_hawi_resets),
> + .gdscs = gcc_hawi_gdscs,
> + .num_gdscs = ARRAY_SIZE(gcc_hawi_gdscs),
> + .driver_data = &gcc_hawi_driver_data,
Sorry for not spotting this earlier, but don't we need a ".use_rpm =
true" here?
In line with
https://lore.kernel.org/all/20260309-glymur-fix-gcc-cx-scaling-v2-2-d7a58a0a9ecb@oss.qualcomm.com/
Regards,
Bjorn
> +};
> +
next prev parent reply other threads:[~2026-03-31 21:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 0:34 [PATCH 0/7] clk: qcom: Add initial clock controllers for the upcoming Hawi SoC Vivek Aknurwar
2026-03-31 0:34 ` [PATCH 1/7] dt-bindings: clock: qcom-rpmhcc: Add RPMHCC bindings for Hawi Vivek Aknurwar
2026-03-31 0:34 ` [PATCH 2/7] dt-bindings: clock: qcom: Add Hawi TCSR clock controller Vivek Aknurwar
2026-03-31 0:34 ` [PATCH 3/7] dt-bindings: clock: qcom: Add Hawi global " Vivek Aknurwar
2026-03-31 0:34 ` [PATCH 4/7] clk: qcom: rpmh: Add support for Hawi RPMH clocks Vivek Aknurwar
2026-03-31 9:08 ` Taniya Das
2026-03-31 9:30 ` Konrad Dybcio
2026-03-31 0:35 ` [PATCH 5/7] clk: qcom: Add Hawi TCSR clock controller driver Vivek Aknurwar
2026-03-31 9:13 ` Taniya Das
2026-03-31 0:35 ` [PATCH 6/7] clk: qcom: clk-alpha-pll: Add support for Taycan EHA_T PLL Vivek Aknurwar
2026-03-31 7:53 ` Konrad Dybcio
2026-03-31 9:10 ` Taniya Das
2026-03-31 0:35 ` [PATCH 7/7] clk: qcom: Add support for global clock controller on Hawi Vivek Aknurwar
2026-03-31 8:01 ` Konrad Dybcio
2026-03-31 9:13 ` Taniya Das
2026-03-31 21:11 ` Bjorn Andersson [this message]
2026-04-01 15:54 ` Mike Tipton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acw4FDsIbgAUTHXo@baldur \
--to=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.tipton@oss.qualcomm.com \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
--cc=vivek.aknurwar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox