From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Yassine Oudjana" <yassine.oudjana@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sam Shih <sam.shih@mediatek.com>,
Daniel Golle <daniel@makrotopia.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Yassine Oudjana <y.oudjana@protonmail.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/2] clk: mediatek: Add drivers for MediaTek MT6735 main clock and reset drivers
Date: Wed, 16 Oct 2024 11:57:12 +0200 [thread overview]
Message-ID: <ad000fdb-4474-49c4-9357-f23491231b07@collabora.com> (raw)
In-Reply-To: <vn466kmo2uqrf6ap54oat2bipj4lsfri7asnsrptrlthva6j5m@dop6xit2pzjk>
Il 16/10/24 11:28, Uwe Kleine-König ha scritto:
> Hello,
>
> On Thu, Oct 10, 2024 at 04:26:57PM +0300, Yassine Oudjana wrote:
>> +static struct platform_driver clk_mt6735_apmixedsys = {
>> + .probe = clk_mt6735_apmixed_probe,
>> + .remove_new = clk_mt6735_apmixed_remove,
>> + .driver = {
>> + .name = "clk-mt6735-apmixedsys",
>> + .of_match_table = of_match_mt6735_apmixedsys,
>> + },
>> +};
>
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers. Please just drop "_new".
>
Oh wow, I didn't notice that during my review. Sorry about that.
Cheers,
Angelo
next prev parent reply other threads:[~2024-10-16 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 13:26 [PATCH v6 0/2] MediaTek MT6735 main clock and reset drivers Yassine Oudjana
2024-10-10 13:26 ` [PATCH v6 1/2] dt-bindings: clock: Add MediaTek MT6735 clock and reset bindings Yassine Oudjana
2024-10-10 13:26 ` [PATCH v6 2/2] clk: mediatek: Add drivers for MediaTek MT6735 main clock and reset drivers Yassine Oudjana
2024-10-16 9:28 ` Uwe Kleine-König
2024-10-16 9:57 ` AngeloGioacchino Del Regno [this message]
2024-10-16 13:52 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad000fdb-4474-49c4-9357-f23491231b07@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sam.shih@mediatek.com \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=y.oudjana@protonmail.com \
--cc=yassine.oudjana@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).