public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-doc@vger.kernel.org,
	"Nuno Sá" <nuno.sa@analog.com>,
	linux-kernel@vger.kernel.org,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	devicetree@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Michael Hennerich" <michael.hennerich@analog.com>
Subject: Re: [PATCH 2/2] dt-bindings: iio: adc: adi,ad4695: change include path
Date: Wed, 13 Nov 2024 12:45:59 -0600	[thread overview]
Message-ID: <ad1b7946-02c4-4447-9b4b-1d57200f482f@baylibre.com> (raw)
In-Reply-To: <173152191678.1024361.7493718883312810903.robh@kernel.org>

On 11/13/24 12:18 PM, Rob Herring (Arm) wrote:
> 
> On Wed, 13 Nov 2024 10:55:20 -0600, David Lechner wrote:
>> Change the include path for the adi,ad4695.h header since it has been
>> moved to the include/dt-bindings/iio/adc/ directory.
>>
>> Signed-off-by: David Lechner <dlechner@baylibre.com>
>> ---
>>  Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/iio/adc/adi,ad4695.example.dts:19:18: fatal error: dt-bindings/iio/adc/adi,ad4695.h: No such file or directory
>    19 |         #include <dt-bindings/iio/adc/adi,ad4695.h>
>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Is this testing this patch without the other patch from this series?

I did run make `dt_binding_check DT_SCHEMA_FILES=adi,ad4695.yaml ...`
locally before sending the patch, so wasn't expecting an error here.

I know that normally we should be including the header change in the same
patch as the .yaml file, but in this case, I had to make an exception
because the same header is also included in a .c file. It seemed better
to not break compiling .c files rather than follow the rule strictly.

  reply	other threads:[~2024-11-13 18:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13 16:55 [PATCH 0/2] iio: adc: ad4695: move dt-bindings header David Lechner
2024-11-13 16:55 ` [PATCH 1/2] " David Lechner
2024-11-13 16:55 ` [PATCH 2/2] dt-bindings: iio: adc: adi,ad4695: change include path David Lechner
2024-11-13 18:18   ` Rob Herring (Arm)
2024-11-13 18:45     ` David Lechner [this message]
2024-11-15 15:30   ` Rob Herring (Arm)
2024-11-24 12:45 ` [PATCH 0/2] iio: adc: ad4695: move dt-bindings header Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad1b7946-02c4-4447-9b4b-1d57200f482f@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox