From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFCFFC43219 for ; Tue, 11 Oct 2022 18:57:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbiJKS5p (ORCPT ); Tue, 11 Oct 2022 14:57:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229960AbiJKS5c (ORCPT ); Tue, 11 Oct 2022 14:57:32 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92B9788A1C for ; Tue, 11 Oct 2022 11:57:16 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id b25so3254636qkk.7 for ; Tue, 11 Oct 2022 11:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=H7MRNW6m6g8CYG+UQ5OATy25MtYysQqA6sH5xmW6Gss=; b=qA9kaTexUkWg+qp1UcnfMNvLehR4FV9cS5z82Hj0lXBIFCZAhXO80XCI2VQa3o03pk Hc6Vl/F2KCyVLgLQhr6+lxnGy//pLe6YiTJ1itudB/yJGct2TaiapQmRnMIpM5G5io/u 1M9xPZY9qd6IkxLFbM7+GX2U5IhWdHkNdyr3Rp8DVEWg02S2vq66nhQXZ4Qi0FoN5Kga ozAVzu4qrS/3BjU2NlX1aas/GlaX05rJjJRDbI9RzWqn3p4JmgQ2pluyEisktyF/AqQ1 nXtB7O+mITpxtgOaMU+YbbkYggCDj4OJ5Y75PvMMdD/LVcJ98wvmXNU+390TaQka/dPh ORLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H7MRNW6m6g8CYG+UQ5OATy25MtYysQqA6sH5xmW6Gss=; b=o4bY9zy7dAi9nMcaZBzrQwbwiKKc4oQioyRcdFOLTzjdxVfPzP9J209MdgJXgEkvRE 4as2A0W5w0MLRSb5XUsnXcFSfE7jPRFxAuoWdR6t5ip0oq68fT1E+IEKkujD478oPNEc oS/hlZpuHSuFUrPdsT2iFRlZOuFimhBwrUmJRvzwNc/kq/vq7ct2eiaT2zT+MuZ2B+cc na5tg1trCEeTGsm0RIWeZFJc2iHGQAZOEfPV+HSbPgl+ZkQJiRiHgZZIvOYfh/M8mqW+ 4pA1NrfHhpoMuQMclwQ84qwilrcEofC65dBBnM2ayOdvA5yJcwvmggKURosbmqbSiX1l pb6w== X-Gm-Message-State: ACrzQf3lIc5wWy/xEf/nTxkxnrwYQlB1+RW1SDtkI3aKdBgSrkGsjkAu rHjk830ABTd1Po8yplGb15GnVg== X-Google-Smtp-Source: AMsMyM7gg7zRTMEQzLbIJsSJqlfTkKEGfwR/4SKbS8dVaDQ3ub/GEkm+hdHd0tPRkG0b/Z/8ks093Q== X-Received: by 2002:a05:620a:2043:b0:6ee:8874:f5bc with SMTP id d3-20020a05620a204300b006ee8874f5bcmr2201786qka.134.1665514625359; Tue, 11 Oct 2022 11:57:05 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id i14-20020a05620a248e00b006bba46e5eeasm14509356qkn.37.2022.10.11.11.57.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 11:57:04 -0700 (PDT) Message-ID: Date: Tue, 11 Oct 2022 14:54:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v4 1/4] dt-bindings: mfd: Document RZ/G2L MTU3a bindings Content-Language: en-US To: Biju Das , Rob Herring , Krzysztof Kozlowski , William Breathitt Gray , Thierry Reding Cc: Lee Jones , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "devicetree@vger.kernel.org" , "linux-pwm@vger.kernel.org" , Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad , "linux-renesas-soc@vger.kernel.org" References: <20221010145222.1047748-1-biju.das.jz@bp.renesas.com> <20221010145222.1047748-2-biju.das.jz@bp.renesas.com> <8d6b8f0e-d9d7-0d77-aa99-379de768fd5d@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/10/2022 10:55, Biju Das wrote: > >>> .../bindings/mfd/renesas,rz-mtu3.yaml | 305 >> ++++++++++++++++++ >>> 1 file changed, 305 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/mfd/renesas,rz-mtu3.yaml >> >> This should not be in MFD. Just because some device has few features, >> does not mean it should go to MFD... Choose either timer or pwm. > > MFD is for multifunction device. This IP supports multiple functions > like timer, pwm, clock source/events. That is the reason I have added > here. MFD is core which provides register access for client devices. > > For me moving it to pwm or counter is not a big problem. > Why do you think it cannot be MFD? Because it makes MFD a dump for everything where author did not want to think about real device aspects, but instead represented driver design (MFD driver). MFDs are pretty often combining unrelated features, e.g. PMICs which have wakeup and system power control, regulator, 32 kHz clocks, RTC and some USB connector. Just because you will have clocksource driver, PWM driver and timer driver does not make it a MFD. Best regards, Krzysztof