From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Nikita Travkin <nikita@trvn.ru>,
Stephan Gerhold <stephan@gerhold.net>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI
Date: Mon, 19 Jun 2023 15:12:09 +0200 [thread overview]
Message-ID: <ad43c064-0593-a30a-84eb-33618d0c868e@linaro.org> (raw)
In-Reply-To: <20230617171541.286957-3-krzysztof.kozlowski@linaro.org>
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> I2C and SPI controller bindings do not allow label property:
>
> apq8016-sbc.dtb: spi@78b7000: Unevaluated properties are not allowed ('label' was unexpected)
> apq8016-sbc.dtb: i2c@78b6000: Unevaluated properties are not allowed ('label' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> index f3d65a606194..e0993e32ee38 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -172,15 +172,13 @@ led@6 {
> };
>
> &blsp_i2c2 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-I2C0 */
> status = "okay";
> - label = "LS-I2C0";
> };
>
> &blsp_i2c4 {
> - /* On High speed expansion */
> + /* On High speed expansion: HS-I2C2 */
> status = "okay";
> - label = "HS-I2C2";
>
> adv_bridge: bridge@39 {
> status = "okay";
> @@ -228,21 +226,18 @@ adv7533_out: endpoint {
> };
>
> &blsp_i2c6 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-I2C1 */
> status = "okay";
> - label = "LS-I2C1";
> };
>
> &blsp_spi3 {
> - /* On High speed expansion */
> + /* On High speed expansion: HS-SPI1 */
> status = "okay";
> - label = "HS-SPI1";
> };
>
> &blsp_spi5 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-SPI0 */
> status = "okay";
> - label = "LS-SPI0";
> };
>
> &blsp_uart1 {
next prev parent reply other threads:[~2023-06-19 13:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
2023-06-17 17:15 ` [PATCH 02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply Krzysztof Kozlowski
2023-06-17 18:14 ` Nikita Travkin
2023-06-17 17:15 ` [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI Krzysztof Kozlowski
2023-06-19 13:12 ` Konrad Dybcio [this message]
2023-06-17 17:15 ` [PATCH 04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C Krzysztof Kozlowski
2023-06-19 13:12 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties Krzysztof Kozlowski
2023-06-19 13:12 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C Krzysztof Kozlowski
2023-06-19 13:13 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names Krzysztof Kozlowski
2023-06-19 13:13 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel " Krzysztof Kozlowski
2023-06-17 18:11 ` Nikita Travkin
2023-06-19 13:13 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth VDDIO supply Krzysztof Kozlowski
2023-06-19 13:14 ` Konrad Dybcio
2023-06-23 18:34 ` Doug Anderson
2023-06-24 7:39 ` Krzysztof Kozlowski
2023-06-17 17:15 ` [PATCH 10/15] arm64: dts: qcom: sc8180x: use generic ADC channel node names Krzysztof Kozlowski
2023-06-19 13:14 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 11/15] arm64: dts: qcom: sc8180x: align thermal node name with bindings Krzysztof Kozlowski
2023-06-19 13:14 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports Krzysztof Kozlowski
2023-06-19 13:15 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 13/15] arm64: dts: qcom: sc8180x-primus: " Krzysztof Kozlowski
2023-06-19 13:15 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings Krzysztof Kozlowski
2023-06-19 13:15 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup Krzysztof Kozlowski
2023-06-19 13:15 ` Konrad Dybcio
2023-06-17 18:25 ` [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Nikita Travkin
2023-07-10 5:07 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad43c064-0593-a30a-84eb-33618d0c868e@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).