From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80925C2D0EC for ; Fri, 10 Apr 2020 04:59:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 375692082D for ; Fri, 10 Apr 2020 04:59:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="qjFsBSZg"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="enmKH4Nz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725776AbgDJE7Z (ORCPT ); Fri, 10 Apr 2020 00:59:25 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:57553 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725208AbgDJE7Y (ORCPT ); Fri, 10 Apr 2020 00:59:24 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1E6AB5C0126; Fri, 10 Apr 2020 00:59:24 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Fri, 10 Apr 2020 00:59:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=l+pa00YeFhRWf3yUkvmzf5IhZ6ShPDi /vzUvd0fJVvs=; b=qjFsBSZgiFhNN9l/dKC+k62MkUgMy5ujwGm1s6+0xylmEYg vsnJKIm4oWB0UWEdy4vaXEFk3mAxItUJVP+q5+ao5ho8gem3Sc625G5unGx4OgOm H30a/N7QwOo9lXvV8C4EY61T3lFFW7txJdRRGdFHwXZJlOLG4ekOJTn2AEDPbo+N ITHxdfCb/BYMkh4AmzJxXfS19F8fbzM9IIPTeAvt955M0kXJ1RiitxXRr4cofKyd z7+HWVws5z6TOO1/YXKQvpG8PLQZRjJrcS0YwiHk9c/Vn7UZXu15CiluhQ88ZLfK NgJSD0tW6PzAPWcF9nYvx0hL0UL6fAqQTYR15Qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=l+pa00 YeFhRWf3yUkvmzf5IhZ6ShPDi/vzUvd0fJVvs=; b=enmKH4Nz6PE/EJf64TQkCA 9HLyeTr1EIPByCPzIAXdir3jniKho53M87mXXTZWuhKKhazpMn9Ltmx7gzqWReTx HGifv6FRl3ErADvQWzMwUWGHjpUGBj4tmGrhXK34ADG9rVHmAS+IWT+392V4VH+B bPZUbCSfBEwbIKLCINyz2vusggC3tqrZlg+ZaiDkW4f/3RS6OIU3eW4dU+7zXxeh h4GsT7WG/Pr8Ra+3o9rinhAx7j9/Kp0WwMtQ6y6+VE1nY/yEQzjSyDKoQPnL7Tjv M9GlNXb+hc9tJCNqIr5ua//khSYSTE80GSMcin7eCGl6j8N3iF+8sKrY1ByJkJoQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvddugdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvfiesrghj rdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 38DB7E00A5; Fri, 10 Apr 2020 00:59:23 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-1104-g203475c-fmstable-20200408v2 Mime-Version: 1.0 Message-Id: In-Reply-To: <20200406101553.28958-1-a.filippov@yadro.com> References: <20200406101553.28958-1-a.filippov@yadro.com> Date: Fri, 10 Apr 2020 14:29:47 +0930 From: "Andrew Jeffery" To: "Alexander A. Filippov" , linux-aspeed@lists.ozlabs.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, "Joel Stanley" , "Rob Herring" Subject: Re: [PATCH] ARM: DTS: Aspeed: Add YADRO Nicole BMC Content-Type: text/plain Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 6 Apr 2020, at 19:45, Alexander Filippov wrote: > Nicole is an OpenPower machine with an Aspeed 2500 BMC SoC manufactured > by YADRO. > > Signed-off-by: Alexander Filippov > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/aspeed-bmc-opp-nicole.dts | 284 ++++++++++++++++++++ > 2 files changed, 285 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed-bmc-opp-nicole.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index e8dd99201397..6f9fe0f959f2 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1347,6 +1347,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-microsoft-olympus.dtb \ > aspeed-bmc-opp-lanyang.dtb \ > aspeed-bmc-opp-mihawk.dtb \ > + aspeed-bmc-opp-nicole.dtb \ > aspeed-bmc-opp-palmetto.dtb \ > aspeed-bmc-opp-romulus.dtb \ > aspeed-bmc-opp-swift.dtb \ > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-nicole.dts > b/arch/arm/boot/dts/aspeed-bmc-opp-nicole.dts > new file mode 100644 > index 000000000000..0c8a9e7838ff > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-nicole.dts > @@ -0,0 +1,284 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +// Copyright 2019 YADRO > +/dts-v1/; > +#include "aspeed-g5.dtsi" > +#include > + > +/ { > + model = "Nicole BMC"; > + compatible = "yadro,nicole-bmc", "aspeed,ast2500"; > + > + chosen { > + stdout-path = &uart5; > + bootargs = "console=ttyS4,115200 earlyprintk"; > + }; > + > + memory@80000000 { > + reg = <0x80000000 0x20000000>; > + }; > + > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + vga_memory: framebuffer@9f000000 { > + no-map; > + reg = <0x9f000000 0x01000000>; /* 16M */ > + }; > + > + flash_memory: region@98000000 { > + no-map; > + reg = <0x98000000 0x04000000>; /* 64M */ > + }; > + > + coldfire_memory: codefire_memory@9ef00000 { > + reg = <0x9ef00000 0x00100000>; > + no-map; > + }; > + > + gfx_memory: framebuffer { > + size = <0x01000000>; > + alignment = <0x01000000>; > + compatible = "shared-dma-pool"; > + reusable; > + }; > + > + video_engine_memory: jpegbuffer { > + size = <0x02000000>; /* 32M */ > + alignment = <0x01000000>; > + compatible = "shared-dma-pool"; > + reusable; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + > + power { > + gpios = <&gpio ASPEED_GPIO(AA, 4) GPIO_ACTIVE_HIGH>; > + }; > + > + identify { > + gpios = <&gpio ASPEED_GPIO(AA, 7) GPIO_ACTIVE_HIGH>; > + }; > + > + alarm_red { > + gpios = <&gpio ASPEED_GPIO(AA, 3) GPIO_ACTIVE_HIGH>; > + }; > + > + alarm_yellow { > + gpios = <&gpio ASPEED_GPIO(AA, 1) GPIO_ACTIVE_HIGH>; > + }; > + }; > + > + fsi: gpio-fsi { > + compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master"; > + #address-cells = <2>; > + #size-cells = <0>; > + no-gpio-delays; > + > + memory-region = <&coldfire_memory>; > + aspeed,sram = <&sram>; > + aspeed,cvic = <&cvic>; > + > + clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>; > + data-gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_HIGH>; > + mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>; > + enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>; > + trans-gpios = <&gpio ASPEED_GPIO(P, 1) GPIO_ACTIVE_HIGH>; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + checkstop { > + label = "checkstop"; > + gpios = <&gpio ASPEED_GPIO(J, 2) GPIO_ACTIVE_LOW>; > + linux,code = ; > + }; > + }; > +}; > + > +&fmc { > + status = "okay"; > + flash@0 { > + status = "okay"; > + m25p,fast-read; > + label = "bmc"; > + spi-max-frequency = <50000000>; > +#include "openbmc-flash-layout.dtsi" > + }; > +}; > + > +&spi1 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_spi1_default>; > + > + flash@0 { > + status = "okay"; > + m25p,fast-read; > + label = "pnor"; > + spi-max-frequency = <100000000>; > + }; > +}; > + > +&lpc_ctrl { > + status = "okay"; > + memory-region = <&flash_memory>; > + flash = <&spi1>; > +}; > + > +&uart1 { > + /* Rear RS-232 connector */ > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_txd1_default > + &pinctrl_rxd1_default > + &pinctrl_nrts1_default > + &pinctrl_ndtr1_default > + &pinctrl_ndsr1_default > + &pinctrl_ncts1_default > + &pinctrl_ndcd1_default > + &pinctrl_nri1_default>; > +}; > + > +&uart5 { > + status = "okay"; > +}; > + > +&mac0 { > + status = "okay"; > + > + use-ncsi; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rmii1_default>; > + clocks = <&syscon ASPEED_CLK_GATE_MAC1CLK>, > + <&syscon ASPEED_CLK_MAC1RCLK>; > + clock-names = "MACCLK", "RCLK"; > +}; > + > +&i2c0 { > + status = "okay"; > + > + eeprom@50 { > + compatible = "atmel,24c256"; > + reg = <0x50>; > + pagesize = <64>; > + }; > +}; > + > +&i2c1 { > + status = "okay"; > +}; > + > +&i2c2 { > + status = "okay"; > +}; > + > +&i2c3 { > + status = "okay"; > +}; > + > +&i2c4 { > + status = "okay"; > +}; > + > +&i2c5 { > + status = "okay"; > +}; > + > +&i2c6 { > + status = "okay"; > + > + rtc@32 { > + compatible = "epson,rx8900"; > + reg = <0x32>; > + }; > +}; > + > +&i2c7 { > + status = "okay"; > +}; > + > +&i2c8 { > + status = "okay"; > +}; > + > +&i2c9 { > + status = "okay"; > +}; > + > +&i2c10 { > + status = "okay"; > +}; > + > +&i2c11 { > + status = "okay"; > +}; > + > +&i2c12 { > + status = "okay"; > +}; Are you accessing devices on the busses from userspace? It would be helpful to comment here why you're enabling all of these busses but not describing any devices on them, if it's necessary to enable them at all. > + > +&gpio { > + nic_func_mode0 { > + gpio-hog; > + gpios = ; > + output-low; > + line-name = "nic_func_mode0"; > + }; > + nic_func_mode1 { > + gpio-hog; > + gpios = ; > + output-low; > + line-name = "nic_func_mode1"; > + }; > + seq_cont { > + gpio-hog; > + gpios = ; > + output-low; > + line-name = "seq_cont"; > + }; > + ncsi_cfg { > + gpio-hog; > + input; > + gpios = ; > + line-name = "ncsi_cfg"; > + }; > +}; > + > +&vuart { > + status = "okay"; > +}; > + > +&gfx { > + status = "okay"; > + memory-region = <&gfx_memory>; > +}; > + > +&pinctrl { > + aspeed,external-nodes = <&gfx &lhc>; > +}; > + > +&ibt { > + status = "okay"; > +}; > + > +&vhub { > + status = "okay"; > +}; > + > +&adc { > + status = "okay"; You should specify the pinmux configuration for the channels you're using to ensure exclusive access to those pins (otherwise they could be exported e.g. as GPIOs). Andrew