From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Waqar Hameed <waqar.hameed@axis.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: kernel@axis.com, linux-rtc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: rtc: Add Epson RX8111
Date: Sat, 5 Aug 2023 22:28:05 +0200 [thread overview]
Message-ID: <ad4dfefc-f18a-5462-eb6d-fdee161f87b3@linaro.org> (raw)
In-Reply-To: <864b398918e99773f6cbd5ffe5b1f0dc33e4d6d1.1691158774.git.waqar.hameed@axis.com>
On 04/08/2023 16:19, Waqar Hameed wrote:
> Epson RX8111 is an RTC with timestamp functionality. Add devicetree
> bindings requiring the compatible string and I2C slave address (reg).
> +
> +maintainers:
> + - Waqar Hameed <waqar.hameed@axis.com>
> +
> +description: |
> + RTC with timestamp functionality.
> +
> + https://support.epson.biz/td/api/doc_check.php?dl=app_RX8111CE&lang=en
> +
> +properties:
> + compatible:
> + const: epson,rx8111
> +
> + reg:
> + const: 0x32
> +
> +required:
> + - compatible
> + - reg
Just add it to trivial-rtc.yaml. You miss here more things than trivial
is providing, so...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-05 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 14:19 [PATCH 0/2] Add a driver for Epson RX8111 RTC Waqar Hameed
2023-08-04 14:19 ` [PATCH 1/2] dt-bindings: rtc: Add Epson RX8111 Waqar Hameed
2023-08-05 20:28 ` Krzysztof Kozlowski [this message]
2023-08-07 21:02 ` Waqar Hameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad4dfefc-f18a-5462-eb6d-fdee161f87b3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).