From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.Li@nxp.com>, Yangbo Lu <yangbo.lu@nxp.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
Sean Anderson <sean.anderson@seco.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v2 1/2] dt-bindings: ptp: Convert ptp-qoirq to yaml format
Date: Wed, 19 Jun 2024 08:33:25 +0200 [thread overview]
Message-ID: <ad5acbf2-b787-42a0-9c6a-998772f25398@kernel.org> (raw)
In-Reply-To: <20240618-ls_fman-v2-1-f00a82623d8e@nxp.com>
On 18/06/2024 23:53, Frank Li wrote:
> Convert ptp-qoirq from txt to yaml format.
>
> Additional change:
> - Fixed example interrupts proptery. Need only 1 irq by check MPC8313 spec.
> - Move Reference clock context under clk,sel.
> - Interrupts is not required property.
> - Use low case for hex value.
> - Check reference manual of MPC8313, p1010 and so on, which dts use more
> than 1 irqs. Only 1 irq for each ptp device. Check driver code
> (drivers/ptp/ptp_qoriq.c) and only 1 irq used. So original description is
> wrong.
> - Remove comments for compatible string.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>
> ---
> Change from v1 to v2:
> - fix make refcheckdocs warning
> - Use low case for hex value
> - Remove comments for compatible string.
> - Only 1 irq
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-19 6:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 21:53 [PATCH v2 0/2] dt-bindings: net: Convert fsl,fman related file to yaml format Frank Li
2024-06-18 21:53 ` [PATCH v2 1/2] dt-bindings: ptp: Convert ptp-qoirq " Frank Li
2024-06-19 6:33 ` Krzysztof Kozlowski [this message]
2024-06-18 21:53 ` [PATCH v2 2/2] dt-bindings: net: Convert fsl-fman to yaml Frank Li
2024-06-19 6:35 ` Krzysztof Kozlowski
2024-06-21 3:30 ` [PATCH v2 0/2] dt-bindings: net: Convert fsl,fman related file to yaml format patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad5acbf2-b787-42a0-9c6a-998772f25398@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sean.anderson@seco.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).