Re: [PATCH 4/7] dt-bindings: leds: irled: ir-spi-led: Add new duty-cycle value

[Krzysztof Kozlowski <krzk@kernel.org>]

On 27/03/2026 09:41, Sean Young wrote:
> On Fri, Mar 27, 2026 at 08:51:18AM +0100, Krzysztof Kozlowski wrote:
>> On Wed, Mar 25, 2026 at 06:07:27PM +0000, Biswapriyo Nath wrote:
>>> 30 duty cycle for IR transmitter is used in Xiaomi Redmi Note 8 (ginkgo).
>>>
>>> Signed-off-by: Biswapriyo Nath <nathbappai@gmail.com>
>>> ---
>>>  Documentation/devicetree/bindings/leds/irled/ir-spi-led.yaml | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/irled/ir-spi-led.yaml b/Documentation/devicetree/bindings/leds/irled/ir-spi-led.yaml
>>> index 72cadebf6e3..0297bfbb275 100644
>>> --- a/Documentation/devicetree/bindings/leds/irled/ir-spi-led.yaml
>>> +++ b/Documentation/devicetree/bindings/leds/irled/ir-spi-led.yaml
>>> @@ -25,7 +25,7 @@ properties:
>>>  
>>>    duty-cycle:
>>>      $ref: /schemas/types.yaml#/definitions/uint8
>>> -    enum: [50, 60, 70, 75, 80, 90]
>>> +    enum: [30, 50, 60, 70, 75, 80, 90]
>>
>> Hm, why is this enum, instead of 1-99, in the first place?
> 
> Well in reality only a few different duty cycles are used by IR protocols.
> 30% is quite common so that should part of the list. 
> 
> Having said that a range of 1-99 would be nicer. Do we set this like so:
> 
>  - minimum: 1
>  - maximum: 99

I asked, because I don't know what hardware is really there. This should
match reality, so if you say continuous range is never used, it does not
have the be changed to 1-99.


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof