From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Andrew F. Davis" Subject: Re: [PATCH 1/6] dt-bindings: phy: am654-mmc-phy: Document new phy bindings Date: Fri, 5 Oct 2018 10:58:30 -0500 Message-ID: References: <20181004111451.9539-1-faiz_abbas@ti.com> <20181004111451.9539-2-faiz_abbas@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181004111451.9539-2-faiz_abbas@ti.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Faiz Abbas , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mmc@vger.kernel.org Cc: kishon@ti.com, ulf.hansson@linaro.org, robh+dt@kernel.org, catalin.marinas@arm.com, adrian.hunter@intel.com List-Id: devicetree@vger.kernel.org On 10/04/2018 06:14 AM, Faiz Abbas wrote: > Add information to document bindings for the MMC PHY > on TI's AM654 devices. > > Signed-off-by: Faiz Abbas > Signed-off-by: Sekhar Nori > --- > .../devicetree/bindings/phy/am654-mmc-phy.txt | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/am654-mmc-phy.txt > > diff --git a/Documentation/devicetree/bindings/phy/am654-mmc-phy.txt b/Documentation/devicetree/bindings/phy/am654-mmc-phy.txt > new file mode 100644 > index 000000000000..766921612758 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/am654-mmc-phy.txt Name ti,am654-mmc-phy.txt might be more consistent name. > @@ -0,0 +1,42 @@ > +TI AM654 MMC PHY > +------------------- > + > +Required properties: > + - compatible: ti,am654-emmc-phy > + - #phy-cells: must be 0 > + - reg: PHY registers address offset and size > + - clocks: must be phandle of the clock provider which is the host > + controller > + - clock-names: must be "mmcclk" > + - ti,otap-del-sel: Output Tap Delay select. > + - ti,trm-icp: DLL trim select. > + - ti,driver-strength-ohm: driver strength in ohms. > + Valid values are 33, 40, 50, 66, and 100 ohms. > + > +Example: > + mmc_phy1: mmc_phy@10100 { > + compatible = "ti,am654-mmc-phy"; > + reg = <0x10100 0x34>; > + clocks = <&sdhci1>; > + clock-names = "mmcclk"; > + #phy-cells = <0>; > + ti,otap-del-sel = <0x2>; > + ti,trm-icp = <0x8>; > + status = "disabled"; No need for disabled in the example case. Also not sure the host controller example below needs to be here, there are already examples for that binding in mmc/arasan,sdhci.txt. Andrew > + }; > + > +Host controller node: > + > + sdhci1: sdhci@0 { > + compatible = "ti,am654-sdhci-5.1"; > + reg = <0x0 0x1000>; > + power-domains = <&k3_pds 48>; > + clocks = <&k3_clks 48 0>, <&k3_clks 48 1>; > + clock-names = "clk_ahb", "clk_xin"; > + interrupts = ; > + clock-output-names = "mmc_cardclck"; > + #clock-cells = <0>; > + phys=<&mmc_phy1>; > + phy-names = "phy_arasan"; > + status = "disabled"; > + }; >