Re: [PATCH] arm64: dts: qcom: monaco-pmics: Add PON power key and reset inputs

Rakesh Kota
2026-04-15T10:24:52Z

On Fri, Jan 30, 2026 at 12:18:53PM +0100, Konrad Dybcio wrote:
> On 1/22/26 7:59 AM, Rakesh Kota wrote:
> > Add the Power On (PON) peripheral with power key and reset input
> > support for the PMM8654AU PMIC on Monaco platforms.
> >
> > Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
> > ---
> > arch/arm64/boot/dts/qcom/monaco-pmics.dtsi | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi b/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi
> > index e990d7367719beaa9e0cea87d9c183ae18c3ebc8..051407cd83eef8eace8521084b1ad012a5192ace 100644
> > --- a/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi
> > @@ -13,6 +13,26 @@ pmm8620au_0: pmic@0 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > + pmm8654au_0_pon: pon@1200 {
> > + compatible = "qcom,pmk8350-pon";
>
> I see pmm8655x has some slight changes vs pmk8350 (more configs but
> generally backwards compatible if we don't use them), let's add a
> separate compatible in bindings so that we can maybe handle these
> differences down the line:
>
> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> index 979a377cb4ff..14b85b0d97da 100644
> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> @@ -17,12 +17,16 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - qcom,pm8916-pon
> - - qcom,pm8941-pon
> - - qcom,pms405-pon
> - - qcom,pm8998-pon
> - - qcom,pmk8350-pon
> + oneOf:
> + - enum:
> + - qcom,pm8916-pon
> + - qcom,pm8941-pon
> + - qcom,pms405-pon
> + - qcom,pm8998-pon
> + - qcom,pmk8350-pon
> + - items:
> + - const: qcom,pmm8654au-pon
> + - const: qcom,pmk8350-pon
>

Hi Konrad,

Based on the below discussion:
https://lore.kernel.org/all/872faa80-d323-4625-ab8f-50ab2e0e8e0f@kernel.org/

I understand that introducing new compatibles without a corresponding driver
change is not acceptable per upstream community guidelines. As Krzysztof pointed out,
neew compatibles must be accompanied by the necessary driver support.

so,shall we use the old compatible in the current patch series for now ?
And Resume the patch series at https://lore.kernel.org/linux-arm-msm/9c7521fe-5008-4daa-945b-ce3f5c0f6dc0@kernel.org/
once the driver changes are ready and upstreamed ?

reagrs
Rakesh Kota
>
>
> Konrad