From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 077EE33374F; Sat, 4 Apr 2026 19:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775330967; cv=none; b=lEiF3D5nsz/g8M4d80I+uDDzVVJh5A91PrKfWO++sMd2uLhqlH0AeGZDoJLzg6SmOX2T/rriP9eTIfkBbkpXQzIY1TQtD1pspnFvh+gSdOnC1TUft7mYkMHfwEyeMKFglUuem12AcGHBXNThF1+zKnJg8Dum+6KFddAdxgrmxgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775330967; c=relaxed/simple; bh=2E1gTTWRwsIHkMmrL5iB62nZPdYsU2MVVF0OYAc73aw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k+tWzMCTxcU+sYMdYh0eAkwQb9PdNPx67wF5Aun3nxKkhUo1g2vc/CJ06ig64rYOXR0BNGOuc7klz0cIK1iZCmrDCaQc9lhiwPXHmJ0TrVhdGFONLw25tUABP1QVtGjpVUCgJ0NI4F8YuBS2/Yq/sLrfQFQkQPbdkhljns18ggA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LI7uZhpu; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LI7uZhpu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775330966; x=1806866966; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=2E1gTTWRwsIHkMmrL5iB62nZPdYsU2MVVF0OYAc73aw=; b=LI7uZhpukbDdxBoSLEkUVFse5ALYaShkEXcFPXhcej1OX+EL19XIvv5O 8gCPnmDK8TGIYa/XfoLE2C7I9DUmsXlBSNGNpDUNFxnWnxt9G7iAn7iIJ 8Bd/8DGxQsEtyttIJkh/Y3sdluvzqArjlMtq3zJ2zso9BKc279wtRVrbe vCsztPDGXKG9j6pmw3EZuMQNg32A74h7xkkbN93FLVq+fK9GdyBjPsdfv WUUwsXOu4cc+cgxzaIs83U9/X/rwWLFcE2ajdtMCrDfaBWomFDpUh/t4I 0LYAjMO1Y9Hrw/m95Jo3V9I4+SU8KWTOItbJH3Nluy97lFLsxRMgWQxBC Q==; X-CSE-ConnectionGUID: 5SnKuludTA25fafBCa+jHw== X-CSE-MsgGUID: d/LHyuWzT4i1EewQKYaQfg== X-IronPort-AV: E=McAfee;i="6800,10657,11749"; a="93932728" X-IronPort-AV: E=Sophos;i="6.23,160,1770624000"; d="scan'208";a="93932728" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2026 12:29:25 -0700 X-CSE-ConnectionGUID: K8myanjUTEy374+50JRCaA== X-CSE-MsgGUID: +xiCcFggSIG8y9nPciWRWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,160,1770624000"; d="scan'208";a="250615393" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.247]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2026 12:29:22 -0700 Date: Sat, 4 Apr 2026 22:29:20 +0300 From: Andy Shevchenko To: Antony Kurniawan Soemardi Cc: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH v2 2/3] iio: adc: qcom-pm8xxx-xoadc: remove redundant error logging in pm8xxx_read_raw Message-ID: References: <20260403-pm8xxx-xoadc-label-v2-0-29b50bf821e6@smankusors.com> <20260403-pm8xxx-xoadc-label-v2-2-29b50bf821e6@smankusors.com> <35urrjc3koye5zhlxatdsr7t2djuml5ueyhhazcucow3q3g5f2@pomnrrcwu7qr> <1b47a581-3a2b-490c-8a39-7a2cd0ddf8f2@smankusors.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1b47a581-3a2b-490c-8a39-7a2cd0ddf8f2@smankusors.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sat, Apr 04, 2026 at 03:26:32AM +0000, Antony Kurniawan Soemardi wrote: > On 4/4/2026 4:54 AM, Dmitry Baryshkov wrote: > > Does it also prevent users from spamming the dmesg? > > It should be for no such channel case. The only remaining error logs > from pm8xxx_read_raw are timeout errors, which I don’t think would > result in immediate spamming. Or should we remove the dev_err (at > pm8xxx_read_channel_rsv) on timeout errors too? Does the user get -ETIMEDOUT? If so, yes, message may be removed. -- With Best Regards, Andy Shevchenko