From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0022B288C13 for ; Sun, 12 Oct 2025 15:04:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760281487; cv=none; b=Kf+y7nAvk4R6Do63Xk7WJniYdJHSB2M1/CTWJXGad4WewHHS3gkk4DHmzQ3nMyFDDKMvctgIA7fNYvcOXZTSU2dPWc7VwMS7FALkNZFLftPsCj2TrAMyD9GtipXapqnZLR9rCeBS1j/bABfDPsRXgzDeygVZdALzI5qsKzXvAZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760281487; c=relaxed/simple; bh=OeCCMF9AcXLG29Pk7q6X5M/KcH0ku8Exfiu7RFLfqZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VuRUolN+ed+78THWgugaND+N2fd77H2pBX80tUefntFKDzcihqptSNb0B0CSq+gC7m+YVJIWrMjSHecDrjX7RANnfxO3xQVHhMumxqaqk/4SgUK+1yeypIIWNHTvW9jscSABD92wVs9UoX4rklsH6ebeuq+q/n+sxwptxezGE7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1v7xcb-0007bV-LG; Sun, 12 Oct 2025 17:04:29 +0200 Message-ID: Date: Sun, 12 Oct 2025 17:04:26 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] arm64: dts: add Protonic PRT8ML board To: Peng Fan Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Shengjiu Wang , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , Vladimir Oltean , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, David Jander , Lucas Stach , Oleksij Rempel References: <20250924-imx8mp-prt8ml-v3-0-f498d7f71a94@pengutronix.de> <20250924-imx8mp-prt8ml-v3-3-f498d7f71a94@pengutronix.de> <20251012023714.GF20642@nxa18884-linux.ap.freescale.net> Content-Language: en-US From: Jonas Rebmann In-Reply-To: <20251012023714.GF20642@nxa18884-linux.ap.freescale.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: jre@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Hi Peng On 2025-10-12 04:37, Peng Fan wrote: > On Wed, Sep 24, 2025 at 10:34:14AM +0200, Jonas Rebmann wrote: >> +&a53_opp_table { >> + opp-1200000000 { >> + opp-microvolt = <900000>; >> + }; >> + >> + opp-1600000000 { >> + opp-microvolt = <980000>; >> + }; >> + >> + /delete-node/ opp-1800000000; > > Why drop this? > The board is designed for the industrial variant of the i.MX 8M Plus and therefore only for the 1.2GHz and 1.6GHz modes. There exist however some units which which where assembled with the consumer variant. As the power supply is not outfitted for their 1.8GHz mode, it must be disabled. I'll add a comment in v4. >> +}; >> + >> +&ecspi2 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_ecspi2>; >> + cs-gpios = <&gpio5 13 GPIO_ACTIVE_HIGH>; > >> + /delete-property/ dmas; >> + /delete-property/ dma-names; > > Why remove dmas? Sadly, in drivers/spi-imx.c we don't have proper heuristics to choose on which chips to use dma or to use polling at which speeds and transfer sizes. Therefore in cases where there is a high number of small transfers, for which dma is inefficient, this way of manually disabling dma is the only current way of meeting specific performance requirements. I'll add a comment in v4. >> + status = "okay"; >> + >> + >> +&iomuxc { >> + >> + pinctrl_tps65987ddh_0: tps65987ddh_0grp { > > tps65987ddh_0grp - > tps65987ddh-0grp > >> + fsl,pins = < >> + MX8MP_IOMUXC_GPIO1_IO12__GPIO1_IO12 0x1d0 >> + >; >> + }; >> + >> + pinctrl_tps65987ddh_1: tps65987ddh_1grp { > > tps65987ddh_1grp -> tps65987ddh-1grp Will rename those in 4v. Regards, Jonas -- Pengutronix e.K. | Jonas Rebmann | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |