From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Khouloud Touil <ktouil@baylibre.com>,
bgolaszewski@baylibre.com, robh+dt@kernel.org,
mark.rutland@arm.com, baylibre-upstreaming@groups.io
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-i2c@vger.kernel.org, linus.walleij@linaro.org
Subject: Re: [PATCH v2 2/4] nvmem: add support for the write-protect pin
Date: Thu, 19 Dec 2019 10:58:17 +0000 [thread overview]
Message-ID: <adc6cace-5ee8-5e17-3edc-79b35f00159c@linaro.org> (raw)
In-Reply-To: <20191210154157.21930-3-ktouil@baylibre.com>
On 10/12/2019 15:41, Khouloud Touil wrote:
> The write-protect pin handling looks like a standard property that
> could benefit other users if available in the core nvmem framework.
>
> Instead of modifying all the memory drivers to check this pin, make
> the NVMEM subsystem check if the write-protect GPIO being passed
> through the nvmem_config or defined in the device tree and pull it
> low whenever writing to the memory.
>
> There was a suggestion for introducing the gpiodesc from pdata, but
> as pdata is already removed it could be replaced by adding it to
> nvmem_config.
>
> Reference: https://lists.96boards.org/pipermail/dev/2018-August/001056.html
>
> Signed-off-by: Khouloud Touil <ktouil@baylibre.com>
> ---
> drivers/nvmem/core.c | 19 +++++++++++++++++--
> drivers/nvmem/nvmem.h | 2 ++
> include/linux/nvmem-provider.h | 3 +++
> 3 files changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
next prev parent reply other threads:[~2019-12-19 10:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 15:41 [PATCH v2 0/4] at24: move write-protect pin handling to nvmem core Khouloud Touil
2019-12-10 15:41 ` [PATCH v2 1/4] dt-bindings: nvmem: new optional property write-protect-gpios Khouloud Touil
2019-12-16 8:08 ` Linus Walleij
2019-12-18 11:10 ` Khouloud Touil
2019-12-10 15:41 ` [PATCH v2 2/4] nvmem: add support for the write-protect pin Khouloud Touil
2019-12-16 8:09 ` Linus Walleij
2019-12-19 10:58 ` Srinivas Kandagatla [this message]
2019-12-10 15:41 ` [PATCH v2 3/4] dt-bindings: at24: remove the optional property write-protect-gpios Khouloud Touil
2019-12-16 8:11 ` Linus Walleij
2019-12-10 15:41 ` [PATCH v2 4/4] eeprom: at24: remove the write-protect pin support Khouloud Touil
2019-12-16 8:13 ` Linus Walleij
2019-12-16 11:03 ` Bartosz Golaszewski
2019-12-19 10:51 ` [PATCH v2 0/4] at24: move write-protect pin handling to nvmem core Srinivas Kandagatla
2019-12-19 10:53 ` Bartosz Golaszewski
2019-12-19 10:56 ` Srinivas Kandagatla
2019-12-19 10:59 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adc6cace-5ee8-5e17-3edc-79b35f00159c@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=baylibre-upstreaming@groups.io \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=ktouil@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).