From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD211C43334 for ; Wed, 8 Jun 2022 10:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236540AbiFHKYS (ORCPT ); Wed, 8 Jun 2022 06:24:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236429AbiFHKXA (ORCPT ); Wed, 8 Jun 2022 06:23:00 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B323E1F379A for ; Wed, 8 Jun 2022 03:11:47 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id x62so26380563ede.10 for ; Wed, 08 Jun 2022 03:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=mygdx+EWNce3HPDkrN+VDocEDtdpxehguvhwMJDyyeI=; b=PAAKqLB62Hf/CGzyWWAYkLIyFRIVbTaQknYin4XTddJKhLILqUaH/h+ROZBMEzpWG9 QvZNQgojCeVWEyVWWvz52S0tjhNRD5zUpMdD+SSF4PFZw4Kzmfa3vqiqt3HVjg/mIEgA CUgcFu3b8gEdphdAFko5DtnElqBmE4T0Uk7F2XTl9/goXCdVZaoGEOgKv7QEO7Nhvoqh ZtZx8/7BFoPuNznm/pVcXHiHxsqKTyH5/8i39BW8eM4qLIm/hxWdIsb5PmO+oNG5mqbI 3j5K3G0lMJISK4JnFAKs+uO/4kFyh4MSo16lSqaiAMgTjLW3UcBytzBo1km+4BzgDKWo 7hLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mygdx+EWNce3HPDkrN+VDocEDtdpxehguvhwMJDyyeI=; b=WxmKcV6rSsm0QXGPPAj9JW++rz0CGrskBYVWyEjqcHJ2HIzgMEyAzkWFnhWE9ZR8/k CNekpFB1gRpdDlK68QJg/VtK21IRSgA20eYWRXYP+N4HUNru9McFDyjnze/TB81hwSz1 uZRKTUHHBHXpWBQIr8j5qrMo6pt7AKBA3btjsQYhYS8ylBCSOzkiASx+oZz7iQv4cAzV DXQGVZDwkETJkdHBRSzCT4tfoG3O4o75AbTX6LGGsfN5YNDjyzlPdw/C/V2jF8O3bP4L aL1QPbX/SA1Sr8SdhLzLYErO/PBCva3J0UDcnAym4c3gM2kw9U+CTg4f58RO0db1BrP6 LG4g== X-Gm-Message-State: AOAM533xTtjH6QicYw8rdcwF+uWO9eLk3VE3M0TPpzMbx1QhauyxDoFe eGO6ZqTFXtl89xLTK63TszxnLQ== X-Google-Smtp-Source: ABdhPJz6yzZ0SRBcoSfjLq/PRs3lNBoAcpo1IGSW4puqEJVVItF1fjdsK3KOv8VpyJU205TN8zsZrA== X-Received: by 2002:aa7:d6d5:0:b0:431:b7c0:50c9 with SMTP id x21-20020aa7d6d5000000b00431b7c050c9mr4115115edr.62.1654683105981; Wed, 08 Jun 2022 03:11:45 -0700 (PDT) Received: from [192.168.0.191] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id m26-20020a50ef1a000000b0042bae6fbee2sm11815721eds.74.2022.06.08.03.11.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 03:11:45 -0700 (PDT) Message-ID: Date: Wed, 8 Jun 2022 12:11:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 12/20] dt-bindings: reset: npcm: Add support for NPCM8XX Content-Language: en-US To: Tomer Maimon , avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, daniel.lezcano@linaro.org, tglx@linutronix.de, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, jirislaby@kernel.org, shawnguo@kernel.org, bjorn.andersson@linaro.org, geert+renesas@glider.be, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, nobuhiro1.iwamatsu@toshiba.co.jp, robert.hancock@calian.com, j.neuschaefer@gmx.net, lkundrak@v3.sk Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220608095623.22327-1-tmaimon77@gmail.com> <20220608095623.22327-13-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220608095623.22327-13-tmaimon77@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/06/2022 11:56, Tomer Maimon wrote: > Add binding document and device tree binding > constants for Nuvoton BMC NPCM8XX reset controller. > > Signed-off-by: Tomer Maimon > --- > .../bindings/reset/nuvoton,npcm-reset.yaml | 13 +- > .../dt-bindings/reset/nuvoton,npcm8xx-reset.h | 128 ++++++++++++++++++ > 2 files changed, 140 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/reset/nuvoton,npcm8xx-reset.h > > diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.yaml > index c6bbc1589ab9..93ea81686f58 100644 > --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.yaml > +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.yaml > @@ -9,9 +9,20 @@ title: Nuvoton NPCM Reset controller > maintainers: > - Tomer Maimon > > +description: | > + The NPCM reset controller used to reset various set of peripherals. > + Please refer to reset.txt in this directory for common reset > + controller binding usage. > + > + For list of all valid reset indices see > + for Poleg NPCM7XX SoC, > + for Arbel NPCM8XX SoC. > + > properties: > compatible: > - const: nuvoton,npcm750-reset > + enum: > + - nuvoton,npcm750-reset # Poleg NPCM7XX SoC > + - nuvoton,npcm845-reset # Arbel NPCM8XX SoC > > reg: > maxItems: 1 > diff --git a/include/dt-bindings/reset/nuvoton,npcm8xx-reset.h b/include/dt-bindings/reset/nuvoton,npcm8xx-reset.h > new file mode 100644 > index 000000000000..5b3b74534b50 > --- /dev/null > +++ b/include/dt-bindings/reset/nuvoton,npcm8xx-reset.h > @@ -0,0 +1,128 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ Again - ignored comment from v1. > +/* > + * Copyright (c) 2022 Nuvoton Technology corporation. > + * Author: Tomer Maimon > + */ > + > +#ifndef _DT_BINDINGS_NPCM8XX_RESET_H > +#define _DT_BINDINGS_NPCM8XX_RESET_H > + > +/* represent reset register offset */ > +#define NPCM8XX_RESET_IPSRST1 0x20 > +#define NPCM8XX_RESET_IPSRST2 0x24 > +#define NPCM8XX_RESET_IPSRST3 0x34 > +#define NPCM8XX_RESET_IPSRST4 0x74 > + > +/* Reset lines on IP1 reset module (NPCM8XX_RESET_IPSRST1) */ Again - ignored comment from v1. My last message was quite clear, wasn't it? https://lore.kernel.org/all/4a69902f-a545-23a1-1430-e5ece16997e9@linaro.org/ You ignored several of previous comments, so: NAK. Best regards, Krzysztof