Re: [PATCH 3/3] arm64: dts: mediatek: enable USB device port for mt8195-demo board

[Macpaul Lin <macpaul.lin@mediatek.com>]

On 1/6/23 20:56, Krzysztof Kozlowski wrote:
> On 05/01/2023 10:28, Macpaul Lin wrote:
>> 1. Enable USB device port (USB port0).
>> 2. Enable u2 speed for other USB HOST (USB port1/2/3).
>> 3. Configure mt6360 (TYPEC) related pinctrls.
>>
>> Note: Full dual-role switch capability requires TYPEC MUX driver and dts
>> update will be send in separate patches.
>>
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 51 ++++++++++++++++++++
>>   1 file changed, 51 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
>> index 07a864cb8b54..207bb5f4c58f 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts
>> @@ -12,6 +12,7 @@
>>   #include <dt-bindings/input/input.h>
>>   #include <dt-bindings/pinctrl/mt8195-pinfunc.h>
>>   #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
>> +#include <dt-bindings/usb/pd.h>
>>   
>>   / {
>>   	model = "MediaTek MT8195 demo board";
>> @@ -380,6 +381,22 @@
>>   		};
>>   	};
>>   
>> +	mt6360_pins: mt6360-pins {
>> +		pins {
>> +			pinmux = <PINMUX_GPIO100__FUNC_GPIO100>,
>> +				 <PINMUX_GPIO101__FUNC_GPIO101>;
>> +			input-enable;
>> +			bias-pull-up;
>> +		};
>> +	};
>> +
>> +	u3_p0_vbus: u3_p0vbusdefault {
> 
> No underscores in node names. Also does not look correct naming. Please
> run `make dtbs_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).

Thanks for the suggest.
I'm trying to request IT to setup for the environment for supporting 
"make dtbs_check". This should be fix in next patch.

>> +		pins_cmd_dat {
> 
> Same problem.
> 

Got it.

> 
> Best regards,
> Krzysztof
> 

Thanks!
Macpaul Lin