From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next] dt-bindings: net: convert sff,sfp to dtschema
Date: Wed, 30 Mar 2022 18:59:03 +0200 [thread overview]
Message-ID: <adeaa39d-2b93-d7bb-98fc-93eb040cec01@linaro.org> (raw)
In-Reply-To: <259ac0f4-50e9-291b-9ed3-91b52840fb9e@linaro.org>
On 30/03/2022 18:51, Krzysztof Kozlowski wrote:
(...)
>>
>> These examples are showing how the SFP gets hooked up directly to a MAC
>> or directly to a PHY. Would you prefer them to be in the ethernet-mac
>> and ethernet-phy yaml files instead? It seems utterly perverse to split
>> an example across several different yaml files.
>
> Probably PHY or MAC is better place, because it defines the "sfp" property.
>
> How is it different from other cases like this in bindings (clocks,
> power domains, GPIOs)? IOW, why SFP is special? If it is, sure, let's
> keep it here...
BTW, Rob actually pointed out the difference here - it's only one such
provider binding (unlike clock controllers) - and said it's fine, so
good for me.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-30 16:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 12:33 [PATCH net-next] dt-bindings: net: convert sff,sfp to dtschema Ioana Ciornei
2022-03-15 18:21 ` Krzysztof Kozlowski
2022-03-15 19:07 ` Ioana Ciornei
2022-03-16 8:23 ` Krzysztof Kozlowski
2022-03-16 10:18 ` Ioana Ciornei
2022-03-16 12:04 ` Krzysztof Kozlowski
2022-03-30 15:54 ` Russell King (Oracle)
2022-03-30 15:56 ` Russell King (Oracle)
2022-03-30 16:44 ` Krzysztof Kozlowski
2022-03-30 15:52 ` Russell King (Oracle)
2022-03-30 16:09 ` Rob Herring
2022-03-30 16:35 ` Russell King (Oracle)
2022-03-30 15:40 ` Russell King (Oracle)
2022-03-30 16:51 ` Krzysztof Kozlowski
2022-03-30 16:59 ` Krzysztof Kozlowski [this message]
2022-03-31 20:45 ` Krzysztof Kozlowski
2022-06-10 22:31 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adeaa39d-2b93-d7bb-98fc-93eb040cec01@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).