From: Mark Brown <broonie@kernel.org>
To: Sen Wang <sen@ti.com>
Cc: linux-sound@vger.kernel.org, lgirdwood@gmail.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, perex@perex.cz, tiwai@suse.com,
shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com,
niranjan.hy@ti.com, l-badrinarayanan@ti.com, devarsht@ti.com,
v-singh1@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] ASoC: codecs: Add TAS67524 quad-channel audio amplifier driver
Date: Fri, 10 Apr 2026 15:02:37 +0100 [thread overview]
Message-ID: <adkC_fNHcpRA_ffo@sirena.co.uk> (raw)
In-Reply-To: <20260409220607.686146-3-sen@ti.com>
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
On Thu, Apr 09, 2026 at 05:06:04PM -0500, Sen Wang wrote:
> The TAS675x (TAS6754, TAS67524) are quad-channel, digital-input
> Class-D amplifiers with an integrated DSP, controlled over I2C.
> They support I2S and TDM serial audio interfaces.
This looks mostly good, but one issue I see is that AFAICT we only stop
fault_check_work during runtime suspsend - if runtime PM is disabled, or
if the driver is removed, the work will be left running.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-10 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 22:06 [PATCH v5 0/4] ASoC: Add TAS67524 quad-channel Class-D amplifier driver Sen Wang
2026-04-09 22:06 ` [PATCH v5 1/4] ASoC: dt-bindings: Add ti,tas67524 Sen Wang
2026-04-09 22:06 ` [PATCH v5 2/4] ASoC: codecs: Add TAS67524 quad-channel audio amplifier driver Sen Wang
2026-04-10 14:02 ` Mark Brown [this message]
2026-04-09 22:06 ` [PATCH v5 3/4] Documentation: sound: Add TAS675x codec mixer controls documentation Sen Wang
2026-04-09 22:06 ` [PATCH v5 4/4] MAINTAINERS: add entry for TAS67524 audio amplifier Sen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adkC_fNHcpRA_ffo@sirena.co.uk \
--to=broonie@kernel.org \
--cc=baojun.xu@ti.com \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=krzk+dt@kernel.org \
--cc=l-badrinarayanan@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
--cc=v-singh1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox