public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Koskovich <akoskovich@pm.me>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support
Date: Mon, 13 Apr 2026 07:52:27 +0000	[thread overview]
Message-ID: <adyfWzVHsg3qo9cH@prism> (raw)

On Tue, Mar 31, 2026 at 01:37:24PM +0300, Abel Vesa wrote:
> The Eliza MTP features a single USB Type-C port. Its USB 2.0 lines are
> routed through an eUSB2 repeater provided by the PM7750BA PMIC.
> 
> Describe the port and repeater, and enable the USB controller and PHYs.
> 
> Also specify the ADSP firmware and enable the remoteproc.
> 
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/eliza-mtp.dts | 83 ++++++++++++++++++++++++++++++++++
>  1 file changed, 83 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> index 90f629800cb0..c31f00e36eee 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> @@ -6,9 +6,12 @@
>  /dts-v1/;
...
>  
> +&usb_hsphy {
> +	vdd-supply = <&vreg_l2b>;

Shouldn't this be l7k? Looking at kera-usb.dtsi I see the vdd-supply for
eusb2_phy0 as l7k. I don't see this being overriden by anything else
downstream either.

Just bringing it up since I copied this part for another Eliza platform
(USB 2 only) and USB failed until I fixed this supply.

> +	vdda12-supply = <&vreg_l4b>;
> +
> +	phys = <&pm7550ba_eusb2_repeater>;
> +
> +	status = "okay";
> +};
> 
> -- 
> 2.48.1
> 


             reply	other threads:[~2026-04-13  7:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13  7:52 Alexander Koskovich [this message]
2026-04-13  8:33 ` [PATCH 3/3] arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support Konrad Dybcio
  -- strict thread matches above, loose matches on Subject: below --
2026-03-31 10:37 [PATCH 0/3] arm64: dts: qcom: eliza: Add ADSP and USB support Abel Vesa
2026-03-31 10:37 ` [PATCH 3/3] arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support Abel Vesa
2026-03-31 11:12   ` Konrad Dybcio
2026-03-31 13:27   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adyfWzVHsg3qo9cH@prism \
    --to=akoskovich@pm.me \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox