Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add ov2735 sensor

[Krzysztof Kozlowski <krzk@kernel.org>]

On 08/07/2025 12:25, Hardevsinh Palaniya wrote:
> +
> +  clocks:
> +    items:
> +      - description: XVCLK clock
> +
> +  clock-names:
> +    items:
> +      - const: xvclk
> +
> +  AVDD-supply:

Use lowercase everywhere.

> +    description: Analog Domain Power Supply
> +
> +  DOVDD-supply:
> +    description: I/O Domain Power Supply
> +
> +  DVDD-supply:
> +    description: Digital Domain Power Supply
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: Reset Pin GPIO Control (active low)
> +
> +  pwdn-gpios:

Use instead recommended name from the gpio-consumer-common.yaml.

> +    maxItems: 1
> +    description: Powerdown Pin GPIO Control (active low)
> +
> +  port:
> +    description: MIPI CSI-2 transmitter port
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            items:
> +              - const: 1
> +              - const: 2
> +
> +        required:
> +          - data-lanes
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - port


Supplies should be required. Devices rarely work without power.


Best regards,
Krzysztof