devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: sm8750: Add capacity and DPC properties
@ 2025-12-26 12:32 Ankit Sharma
  2025-12-27 10:15 ` Krzysztof Kozlowski
  2025-12-29 11:35 ` Konrad Dybcio
  0 siblings, 2 replies; 3+ messages in thread
From: Ankit Sharma @ 2025-12-26 12:32 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Ankit Sharma

The "capacity-dmips-mhz" and "dynamic-power-coefficient" are
used to build Energy Model which in turn is used by EAS to take
placement decisions.

Signed-off-by: Ankit Sharma <ankit.sharma@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8750.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index 3f0b57f428bb..c93511bf4625 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -37,6 +37,8 @@ cpu0: cpu@0 {
 			next-level-cache = <&l2_0>;
 			power-domains = <&cpu_pd0>;
 			power-domain-names = "psci";
+			capacity-dmips-mhz = <1792>;
+			dynamic-power-coefficient = <238>;

 			l2_0: l2-cache {
 				compatible = "cache";
@@ -53,6 +55,8 @@ cpu1: cpu@100 {
 			next-level-cache = <&l2_0>;
 			power-domains = <&cpu_pd1>;
 			power-domain-names = "psci";
+			capacity-dmips-mhz = <1792>;
+			dynamic-power-coefficient = <238>;
 		};

 		cpu2: cpu@200 {
@@ -63,6 +67,8 @@ cpu2: cpu@200 {
 			next-level-cache = <&l2_0>;
 			power-domains = <&cpu_pd2>;
 			power-domain-names = "psci";
+			capacity-dmips-mhz = <1792>;
+			dynamic-power-coefficient = <238>;
 		};

 		cpu3: cpu@300 {
@@ -73,6 +79,8 @@ cpu3: cpu@300 {
 			next-level-cache = <&l2_0>;
 			power-domains = <&cpu_pd3>;
 			power-domain-names = "psci";
+			capacity-dmips-mhz = <1792>;
+			dynamic-power-coefficient = <238>;
 		};

 		cpu4: cpu@400 {
@@ -83,6 +91,8 @@ cpu4: cpu@400 {
 			next-level-cache = <&l2_0>;
 			power-domains = <&cpu_pd4>;
 			power-domain-names = "psci";
+			capacity-dmips-mhz = <1792>;
+			dynamic-power-coefficient = <238>;
 		};

 		cpu5: cpu@500 {
@@ -93,6 +103,8 @@ cpu5: cpu@500 {
 			next-level-cache = <&l2_0>;
 			power-domains = <&cpu_pd5>;
 			power-domain-names = "psci";
+			capacity-dmips-mhz = <1792>;
+			dynamic-power-coefficient = <238>;
 		};

 		cpu6: cpu@10000 {
@@ -103,6 +115,8 @@ cpu6: cpu@10000 {
 			next-level-cache = <&l2_1>;
 			power-domains = <&cpu_pd6>;
 			power-domain-names = "psci";
+			capacity-dmips-mhz = <1894>;
+			dynamic-power-coefficient = <588>;

 			l2_1: l2-cache {
 				compatible = "cache";
@@ -119,6 +133,8 @@ cpu7: cpu@10100 {
 			next-level-cache = <&l2_1>;
 			power-domains = <&cpu_pd7>;
 			power-domain-names = "psci";
+			capacity-dmips-mhz = <1894>;
+			dynamic-power-coefficient = <588>;
 		};

 		cpu-map {
--
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sm8750: Add capacity and DPC properties
  2025-12-26 12:32 [PATCH] arm64: dts: qcom: sm8750: Add capacity and DPC properties Ankit Sharma
@ 2025-12-27 10:15 ` Krzysztof Kozlowski
  2025-12-29 11:35 ` Konrad Dybcio
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-27 10:15 UTC (permalink / raw)
  To: Ankit Sharma, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 26/12/2025 13:32, Ankit Sharma wrote:
> The "capacity-dmips-mhz" and "dynamic-power-coefficient" are
> used to build Energy Model which in turn is used by EAS to take
> placement decisions.

Don't state the obvious, but rather say how did you get the values.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sm8750: Add capacity and DPC properties
  2025-12-26 12:32 [PATCH] arm64: dts: qcom: sm8750: Add capacity and DPC properties Ankit Sharma
  2025-12-27 10:15 ` Krzysztof Kozlowski
@ 2025-12-29 11:35 ` Konrad Dybcio
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2025-12-29 11:35 UTC (permalink / raw)
  To: Ankit Sharma, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 12/26/25 1:32 PM, Ankit Sharma wrote:
> The "capacity-dmips-mhz" and "dynamic-power-coefficient" are
> used to build Energy Model which in turn is used by EAS to take
> placement decisions.
> 
> Signed-off-by: Ankit Sharma <ankit.sharma@oss.qualcomm.com>
> ---

Is it really necessary? Does our CPUFREQ-via-SCMI service not provide
energy model data?

(see: drivers/cpufreq/scmi-cpufreq.c : scmi_cpufreq_register_em())

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-12-29 11:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-26 12:32 [PATCH] arm64: dts: qcom: sm8750: Add capacity and DPC properties Ankit Sharma
2025-12-27 10:15 ` Krzysztof Kozlowski
2025-12-29 11:35 ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).