From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH v2 1/4] net: dsa: Change DT bindings for Vitesse VSC73xx switches Date: Thu, 4 Jul 2019 13:22:10 -0700 Message-ID: References: <20190703171924.31801-1-paweldembicki@gmail.com> <20190703171924.31801-2-paweldembicki@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij , Pawel Dembicki Cc: Andrew Lunn , Vivien Didelot , "David S. Miller" , Rob Herring , Mark Rutland , netdev , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 7/4/2019 12:05 AM, Linus Walleij wrote: > On Wed, Jul 3, 2019 at 7:21 PM Pawel Dembicki wrote: > >> This commit introduce how to use vsc73xx platform driver. >> >> Signed-off-by: Pawel Dembicki > > Nice! > >> +If Platform driver is used, the device tree node is an platform device so it >> +must reside inside a platform bus device tree node. > > I would write something like "when connected to a memory bus, and > used in memory-mapped I/O mode, a platform device is used to represent > the vsc73xx" so it is clear what is going on. Agreed, with that fixed: Reviewed-by: Florian Fainelli -- Florian