* [PATCH v2] dt-bindings: ufs: Add msi-parent for UFS MCQ
@ 2023-11-22 5:06 Ziqi Chen
2023-11-22 7:39 ` Krzysztof Kozlowski
2023-11-22 17:53 ` Bart Van Assche
0 siblings, 2 replies; 5+ messages in thread
From: Ziqi Chen @ 2023-11-22 5:06 UTC (permalink / raw)
To: quic_asutoshd, quic_cang, bvanassche, mani, stanley.chu,
adrian.hunter, beanhuo, avri.altman, junwoo80.lee,
martin.petersen, quic_ziqichen, quic_nguyenb, quic_nitirawa
Cc: linux-scsi, Alim Akhtar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Guenter Roeck, Wolfram Sang, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The Message Signaled Interrupts (MSI) support has been
introduced in UFSHCI version 4.0 (JESD223E). The MSI is
the recommended interrupt approach for MCQ. If choose to
use MSI, In UFS DT, we need to provide msi-parent property
that point to the hardware entity which serves as the MSI
controller for this UFS controller.
Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
Changes to v1:
- Rebased on Linux 6.7-rc1.
- Updated the commit message to incorporate the details about
when MCQ/MSI got introduced.
---
Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
index 985ea8f..31fe7f3 100644
--- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
+++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
@@ -87,6 +87,8 @@ properties:
description:
Specifies max. load that can be drawn from VCCQ2 supply.
+ msi-parent: true
+
dependencies:
freq-table-hz: [ clocks ]
operating-points-v2: [ clocks, clock-names ]
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-22 5:06 [PATCH v2] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
@ 2023-11-22 7:39 ` Krzysztof Kozlowski
2023-11-27 2:49 ` Ziqi Chen
2023-11-22 17:53 ` Bart Van Assche
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-22 7:39 UTC (permalink / raw)
To: Ziqi Chen, quic_asutoshd, quic_cang, bvanassche, mani,
stanley.chu, adrian.hunter, beanhuo, avri.altman, junwoo80.lee,
martin.petersen, quic_nguyenb, quic_nitirawa
Cc: linux-scsi, Alim Akhtar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Guenter Roeck, Wolfram Sang, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 22/11/2023 06:06, Ziqi Chen wrote:
> The Message Signaled Interrupts (MSI) support has been
> introduced in UFSHCI version 4.0 (JESD223E). The MSI is
> the recommended interrupt approach for MCQ. If choose to
> use MSI, In UFS DT, we need to provide msi-parent property
> that point to the hardware entity which serves as the MSI
> controller for this UFS controller.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-22 7:39 ` Krzysztof Kozlowski
@ 2023-11-27 2:49 ` Ziqi Chen
0 siblings, 0 replies; 5+ messages in thread
From: Ziqi Chen @ 2023-11-27 2:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, quic_asutoshd, quic_cang, bvanassche, mani,
stanley.chu, adrian.hunter, beanhuo, avri.altman, junwoo80.lee,
martin.petersen, quic_nguyenb, quic_nitirawa
Cc: linux-scsi, Alim Akhtar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Guenter Roeck, Wolfram Sang, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Thank you , will re-wrap commit message.
-Ziqi
On 11/22/2023 3:39 PM, Krzysztof Kozlowski wrote:
> On 22/11/2023 06:06, Ziqi Chen wrote:
>> The Message Signaled Interrupts (MSI) support has been
>> introduced in UFSHCI version 4.0 (JESD223E). The MSI is
>> the recommended interrupt approach for MCQ. If choose to
>> use MSI, In UFS DT, we need to provide msi-parent property
>> that point to the hardware entity which serves as the MSI
>> controller for this UFS controller.
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-22 5:06 [PATCH v2] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
2023-11-22 7:39 ` Krzysztof Kozlowski
@ 2023-11-22 17:53 ` Bart Van Assche
2023-11-27 2:36 ` Ziqi Chen
1 sibling, 1 reply; 5+ messages in thread
From: Bart Van Assche @ 2023-11-22 17:53 UTC (permalink / raw)
To: Ziqi Chen, quic_asutoshd, quic_cang, mani, stanley.chu,
adrian.hunter, beanhuo, avri.altman, junwoo80.lee,
martin.petersen, quic_nguyenb, quic_nitirawa
Cc: linux-scsi, Alim Akhtar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Guenter Roeck, Wolfram Sang, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 11/21/23 21:06, Ziqi Chen wrote:
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> index 985ea8f..31fe7f3 100644
> --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> @@ -87,6 +87,8 @@ properties:
> description:
> Specifies max. load that can be drawn from VCCQ2 supply.
>
> + msi-parent: true
> +
> dependencies:
> freq-table-hz: [ clocks ]
> operating-points-v2: [ clocks, clock-names ]
Does this patch break support for UFSHCI 4.0 controllers that do not support MSI?
Thanks,
Bart.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-22 17:53 ` Bart Van Assche
@ 2023-11-27 2:36 ` Ziqi Chen
0 siblings, 0 replies; 5+ messages in thread
From: Ziqi Chen @ 2023-11-27 2:36 UTC (permalink / raw)
To: Bart Van Assche, quic_asutoshd, quic_cang, mani, stanley.chu,
adrian.hunter, beanhuo, avri.altman, junwoo80.lee,
martin.petersen, quic_nguyenb, quic_nitirawa
Cc: linux-scsi, Alim Akhtar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Guenter Roeck, Wolfram Sang, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 11/23/2023 1:53 AM, Bart Van Assche wrote:
> On 11/21/23 21:06, Ziqi Chen wrote:
>> diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
>> b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
>> index 985ea8f..31fe7f3 100644
>> --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
>> @@ -87,6 +87,8 @@ properties:
>> description:
>> Specifies max. load that can be drawn from VCCQ2 supply.
>> + msi-parent: true
>> +
>> dependencies:
>> freq-table-hz: [ clocks ]
>> operating-points-v2: [ clocks, clock-names ]
>
> Does this patch break support for UFSHCI 4.0 controllers that do not
> support MSI?
No, the controllers that do not support MSI would NOT be impacted by
this patch.
-Ziqi
>
> Thanks,
>
> Bart.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-27 2:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-22 5:06 [PATCH v2] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
2023-11-22 7:39 ` Krzysztof Kozlowski
2023-11-27 2:49 ` Ziqi Chen
2023-11-22 17:53 ` Bart Van Assche
2023-11-27 2:36 ` Ziqi Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).