From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50EC3C6379F for ; Tue, 21 Feb 2023 13:38:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233880AbjBUNiL (ORCPT ); Tue, 21 Feb 2023 08:38:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233863AbjBUNiJ (ORCPT ); Tue, 21 Feb 2023 08:38:09 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38BC6DBCC for ; Tue, 21 Feb 2023 05:38:03 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id eg37so13524493edb.12 for ; Tue, 21 Feb 2023 05:38:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jEKp5jxwSSp5xv1BprgYnfrSsvOH2oqVyu+hm71G5FA=; b=rF//HoJWLXcJthbLa7TIgEu0wOI//lZV5cE0z6TSi9Y6/DlAjSo5YbZr7OY6zwoYLz qeVptqcYvdbsYz9VXWMyaE5v36tGYKkcZjB5uL9EuLDgLa6Vr1jag1FrA2l/5wfHliSy fKD+js2T48YSBcQHmUBandzjMDsgwrKygnlgcS253My4hKbaGrb06xcDmE73J/tTaSox k4DtJkZNxsCpBBQJkbhClsEBwnEdUgJkeKhIBg+7bH2VlgjMNNAEGolcGw+OWIo3kOrI imH0de/B61hXN7ngislSUdcsfLHyaDfXDs75LxdH05EeRdZgVtz3a2i5XV3eNVBopREu A8AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jEKp5jxwSSp5xv1BprgYnfrSsvOH2oqVyu+hm71G5FA=; b=e5FD1PPUoHfLej0ABK3jhRIo9ARdVKXicaCuAPrCcr2eypLfzCitjmqNStzCyuMP23 NNpUAUhGm/sjxcc41jEPw3/XqwJPA6JblLO5n3sACFRDpDaVScYT9HS2k2dpmcFrLnGW sP/g9oxJNmfGQ3S/YhhtiLT5UEjoIMGZGrBuOURc1xYPxVd+GnX8hioBQqzQnyglF2bd cJcqBMiPBHusu7cbL+ZEFY+sBjDqpZaghDO7jTmu7keRYMY/+g6ccIPqNG0hVreYiJU7 fjsapWZrQWbAIh7vNACHL4xQD/PbiJ3Aqvn0l+b9nGX508GWeEbpnBvkIaG1l5S4f+Ub +8Tw== X-Gm-Message-State: AO0yUKUJvzsASHupuuv6RyVEkfKli9OboS0lruYZt7S2oxsa6ieXyB6k OavhE7bJv4dkWsxsgN1Vg437BPq7zswGvmVV X-Google-Smtp-Source: AK7set8b68dqxaiVXuJPBrEAexAK6vPXVsKEK7Ugt5Ougrz5aWPm3HYk/qg14MA5JIqtzCnZml+91Q== X-Received: by 2002:a17:906:490b:b0:8b1:3a8f:a51 with SMTP id b11-20020a170906490b00b008b13a8f0a51mr9970495ejq.15.1676986681679; Tue, 21 Feb 2023 05:38:01 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id r27-20020a50d69b000000b004acd14ab4dfsm2262994edi.41.2023.02.21.05.38.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 05:38:01 -0800 (PST) Message-ID: Date: Tue, 21 Feb 2023 14:37:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 01/11] dt-bindings: clock: Add StarFive JH7110 System-Top-Group clock and reset generator To: Xingyu Wu Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Philipp Zabel , Emil Renner Berthing , Rob Herring , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Hal Feng , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20230221083323.302471-1-xingyu.wu@starfivetech.com> <20230221083323.302471-2-xingyu.wu@starfivetech.com> <430318ed-5b30-e549-a5ce-df83aa18adf9@linaro.org> <43d00fd9-ab24-442e-3f82-208edaf399d0@starfivetech.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <43d00fd9-ab24-442e-3f82-208edaf399d0@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/02/2023 14:01, Xingyu Wu wrote: > On 2023/2/21 19:25, Krzysztof Kozlowski wrote: >> On 21/02/2023 09:33, Xingyu Wu wrote: >>> Add bindings for the System-Top-Group clock and reset generator (STGCRG) >>> on the JH7110 RISC-V SoC by StarFive Ltd. >>> >>> Signed-off-by: Xingyu Wu >> >> >>> + }; >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 93eb504c3b21..2e70c9f21989 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -19914,6 +19914,7 @@ F: arch/riscv/boot/dts/starfive/ >>> STARFIVE JH71X0 CLOCK DRIVERS >>> M: Emil Renner Berthing >>> M: Hal Feng >>> +M: Xingyu Wu >> >> No improvements here. You add here new bindings for one device and then >> - without explanation - add yourself to all Starfive clock bindings. >> Either explain it or drop it or move it to separate patch. >> >> You already got comment for this. >> > > Sorry, I didn't understand what you meant before. Now my understanding is that, > If I improvements JH71X0 driver no JH7110 driver, I could add this here. Right? > > Is it OK if I do it this way to move it to separate patch like this?: > +STARFIVE JH7110 STG CLOCK DRIVERS > +M: Xingyu Wu If you want to be the maintainer of all drivers, add separate commit for this, so this is obvious. Or at least explain this change in commit msg. Best regards, Krzysztof