From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Kevin Hilman <khilman@baylibre.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
tzungbi@google.com, Chen-Yu Tsai <wenst@chromium.org>,
cujomalainey@google.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v7 1/1] firmware: mediatek: add adsp ipc protocol interface
Date: Wed, 25 May 2022 12:41:41 +0200 [thread overview]
Message-ID: <ae47e12b-396c-a5a0-2da2-2010237fbbc2@collabora.com> (raw)
In-Reply-To: <54d6c0ff-d93c-0506-4db9-3852c69211ab@collabora.com>
Il 25/05/22 12:39, AngeloGioacchino Del Regno ha scritto:
> Il 07/04/22 15:03, Allen-KH Cheng ha scritto:
>> From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
>>
>> Some of mediatek processors contain
>> the Tensilica HiFix DSP for audio processing.
>>
>> The communication between Host CPU and DSP firmware is
>> taking place using a shared memory area for message passing.
>>
>> ADSP IPC protocol offers (send/recv) interfaces using
>> mediatek-mailbox APIs.
>>
>> We use two mbox channels to implement a request-reply protocol.
>>
>> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
>> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> Reviewed-by: Curtis Malainey <cujomalainey@chromium.org>
>> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
>> Reviewed-by: YC Hung <yc.hung@mediatek.com>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>> drivers/firmware/Kconfig | 1 +
>> drivers/firmware/Makefile | 1 +
>> drivers/firmware/mediatek/Kconfig | 9 +
>> drivers/firmware/mediatek/Makefile | 2 +
>> drivers/firmware/mediatek/mtk-adsp-ipc.c | 161 ++++++++++++++++++
>> .../linux/firmware/mediatek/mtk-adsp-ipc.h | 65 +++++++
>> 6 files changed, 239 insertions(+)
>> create mode 100644 drivers/firmware/mediatek/Kconfig
>> create mode 100644 drivers/firmware/mediatek/Makefile
>> create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c
>> create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h
>>
>
> Gentle ping for this one, as it's getting stale... and it's ready.
>
> To add context, this driver is *really* necessary, as support for it
> is added in the MT8195 ASoC SOF driver as a platform device [1], and the
> necessary memory regions are coming from the mediatek,mt8195-dsp [2] driver.
>
> [1]:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/sound/soc/sof/mediatek/mt8195/mt8195.c?h=next-20220525#n389
>
>
> [2]:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml?h=next-20220525#n61
>
>
> Cheers,
> Angelo
I'm sorry, ignore me, another version of this one was already merged.
next prev parent reply other threads:[~2022-05-25 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 13:03 [PATCH v7 0/1] firmware: mtk: add adsp ipc protocol for SOF Allen-KH Cheng
2022-04-07 13:03 ` [PATCH v7 1/1] firmware: mediatek: add adsp ipc protocol interface Allen-KH Cheng
2022-05-25 10:39 ` AngeloGioacchino Del Regno
2022-05-25 10:41 ` AngeloGioacchino Del Regno [this message]
2022-04-07 14:27 ` [PATCH v7 0/1] firmware: mtk: add adsp ipc protocol for SOF Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae47e12b-396c-a5a0-2da2-2010237fbbc2@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cujomalainey@google.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).